From patchwork Tue Dec 3 23:27:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13893080 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2067.outbound.protection.outlook.com [40.107.105.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2822320A5E3 for ; Tue, 3 Dec 2024 23:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733268469; cv=fail; b=C522DMAVBH1+TbVXlIJLmCh9Ls0HQKShvc9f/bv85KplhD1HlSkKqPHc2Gdp1hvpgVLwCIxH8dqBrk85G5Totg4c82j10O/eRD2xjRRKTGg3kzgt1zIMoETFHtZsuy0fPsuh+VVLIhWXlmSlbetFifoR/HblsqANauuc+kB35IM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733268469; c=relaxed/simple; bh=rXhNqwdgirRPqijx7i4RJfbC7AudsiBL7xFaxLL5LAQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kgbN17lGFa0FdhgzowpLdQ2oxzkMlTZBHKZbPwi1HKypGnbqj6TLpXnfpObhM8F9erKBdB2EMkYBNH2Oe+O+ZYaohCTrR5/SNV4wc5RDvvhXf/h+o0N/Hz+pXPFIgzDrEgH/G4onBAsEXc33J8r2VDO5kKb0mP2w12B8jgP4C/k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=b+4iR4lS; arc=fail smtp.client-ip=40.107.105.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="b+4iR4lS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gtoM2NtgZM4G1Z3G38yOE9LHI1Ou1swzvX0Lb7/GHovEpefVyDBbpB3Ww4yhCSuD5fO2cv9F/oUWsZ2lR8kc1u6PLC56N8YhqaxAdOgVfsDx8L8b+AkV5NqavUsOL4tkRCRo8Rik5vKsi3RuevggzZbG7Kd3hhH6wgqpkoc6zFXVqMX+EhxvqYxqLavyRAyfrV7W2NJrEONauzzNyUM3kIJOa8h+Itt8/SUkFO7u0EXeM4ChridPBBsyQV9Up0ELoYt7Xoe9ObJOHXOorQHsrqquOy/j04Knh3T0BEGjMYLfbXQBqTlQDqLzpw/PBHyzrLEU7BbjTs98ufxI/ZU//Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3mpFJRyM8rsbkTuLLftvVbBxxmv+3Sp+Y18ElK0+EmI=; b=OVanvwZUau1ltpMy2APnX1x+3Kb+SeJMxWENXjTrpIJFw116kJH03CuiGlW9w8cuA5mZ1JZ33WhHtHKDlZtAbW8q0sc1GPGf5crss/tUwqVfBKlDTqEl2GI/XG40aM316mKmF1ug0AK6Iq2aBV/zBJFK075+KDX1e2j4DdTNQIep2tM/qjInqvEkC4VtNtJk/rDl+5hrtjtDPO96EFcNsL08QqjHNO4CWIkr8IdH33J+f5p+3ci+IRuY5XUgqcc8lhMKwkNPD6VzB/FEd9b/WlgWc959zFL3xqxoT4dD/SXnUzxya5Pks7dvT3A/WYwquc/Wae7OvAsVZWVN5X7Y1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3mpFJRyM8rsbkTuLLftvVbBxxmv+3Sp+Y18ElK0+EmI=; b=b+4iR4lStLa4E2RqUVluTbxZKEFMbazh+j+KKogtaXwJ9PmPBwop1BnRJv4hDJVEPMuawVUQKtsN47iWpvwbh46gEEqVYdUbqwqr02KQBTy7o+RDM9obU1k8NkcAu5mD8cUt8LzmSxPqWL5L+Vhgtn7gUzwtZFLH2wpbZd2DBFpzx+fju08x0LPk4K6hpJ4iozqeczkFxgeE0arkQ6or4swlDIK41nh520Cmv870wJjaWFg5sU5BMt0AnPVDz7g7puA0evyOAOTHEPbUeWuIXC1AuU5E7Zshh+QKWOjTIVbjHQkWzj3CGvvs4jyNxun3P4GFw7FqkCa5c8cfdAeSaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8846.eurprd04.prod.outlook.com (2603:10a6:102:20d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.19; Tue, 3 Dec 2024 23:27:43 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.8207.017; Tue, 3 Dec 2024 23:27:43 +0000 From: Frank Li Date: Tue, 03 Dec 2024 18:27:16 -0500 Subject: [PATCH v7 2/2] PCI: imx6: Add IOMMU and ITS MSI support for i.MX95 Message-Id: <20241203-imx95_lut-v7-2-d0cd6293225e@nxp.com> References: <20241203-imx95_lut-v7-0-d0cd6293225e@nxp.com> In-Reply-To: <20241203-imx95_lut-v7-0-d0cd6293225e@nxp.com> To: Bjorn Helgaas , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Frank.li@nxp.com, alyssa@rosenzweig.io, bpf@vger.kernel.org, broonie@kernel.org, jgg@ziepe.ca, joro@8bytes.org, l.stach@pengutronix.de, lgirdwood@gmail.com, maz@kernel.org, p.zabel@pengutronix.de, robin.murphy@arm.com, will@kernel.org, Robin Murphy , Marc Zyngier , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733268445; l=8868; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=rXhNqwdgirRPqijx7i4RJfbC7AudsiBL7xFaxLL5LAQ=; b=JfU1yYrnBR0XrgK2ehuoXBbhcSAxNnSo7Ft6lKLFdaQNK4p2BIKke2wYBSV0pYPs8euZxITF0 RUzC3EBiUsgBAv+rGhp5EBV+8rsD3zZczxB/JIRxm2Rb9vPxIhuDhFj X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0128.namprd13.prod.outlook.com (2603:10b6:a03:2c6::13) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8846:EE_ X-MS-Office365-Filtering-Correlation-Id: 10ae0996-8a30-4c76-68e8-08dd13f2167d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|52116014|366016|376014|7416014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?5HwSTavs/7yhPfmzbYFlMVLkJ2+74j8?= =?utf-8?q?nxHJi0xcQDcA8w/k6eTXzpX3nflizL0dt8u6ugk+aBzfbTWcI9NfG6t7Vu/fMs0bz?= =?utf-8?q?PEf/nBCPlCfVVIKTKH+ymdfSbdLvK0yCsy86Exj3a6yX4o//0ZTxmnr3uGL1t2iCJ?= =?utf-8?q?iX9EyaeumDnmZdYb69uNeNWRpVo85F9cmj7MhFn9Oh/IECtw0jLr0LcqkUEeCi84R?= =?utf-8?q?Z7Xj5JHqvX/6VP1/daobswxwD4KCjsl2XWBiFS1/cR8b+ADGaz5OtzIdDScLsEU+C?= =?utf-8?q?3ZEnz8ofohs6jbpERScRz0Og62NCyrxXCuFWC9Z7CBH4Vu/kspx/82L+T0B53ahaA?= =?utf-8?q?a32Rc580r1L/QyPyhDn+ELI6/KYqDwqF1yllgNiPPQKwfgfUk030VlfGAfVRe3yvM?= =?utf-8?q?wkpmUntSYBw3dOl/BIs0ZkwRHcPZecp2YeGDhNQ/bIb+NFz+6j1JeT2cCFpYMVtYP?= =?utf-8?q?J8U07BS9Q9KhW1UWLY9Fy+PGoSNl4HrqLCMeTO/MMlrxXBGit61sB884kCof27W8F?= =?utf-8?q?lfbdOyKRUV5165yMWf6TuHF3zgetob6kEjDKaR2TIc2uNPQf7vhQz6h9gQuLtRERz?= =?utf-8?q?obdkzDLZO5IE38gQQpLiDX8xurCkGZSlA8hO2vtVngelBgFQCY4ayTXvH3c3qIeaA?= =?utf-8?q?9M/LE4xU18YG2pHpSUMxCKUqrZYDpgD0l6sJ614UZ3u1deDjeQjg3ABXkzSdZH+Nf?= =?utf-8?q?gcXaE92VW32DhPqLb84wM7xIU42cIiMEGdr2yyNtvIZT4R+nDaLtWYd9QVESjJF66?= =?utf-8?q?UTXswdO78V1A1BZSmM07yKz25LApR4wP01DjkhBncPEj80C4BvcAB8BgYNvBRFbyT?= =?utf-8?q?UcxlIgQq8M9D1FQ5qvILIFYj/wcxofQYxLydaTSOZiO8LH50kkqFyKmGlfGlTByjP?= =?utf-8?q?jLlHWizqD0vbbaeR3rjdwZvBSL17KxDbaM3hQLRE843imIqvVA38p3qUaVqOkMGL9?= =?utf-8?q?on3UQjo5tN1XXmGtetBVG4tUjOvL6R2CHFzAapBie87Zh+Sxdk3vOQVLYsm+Yu1+f?= =?utf-8?q?oU4J3k4R9Cmz2IwORVmWUOgQH8Kv6fKi1QRHNLxiGr89hLWLulTbLOl1ExP7ToM04?= =?utf-8?q?7LSEk+aTsYu5R6NRxYTv1wbfTCv2OSkd/K0JupRcnAmjyDx6CABwrXD2g/Qcr2oel?= =?utf-8?q?ox6OhwOWMbAzhQ8Dc+UdnDNZL4Xi5sqGpJpP6C7F/8r3nyb/gKNDpUIDGnDW8FJmf?= =?utf-8?q?rM2WMTXX4T4AGCSBvdaCixufSxmrYwwDTiaf3FnGVdxEvOB9GcsWodd9k3HBO+hBv?= =?utf-8?q?zgU2OYjep1YxKcMGr7gQas5y+6Kqi5huYtJKndIkr7vusHI0zFjlvFwDCoDxKINuA?= =?utf-8?q?X6OjrNuF6ZLTHzVeG5nItryzFXYFv4/wEnugIDoD0k5nNw9tnQToPd0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(52116014)(366016)(376014)(7416014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?I/owmzp0t0NQD71TNWNqGpEG7h1K?= =?utf-8?q?r5wOkFnqOpa2XzNcgpTFanfKW4E4iMgGwHZ1JBrOJTvfoj081I8/Np5LUPWWW5GA/?= =?utf-8?q?aeXBje1lyaSYQ45ro3Jf19u3viuDVzaVv93kk+05fuO/00z/PzuJWSyYg2TsSbQjZ?= =?utf-8?q?P5Bkh27AXAYE88kJnnJAL8CDztvdDddd7VGZJOBlDShLpjofbSGGTxgZ96sA9/5DA?= =?utf-8?q?qTqKWSeJBeo98FeDSIB/G0RSkIA6wzaEyI3NOLpqmliw/uZAM6HSzUcALUGBUDdK6?= =?utf-8?q?lr0dbyfu/pPtCWUDDty1pfxjMtZIVAjP9rk+DxVq4mvksEqkyJKzAmhM+2hV3MkEy?= =?utf-8?q?yh9XyXog5TH/PUx5u9+Gb33auVfrSZbuqSXoGq9k+gH98XqiDTyWHc2WEF4tmbPrA?= =?utf-8?q?qJhHLwkmO4R0QhsN2AR0jDBr5fQI0xvbPveKGTh+rQh7pu35lMw3ebK2b2BnCYpWr?= =?utf-8?q?VXGlR1vlURl3nCni7zl6OJSK6Pty2O/rtB/TRsaX2E59uNjzc1akgX/2IQ7TP9aWU?= =?utf-8?q?sKP8yZuXrtAdwJfU2DN0ygtUrFC4t/UUU1x5RB0NKUu8/VmZiVdw4LoX/+n7fWmIV?= =?utf-8?q?cTBUnhw13LMiPxE/SVXPU5DQjtUTEAllDWccB+4Vf4rWMPhA02RTRfm/suAvbCTTN?= =?utf-8?q?86XbWrig/tu2mov/xPMFpHQZFtY6oDNuT4+/mwERw6vppIvekaFRsvMfMOgoF6ygE?= =?utf-8?q?qGkf9wlSuGqBzlCjp2/qm/3sQcQgulB/fSamiAM1rGJEkjGc+zQXiZtyBfd476cUd?= =?utf-8?q?jyL1J7TGZ/T/0MEOoext10vftaD3U2Hb411jKEcehXKH3ZAm/TOn5yW1n5LZoNSdV?= =?utf-8?q?e2NHnvyGBDPFNnDfG6gv24fWKA9ssavQEPfZbIjpypoxTP7INboXTqwtnREb4+Kt6?= =?utf-8?q?hd3AL4DNYdVqJoBS7+xli+srIwsXKn1sRtFRKe9ix0mw/EjYmZQblUpYH9oRSB0IG?= =?utf-8?q?7PfGZRqOKpJioGcpLCR3wpBwkh5WXtO7DdFfW6NuvqFQ9RauEsfloNfNQNI+Junqy?= =?utf-8?q?JtY+JyVB49am1HXrUB5jxO1/3875k92GB4KWXALEj/lgurH9JzPCFOOXc0u2+iNfi?= =?utf-8?q?QPH9awz+YFGlrM9Vecl8/xOmcgakpfwVYA9kHS0/4+QWnchkHKqmEXrl7j9FCdB87?= =?utf-8?q?2x81hqLr02NoAPzTHrLb9rEdjJjzbrwa0yrDjUrUzvd7hgJuRNnEPGYRQivZ41WBK?= =?utf-8?q?Ue8H2FLbOBD/vMUvlgBPbC1rmGovJ6nt+tSJBmlc+B5RC7BG1UUwOdsnHPL8EMtzS?= =?utf-8?q?QhyluqZagt63r3nqoy89j+o7ydtibHY8SUIGsrjRXHQKzBfr6NNpnbvQKDtBK1d6m?= =?utf-8?q?881M7/EP+VJmkS+Be6PznVQuJbQnICTn8iy/DsnwvhW1Wnv+oSr3VcGD1T7ddMHaB?= =?utf-8?q?uhcmPs8eUU/ElIHbbty0wutSg4MobUHI83J9dW4N4bP9di2Y9MnqZL3dFANSwZOEq?= =?utf-8?q?Tpy7Oo8Ytf0eJHxqtJsG9cIJYd1CjVuxdwftMEUN4HL/8GW9QvmY7auFfSdnfo2qa?= =?utf-8?q?K2pQiUWJG8ej?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10ae0996-8a30-4c76-68e8-08dd13f2167d X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2024 23:27:43.7667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7s+Ytw8Gk095fG6GnRk6ClkZYOdxVQ+33ubRhmyYQ2nTljY/o+ckVTXl3kVGOVRXD6ok7Npa4sZDDg+dN+0f1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8846 For the i.MX95, configuration of a LUT is necessary to convert Bus Device Function (BDF) to stream IDs, which are utilized by both IOMMU and ITS. This involves examining the msi-map and smmu-map to ensure consistent mapping of PCI BDF to the same stream IDs. Subsequently, LUT-related registers are configured. In the absence of an msi-map, the built-in MSI controller is utilized as a fallback. Register a PCI bus callback function to handle enable_device() and disable_device() operations, setting up the LUT whenever a new PCI device is enabled. Acked-by: Richard Zhu Signed-off-by: Frank Li --- Change from v5 to v6 - change comment rid to RID - some mini change according to mani's feedback Change from v4 to v5 - rework commt message - add comment for mutex - s/reqid/rid/ - keep only one loop when enable lut - add warning when try to add duplicate rid - Replace hardcode 0xffff with IMX95_PE0_LUT_MASK - Fix some error message Change from v3 to v4 - Check target value at of_map_id(). - of_node_put() for target. - add case for msi-map exist, but rid entry is not exist. Change from v2 to v3 - Use the "target" argument of of_map_id() - Check if rid already in lut table when enable device change from v1 to v2 - set callback to pci_host_bridge instead pci->ops. --- drivers/pci/controller/dwc/pci-imx6.c | 183 +++++++++++++++++++++++++++++++++- 1 file changed, 182 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index c8d5c90aa4d45..ac5caa7b05075 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -55,6 +55,22 @@ #define IMX95_PE0_GEN_CTRL_3 0x1058 #define IMX95_PCIE_LTSSM_EN BIT(0) +#define IMX95_PE0_LUT_ACSCTRL 0x1008 +#define IMX95_PEO_LUT_RWA BIT(16) +#define IMX95_PE0_LUT_ENLOC GENMASK(4, 0) + +#define IMX95_PE0_LUT_DATA1 0x100c +#define IMX95_PE0_LUT_VLD BIT(31) +#define IMX95_PE0_LUT_DAC_ID GENMASK(10, 8) +#define IMX95_PE0_LUT_STREAM_ID GENMASK(5, 0) + +#define IMX95_PE0_LUT_DATA2 0x1010 +#define IMX95_PE0_LUT_REQID GENMASK(31, 16) +#define IMX95_PE0_LUT_MASK GENMASK(15, 0) + +#define IMX95_SID_MASK GENMASK(5, 0) +#define IMX95_MAX_LUT 32 + #define to_imx_pcie(x) dev_get_drvdata((x)->dev) enum imx_pcie_variants { @@ -87,6 +103,7 @@ enum imx_pcie_variants { * workaround suspend resume on some devices which are affected by this errata. */ #define IMX_PCIE_FLAG_BROKEN_SUSPEND BIT(9) +#define IMX_PCIE_FLAG_HAS_LUT BIT(10) #define imx_check_flag(pci, val) (pci->drvdata->flags & val) @@ -139,6 +156,9 @@ struct imx_pcie { struct device *pd_pcie_phy; struct phy *phy; const struct imx_pcie_drvdata *drvdata; + + /* Ensure that only one device's LUT is configured at any given time */ + struct mutex lock; }; /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */ @@ -930,6 +950,159 @@ static void imx_pcie_stop_link(struct dw_pcie *pci) imx_pcie_ltssm_disable(dev); } +static int imx_pcie_add_lut(struct imx_pcie *imx_pcie, u16 rid, u8 sid) +{ + struct dw_pcie *pci = imx_pcie->pci; + struct device *dev = pci->dev; + u32 data1, data2; + int free = -1; + int i; + + if (sid >= 64) { + dev_err(dev, "Invalid SID for index %d\n", sid); + return -EINVAL; + } + + guard(mutex)(&imx_pcie->lock); + + /* + * Iterate through all LUT entries to check for duplicate RID and + * identify the first available entry. Configure this available entry + * immediately after verification to avoid rescanning it. + */ + for (i = 0; i < IMX95_MAX_LUT; i++) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, IMX95_PEO_LUT_RWA | i); + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, &data1); + + if (!(data1 & IMX95_PE0_LUT_VLD)) { + if (free < 0) + free = i; + continue; + } + + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, &data2); + + /* Do not add duplicate RID */ + if (rid == FIELD_GET(IMX95_PE0_LUT_REQID, data2)) { + dev_warn(dev, "Existing LUT entry available for RID (%d)", rid); + return 0; + } + } + + if (free < 0) { + dev_err(dev, "LUT entry is not available\n"); + return -ENOSPC; + } + + data1 = FIELD_PREP(IMX95_PE0_LUT_DAC_ID, 0); + data1 |= FIELD_PREP(IMX95_PE0_LUT_STREAM_ID, sid); + data1 |= IMX95_PE0_LUT_VLD; + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, data1); + + data2 = IMX95_PE0_LUT_MASK; /* Match all bits of RID */ + data2 |= FIELD_PREP(IMX95_PE0_LUT_REQID, rid); + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, data2); + + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, free); + + return 0; +} + +static void imx_pcie_remove_lut(struct imx_pcie *imx_pcie, u16 rid) +{ + u32 data2; + int i; + + guard(mutex)(&imx_pcie->lock); + + for (i = 0; i < IMX95_MAX_LUT; i++) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, IMX95_PEO_LUT_RWA | i); + regmap_read(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, &data2); + if (FIELD_GET(IMX95_PE0_LUT_REQID, data2) == rid) { + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, 0); + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, 0); + regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_ACSCTRL, i); + + break; + } + } +} + +static int imx_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_dev *pdev) +{ + struct imx_pcie *imx_pcie = to_imx_pcie(to_dw_pcie_from_pp(bridge->sysdata)); + u32 sid_i, sid_m, rid = pci_dev_id(pdev); + struct device_node *target; + struct device *dev; + int err_i, err_m; + + dev = imx_pcie->pci->dev; + + target = NULL; + err_i = of_map_id(dev->of_node, rid, "iommu-map", "iommu-map-mask", &target, &sid_i); + if (target) + of_node_put(target); + else + err_i = -EINVAL; + + target = NULL; + err_m = of_map_id(dev->of_node, rid, "msi-map", "msi-map-mask", &target, &sid_m); + + /* + * Return failure if msi-map exist and no entry for RID because dwc common + * driver will skip setting up built-in MSI controller if msi-map existed. + * + * err_m target + * 0 NULL Return failure, function not work. + * !0 NULL msi-map not exist, use built-in MSI. + * 0 !NULL Find one entry. + * !0 !NULL Invalidate case. + */ + if (!err_m && !target) + return -EINVAL; + else if (target) + of_node_put(target); /* Find entry for RID in msi-map */ + + /* + * msi-map iommu-map + * Y Y ITS + SMMU, require the same sid + * Y N ITS + * N Y DWC MSI Ctrl + SMMU + * N N DWC MSI Ctrl + */ + if (!err_i && !err_m) + if ((sid_i & IMX95_SID_MASK) != (sid_m & IMX95_SID_MASK)) { + dev_err(dev, "iommu-map and msi-map entries mismatch!\n"); + return -EINVAL; + } + + /* + * Both iommu-map and msi-map not exist, use dwc built-in MSI + * controller, do nothing here. + */ + if (err_i && err_m) + return 0; + + if (!err_i) + return imx_pcie_add_lut(imx_pcie, rid, sid_i); + else if (!err_m) + /* + * Hardware auto add 2 bits controller id ahead of stream ID, + * so mask this 2bits to get stream ID. + */ + return imx_pcie_add_lut(imx_pcie, rid, sid_m & IMX95_SID_MASK); + + return 0; +} + +static void imx_pcie_disable_device(struct pci_host_bridge *bridge, struct pci_dev *pdev) +{ + struct imx_pcie *imx_pcie; + + imx_pcie = to_imx_pcie(to_dw_pcie_from_pp(bridge->sysdata)); + imx_pcie_remove_lut(imx_pcie, pci_dev_id(pdev)); +} + static int imx_pcie_host_init(struct dw_pcie_rp *pp) { struct dw_pcie *pci = to_dw_pcie_from_pp(pp); @@ -946,6 +1119,11 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) } } + if (pp->bridge && imx_check_flag(imx_pcie, IMX_PCIE_FLAG_HAS_LUT)) { + pp->bridge->enable_device = imx_pcie_enable_device; + pp->bridge->disable_device = imx_pcie_disable_device; + } + imx_pcie_assert_core_reset(imx_pcie); if (imx_pcie->drvdata->init_phy) @@ -1330,6 +1508,8 @@ static int imx_pcie_probe(struct platform_device *pdev) imx_pcie->pci = pci; imx_pcie->drvdata = of_device_get_match_data(dev); + mutex_init(&imx_pcie->lock); + /* Find the PHY if one is defined, only imx7d uses it */ np = of_parse_phandle(node, "fsl,imx7d-pcie-phy", 0); if (np) { @@ -1627,7 +1807,8 @@ static const struct imx_pcie_drvdata drvdata[] = { }, [IMX95] = { .variant = IMX95, - .flags = IMX_PCIE_FLAG_HAS_SERDES, + .flags = IMX_PCIE_FLAG_HAS_SERDES | + IMX_PCIE_FLAG_HAS_LUT, .clk_names = imx8mq_clks, .clks_cnt = ARRAY_SIZE(imx8mq_clks), .ltssm_off = IMX95_PE0_GEN_CTRL_3,