From patchwork Thu Dec 5 16:51:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13895789 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9515E22577E for ; Thu, 5 Dec 2024 16:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417493; cv=fail; b=ReUdq3XAy2FVGqLw6k0+Vz4kpjmEIGUmlXmDGiabn+8JMr+l86B5e19sVM96cM1ZFaKPpQB2uZ11SkDjCGtB0UeBqWTWAt+2APZAIIHGZRfdB22rweWGlWnRRpx8vD75yZ+7/XSZZa7r8kJSQHWgAFWDCk2rZOF0YGBp9ctAifU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733417493; c=relaxed/simple; bh=E/9uxdBtjF0j6zPxcwv3XbWI+yAR6dXtQGZlNmZDiU4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WdMYcFQSRp3l9gqj+N/psqd3KWVy2lAF6RPZ+ne/3rXexE4r1OVzPsu+Zq1AMJNdA2gxjnIdImKcRl/tLuueCPPQSfH1+tnXINzOCI2v/AAvZwh6JXjPJnFuXoRliMEkD/OnGf3kb7V5LAr04uWxRrrNJqnR4I7mhZmjWO6C+pM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=VrGtP9+c; arc=fail smtp.client-ip=40.107.22.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="VrGtP9+c" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gHY4mPNFdNC5sn6KzXlE1xbbSEmRH3G2kG5KDcRffWR3BVSo0ASvswLui26WJLF9bUKxsLDwneI6Ko7OUr2ipdew1LmMHORNTz55jyPq0HLbdElA3YniZB3YL5czvPqb8v4/ih7tP+DUQAl6ZAwugNsgCtw0E83XqKXCxY1dbrc8lilGOB0/5eV65c2o13JFDsN6S/K4c1bF+AzoTahMyPX8XofetC6rVK7D/ILSJ2kimdbyl1rWg0drbgwDRV2/VFpA3HlQlgrc2Kxux6SDJK+MLOVN5Rx5htHEqpzXW8EoYWfYjV5Dfj0Htwg/FHMJAZwheOCSTuktNI9uI+HnMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6sLpS2YJwvojP2Rq1CdHzqmGzIPERE+0rD2KZt8p0Vc=; b=kLnVYrn62Hru0da+xUZNSqPGjuOdm6XGW8xIAo8OwBe9DVhuQovn6pCHFQdyNKMAR+vxoa3iZXTebEdA6bDGfy/BVuVn+n7/TtKk0gvSXLb46DjkQuWuwu4JQtqJ2rnszFz87WFbH/E+RkflgCnRO3NdVG+DrchFIkxahuBv9/Hx/BkeyrmmyvZed897snKZUDgTFzT6vRV0cQvS9sjlRoG8m5btB/VhYCp7jzOZJoHyUoFdXiQLaaAJLo8aNmOQY5GLltp/JBqXs7sbg1ib/o3H5oHQV9oIG4c7iX7z//gFvKKaapeP7jO5rIRjEzgetNOkZJDAW1mvpEJfz+n9/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6sLpS2YJwvojP2Rq1CdHzqmGzIPERE+0rD2KZt8p0Vc=; b=VrGtP9+cM00tHMrwtb7t7ZbO6BhBsbTiBZl/LRMna2SnSo87T4Cg/+jXGJ1BCVxiRFsBTKee5bTgnaYiC6pdSfcoDmxCt2FictsZggzA0qxVL947XmQHAphLLV5/i+Zv3Z40L3Mj6bOJzQQZ6Z8sPadnV4j7uepAqmokAC/hU4tXvmUgeNQdXXLhMHE3UziooQb0vCs6EjTwAdzMUII/fSVt8vht1wav3wRanL2zFKAkqt8HScd2QbdwMHveN9EACalqAh4GjQaezoi8TPJhkLMS1GdqM3G0JOwS9lVW8LELRn/XO/81vXHrFCKvwcMcVz6ZRST2zkmqM3D1f8GbNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by AS8PR04MB7511.eurprd04.prod.outlook.com (2603:10a6:20b:23f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.13; Thu, 5 Dec 2024 16:51:29 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8230.010; Thu, 5 Dec 2024 16:51:29 +0000 From: Frank Li Date: Thu, 05 Dec 2024 11:51:09 -0500 Subject: [PATCH 1/5] regulator: pca9450: add enable_value for all bucks Message-Id: <20241205-pca9450-v1-1-aab448b74e78@nxp.com> References: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> In-Reply-To: <20241205-pca9450-v1-0-aab448b74e78@nxp.com> To: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robin Gong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, joy.zou@nxp.com, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1733417480; l=4660; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=w0wr4uNLDwl95zI6sHN+f9rDrooK+8cDnt8wPRzm9bc=; b=qdUn7TI9xxJdccSA3p+UtGamFXi39sMiW/XoATXHbl09sXZPD7lSCGomd95FiS9uqApO5qX6F dNTTCMcAn0vDRkFHwsv2/ZvXeyxPos2Ea0jhk32Z8Hq+Qiw+qHjBVAy X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR02CA0029.namprd02.prod.outlook.com (2603:10b6:a02:ee::42) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|AS8PR04MB7511:EE_ X-MS-Office365-Filtering-Correlation-Id: 887a29e3-8a75-4820-1a9e-08dd154d109a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?jf4SeNIOh3CV58GHRsqkFYUpZ6xwTep?= =?utf-8?q?6oqPJhvb/oCTHfBe+M4zqca+aFKXxDUXsl0nAmdiF0z22/HM52UulomGZ/HvBFORv?= =?utf-8?q?zob7jsVrjHvSdWNWHlqNEHon24nNs9sHMZrhzWpXvBaRrm29XlW4kO1cDZKDfotrv?= =?utf-8?q?gf4ENsen/n2dYQLbWp1VBPpAbwMsfKA8ntVSXV4JfrPFBwWeGMk23xtCREbWEZBpQ?= =?utf-8?q?hgj7YxuZ6enQhg/6ljdeAiH+IEdlAppX9gI9hnaQeib8swYdQH2qd4J9pTvutULDq?= =?utf-8?q?QHhiaJG97GQKoXnoOsC27l4BEsHfnQk7NDp2SS1srg1lCpvVB10ruiZCJyPkMuksM?= =?utf-8?q?QvCcG1GJl5VQ9EiMd4RUzQBXMEpUez5URzO+zvQDvA2eiIBPj0+MnEP50vgiPx0/2?= =?utf-8?q?Qt0rCI04vb6hhYPmzwYedLg+zOuDPfPlNmvZ33m1STLuOWHF7d5ZXf+wKrmWRxnho?= =?utf-8?q?E4IwWI3Ub0EvoWI9UkTsJlqtxppP4K9NC1aPSlp//KkxCQsjXDbptG0nxEXjGJ03N?= =?utf-8?q?ndn3gD942bqwvZPRfhTnRhCkZ+pg7W2yTjXV/nfR3y3vq+VYv3wiCJGNKnFdT1Rdk?= =?utf-8?q?zDPZj8jPM7qZEije4Ss0nMCOmht9BJRRSAHijSmsKwnCfwiNU8rc1c92FX1DDjPU7?= =?utf-8?q?c49s0p8cO2lJg35v+vHqcm2tcbevf4rZlTikqtJpx6BuYJbPS3dqTomzSxEvZM2nN?= =?utf-8?q?wQrQrfhWwPtPiSopWB9avN22QHbpJd3qXu09qEZHbeMHd2q4/wxyDMyGINT417kDc?= =?utf-8?q?NtuIxnI1VZzyCxPwRhey4ZCxh8ebn0/e3LEwESiM+HEywfZk73fnNNimMkgVninwk?= =?utf-8?q?PlF8Q2yClE5+FfqZ7aKdIGO/E5SjsQCTwjST40dtjMmDHJUSkgQ8uGOh3FwV7wRi9?= =?utf-8?q?+tJ2X6hi+l+hbEshn9j1tABZRu2f7hkMgQILwX9zPpqnytTi6RSebyIeLdEpiXYki?= =?utf-8?q?yh5NRRd9viCewuvvIUqodGlJ5+vj9VwcP2ep2FT7BXYkVjN6vIMyu5z/EBm9oCKxx?= =?utf-8?q?o1UQqYDITulceiz5HEEYFh6GUurJgPRLnOwWJvmalDsNrIKF3RqIJP9ixBxQ7JxD5?= =?utf-8?q?lRPZHk4jt1C1SsLNn235dv4eF59PB3UbHZ+TlLbtbq4x41uA8oBJHHBVM9AhdXYAh?= =?utf-8?q?O5DPU2iJqvAsTb2UIpo4L76HjP8SeCsnsE91bHZNn2gklAIDqHV2MSHWK+pD5GLjq?= =?utf-8?q?FJ7WRjN9LXzfNJTuI8xWCTCh+KXG6NsURIi3sWA2ccRPPM7TH7nL+v0GsuLvQa1S6?= =?utf-8?q?E8P1szu1SNDT2blbWcsPXduNws6PifnYZ1s7sdQAwAoMgQxpIZGiEhBf+XbnZiEaf?= =?utf-8?q?VAQtXosgfdSIP1oUWq6at6m1Ov8lmoJZ2a3Wzkb/3V5W7sRDwrVOap8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?VXSvimFMBS990Ol2MxJqzDF7ZOjZ?= =?utf-8?q?ZAza2JWOr23NPYIkwqaa7jeO8r9fd4SthlQQ6snXgHXn+KQY/DPpD6CyRJovliqDH?= =?utf-8?q?5Sr8U99lk23x+JNwT5SJMNaaLQPNj6/9rD//4y0lNgvGlLeQf1zxuHiFfWnSDVgdQ?= =?utf-8?q?oN09mr/5hx7YRf99bQoeKmuxsFeJzwqXZjJRMQ0NuqE6iGAQqGLICsaA8hgDT2idZ?= =?utf-8?q?fJNQ6ibU4aAQR1Vn1fvkaYtvo0EnsTJZ/c45Uq8MQZNu2kBRVzNUhDVb8P71/OiiP?= =?utf-8?q?WU182bSIvvlcWF5zzSEAGsUusaFCmOWUQkn9ifaTlrMZscgWu75SadUZJcfUpFXHP?= =?utf-8?q?lQHm+kiB0DBFi0rcBIWjt7jE+cS1j9LeyrqFZYJIqaRQxx5yp+RiIz3vcwhv3Hp4j?= =?utf-8?q?DplBMomy7aE0QkI/QtejZEts6LvqcFTj0NSqz/0+o9qkY+pZshSLDvqG2kALg6hzZ?= =?utf-8?q?F/HplQXdSrbhSgiB2WnqxYmdNzyQVjENxTD4pvMRMd/XqXosmcg7cnYaSviUevjbI?= =?utf-8?q?A3rUSY0j1ihh+jaZhcsCvWPqdYsJp0PH1Cz1KppFeiUDWzvhwCkVwqw4Gg821GNbD?= =?utf-8?q?i/RZTpymdwlLpkOm7Yr+pJVsfqXVaOx84pjrtKFwwPUyAlnNBcNDopfpBEeFO6r9d?= =?utf-8?q?xPonVEknOImmZ65J45PAliXlCqH1sd708sVyzZ17ps4uivCgaBOYKjI/XS7atxJrt?= =?utf-8?q?QJlrq+RYq/B6O45EciDYtl9KI7aulIt4mVBjVchGjYlo+/LQdgLmu5mKaZ8Op6jAU?= =?utf-8?q?A9NRYcUqkMz5FKIrAg7WDxiowO7oCgIBZm2wFxYPosBTitE/9WdzaatOjLPFjUZPr?= =?utf-8?q?5vMdKh3NjvArL4PZOplFdOBLDnzTb434ZgEhIScrUPeUKYg5DEjeLHkiDuEvJ1lIm?= =?utf-8?q?Q64N2R62vtilOkbXaCg6AG1y9AzsuJtjL+tg1VcWWMd+5+cebB+akjOTasbi81KPh?= =?utf-8?q?q8ZnhFJBPKhSSWF2S43WmVPhHcCaF+wg7RKvrmdHD2qNXnGKnXbZ+kv0qqN+9A/fF?= =?utf-8?q?edLUyvnwsiXiad8nYIgbW5BLd/ldooyaQm0dS0w1Db9GSNoYfbMEVYAbWqjfOomig?= =?utf-8?q?OwhL27dNnGI6LLUI3aULLYNmr+OJtX9WlQy52CJsgiJNfndFnX3ocDjzfnTjPr/4O?= =?utf-8?q?M1oCxJC6VAKeyGgnoWS9SHJ011LQQyiLiW1oLmpzYC89uVJUcNb0GDCOwFuvndAe8?= =?utf-8?q?yO2b0R3/rOOIdHTHzF9goVItfluaqyh2U7h00Rudpn387ZhvRYNZBXMKCRGwdNcik?= =?utf-8?q?ISKUUUBYjaaCiOkPx95PU4v8HIeogtaWuZmmNkHiw2EYaF47cKVKRaW22BVVua6RY?= =?utf-8?q?Ej++HSpPE4vL2lXFgP1uzOBBkw9Ddw3+xQ0L/qx1J9tYt5JNKCK03njeUmlWylVuk?= =?utf-8?q?sIFWh1cFuZPOU59riLUpYIG4/B/vkrDrY2Fm09dIIE8VHAFIZFXYELibtmljYqDQS?= =?utf-8?q?nCdCACRTN3kWG6lLcwc0cfUlfPPKtr+jrUVppYW9NsK/RHbRGqrcyGFVACG6UmKTU?= =?utf-8?q?r8GTnlz+3xG7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 887a29e3-8a75-4820-1a9e-08dd154d109a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2024 16:51:29.5233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VCvNJOHlRwi42a9aDNULj+riWjtAEOi80JCv/qmggsbasVsDtWYSdusXYwKh9CinSGgX3CO8bv1HvMs6s4+R9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7511 From: Robin Gong Set 'enable_value' in the regulator descriptor for different bucks to manage their enable modes: - 00b: OFF - 01b: ON when PMIC_ON_REQ = H - 10b: ON when PMIC_ON_REQ = H && PMIC_STBY_REQ = L - 11b: Always ON Ensure appropriate behavior based on the intended design. For example: - Buck2, designed for vddarm, should be set to '10b' (ON when PMIC_STBY_REQ = L) since it can be off when `PMIC_STBY_REQ = H` after the kernel enters suspend. - Other bucks remain '01b' (ON when PMIC_ON_REQ = H), matching the default setting. This avoids the need to re-enable them during kernel boot as they are already enabled after PMIC initialization. Signed-off-by: Robin Gong Signed-off-by: Frank Li --- drivers/regulator/pca9450-regulator.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index 9714afe347dcc..caeeed433165c 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -247,6 +247,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .ramp_mask = BUCK1_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, .n_ramp_values = ARRAY_SIZE(pca9450_dvs_buck_ramp_table), + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, .of_parse_cb = pca9450_set_dvs_levels, }, @@ -272,6 +273,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK2OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK2CTRL, .enable_mask = BUCK2_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, .ramp_reg = PCA9450_REG_BUCK2CTRL, .ramp_mask = BUCK2_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -301,6 +303,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK3OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK3CTRL, .enable_mask = BUCK3_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .ramp_reg = PCA9450_REG_BUCK3CTRL, .ramp_mask = BUCK3_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -330,6 +333,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK4OUT_MASK, .enable_reg = PCA9450_REG_BUCK4CTRL, .enable_mask = BUCK4_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -348,6 +352,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK5OUT_MASK, .enable_reg = PCA9450_REG_BUCK5CTRL, .enable_mask = BUCK5_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -366,6 +371,7 @@ static const struct pca9450_regulator_desc pca9450a_regulators[] = { .vsel_mask = BUCK6OUT_MASK, .enable_reg = PCA9450_REG_BUCK6CTRL, .enable_mask = BUCK6_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -481,6 +487,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK1OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK1CTRL, .enable_mask = BUCK1_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .ramp_reg = PCA9450_REG_BUCK1CTRL, .ramp_mask = BUCK1_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -510,6 +517,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK2OUT_DVS0_MASK, .enable_reg = PCA9450_REG_BUCK2CTRL, .enable_mask = BUCK2_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ_STBYREQ, .ramp_reg = PCA9450_REG_BUCK2CTRL, .ramp_mask = BUCK2_RAMP_MASK, .ramp_delay_table = pca9450_dvs_buck_ramp_table, @@ -539,6 +547,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK4OUT_MASK, .enable_reg = PCA9450_REG_BUCK4CTRL, .enable_mask = BUCK4_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -557,6 +566,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK5OUT_MASK, .enable_reg = PCA9450_REG_BUCK5CTRL, .enable_mask = BUCK5_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, }, @@ -575,6 +585,7 @@ static const struct pca9450_regulator_desc pca9450bc_regulators[] = { .vsel_mask = BUCK6OUT_MASK, .enable_reg = PCA9450_REG_BUCK6CTRL, .enable_mask = BUCK6_ENMODE_MASK, + .enable_val = BUCK_ENMODE_ONREQ, .owner = THIS_MODULE, }, },