diff mbox series

[v2,1/2] regulator: dt-bindings: pca9450: Add nxp,pf9453 compatible string

Message ID 20241212-pf9453-v2-1-f59d2c096356@nxp.com (mailing list archive)
State Superseded
Headers show
Series regulator: add new PMIC PF9453 support | expand

Commit Message

Frank Li Dec. 12, 2024, 10:26 p.m. UTC
Add the compatible string "nxp,pf9453" for the PF9453 regulator. The PF9453
is similar to the PCA9460 but supports only LDO1, LDO2, LDO_SVNS, and
BUCK[1-4].

Restrict LDO and BUCK numbers for nxp,pf9453 and keep the same restriction
for other compatible strings.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/regulator/nxp,pca9450-regulator.yaml  | 24 +++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Dec. 13, 2024, 9:30 a.m. UTC | #1
On Thu, Dec 12, 2024 at 05:26:24PM -0500, Frank Li wrote:
> Add the compatible string "nxp,pf9453" for the PF9453 regulator. The PF9453
> is similar to the PCA9460 but supports only LDO1, LDO2, LDO_SVNS, and
> BUCK[1-4].
> 
> Restrict LDO and BUCK numbers for nxp,pf9453 and keep the same restriction
> for other compatible strings.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../bindings/regulator/nxp,pca9450-regulator.yaml  | 24 +++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index f8057bba747a5..3589817858c5a 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -17,6 +17,9 @@ description: |
>    Datasheet is available at
>    https://www.nxp.com/docs/en/data-sheet/PCA9450DS.pdf
>  
> +  Support PF9453, Datasheet is available at
> +  https://www.nxp.com/docs/en/data-sheet/PF9453_SDS.pdf
> +
>  # The valid names for PCA9450 regulator nodes are:
>  # BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6,
>  # LDO1, LDO2, LDO3, LDO4, LDO5
> @@ -29,6 +32,7 @@ properties:
>        - nxp,pca9450b
>        - nxp,pca9450c
>        - nxp,pca9451a
> +      - nxp,pf9453
>  
>    reg:
>      maxItems: 1
> @@ -42,7 +46,7 @@ properties:
>        list of regulators provided by this controller
>  
>      patternProperties:
> -      "^LDO[1-5]$":
> +      "^LDO([1-5]|_SNVS)$":

LDO-SNVS
Underscores are discouraged in node names,

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
index f8057bba747a5..3589817858c5a 100644
--- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
@@ -17,6 +17,9 @@  description: |
   Datasheet is available at
   https://www.nxp.com/docs/en/data-sheet/PCA9450DS.pdf
 
+  Support PF9453, Datasheet is available at
+  https://www.nxp.com/docs/en/data-sheet/PF9453_SDS.pdf
+
 # The valid names for PCA9450 regulator nodes are:
 # BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6,
 # LDO1, LDO2, LDO3, LDO4, LDO5
@@ -29,6 +32,7 @@  properties:
       - nxp,pca9450b
       - nxp,pca9450c
       - nxp,pca9451a
+      - nxp,pf9453
 
   reg:
     maxItems: 1
@@ -42,7 +46,7 @@  properties:
       list of regulators provided by this controller
 
     patternProperties:
-      "^LDO[1-5]$":
+      "^LDO([1-5]|_SNVS)$":
         type: object
         $ref: regulator.yaml#
         description:
@@ -100,6 +104,24 @@  required:
 
 additionalProperties: false
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: nxp,pf9453
+    then:
+      properties:
+        regulators:
+          patternProperties:
+            "^LDO[3-5]$": false
+            "^BUCK[5-6]$": false
+    else:
+      properties:
+        regulators:
+          properties:
+            LDO_SNVS: false
+
 examples:
   - |
     #include <dt-bindings/interrupt-controller/irq.h>