From patchwork Wed Dec 25 08:20:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13920650 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2059.outbound.protection.outlook.com [40.107.247.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6134315359A for ; Wed, 25 Dec 2024 08:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114889; cv=fail; b=tojm8DOpr9gjH19RhOfP9c1tdRCZ+pIzL14UShxcXyKP4o8nHhuTh+SntozzO4CTbx9omDn5MFYu+8K14225TOOZNqQCFJhf60ZJZ/S7pl+Jnt/zJYgj7x9PZNlW2vO30Hc/Ob2Qx09+Qo+7UqNfeZGaafIDKKF/wabu9GkodYw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735114889; c=relaxed/simple; bh=ztTNvBjyM2GdOIbjICjOms+n4ACWCVHnpgjWYX6R7oE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g07uUHbbJ8vVVD3Q8kMLwkkyHjDe5K5WLfkvbzQkqH9wyuE7pEnvbxK8S5nU3tkbKXkWQpHG+CN1C21aVxryM5gUxZIcY31+7+WbAS22Ap495d65+4FMvTn9dyDrAxYK9hzLO3M+ZQYKyfFjkyk3M6xlc0AnMV4rLCvxkxKjpzI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=paW91xgq; arc=fail smtp.client-ip=40.107.247.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="paW91xgq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iIxdhKI16bl6Z2tOV4qm5+0cScsl92MmGalAK3FQVwbPOSsuORWh3HkU/omHRHKnAQgmjafj/UxQ3bYrdpxk9uYkufpbPwBvjykStyIab8WIn1KWs0O5LD3xuxenpQSZaI65jaVEkxcyW1/MFDNkJZAx0rcjPm7fbfWV1R3ZMvG/E3Tix3m6ZN28/k0Ng3CPHUm1SCq5Q/8JB/bCvUCCE8QELxptVJ0TpCooNyFy9gBnimdnMZ0lBYW4bKUcoO/D+EKeiyGbV62b/1N0uDEuflx8VG6wxFFhduxYbODw6KNvEkz8SbYqS54NNbg8a5a6/ZvBwUWboj+UboM6hycZEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lgjoIelcFWeO/3uQ6g9StYO1DWE3pRbCcbM6dX6/yk=; b=ZfHgNUdi1HpxKKdU2HdiPdqBUNx/H7MUhJh7onlPodPH6XI53KwRPcFOjexIeuuOFtU1DDHicAmoYjiKWFJ74FIEKJ/rfqD3oVESkcZb9CNWoD1bpG39vewuJk/xFnCXeenxN54ZcIuu8jVS0bzi+iOtVlDm4IKwIuVElWcR2/TsqcIz4UfN7IYtUhFgkwF5lN2aGHUFUW98eAiYdCRJ0dhHdKLQzn6SfnRA2bVVwZj7ZDextHvfK63kmHZ4MwbphmAAXkeAR7Gi2t/CCe+EQzew2IbHi1jE7hsOeuWB5CS8LF/5Ct1yJZ+AaonIljSYdpiCpZk2K5aUkBHjzKUnOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4lgjoIelcFWeO/3uQ6g9StYO1DWE3pRbCcbM6dX6/yk=; b=paW91xgqGDS8lG10ly9LC/5NiE66KymtM71Gfj2U3pv1RgsSXdXGoFZ/ixk6pKn3kioppPQy6uI6SinMWjTmR1T57GvLBvsXzseNJUvHr/ab2T0QyMSg0kbNhb60eWk+HQm1z71K+xOq5x1RvnWatVU1wpUx0aniJmJO9OqUzB+1VgvIxBQNGol3rFh1NFQ6WuTrOy26cU8kt5DGjb/8o3ZFfEFteWl78DTwrtAeH97mm1KGLiiiGL9UWgKyDIw+YxJhz3QMdnV6PNxLbfyQbmTrHGvxubzx1302uEsDH5g30UD+sHT4m90/bEiEKI8I8DRPnOcVUkgWwxAhmXcMcw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by DB8PR04MB6985.eurprd04.prod.outlook.com (2603:10a6:10:11e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.14; Wed, 25 Dec 2024 08:21:23 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::b1b9:faa9:901b:c197%4]) with mapi id 15.20.8293.000; Wed, 25 Dec 2024 08:21:23 +0000 From: "Peng Fan (OSS)" Date: Wed, 25 Dec 2024 16:20:44 +0800 Subject: [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq Message-Id: <20241225-scmi-fwdevlink-v1-1-e9a3a5341362@nxp.com> References: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> In-Reply-To: <20241225-scmi-fwdevlink-v1-0-e9a3a5341362@nxp.com> To: Sudeep Holla , Cristian Marussi , Greg Kroah-Hartman , Saravana Kannan , Linus Walleij , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735114854; l=2342; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=JW09hdqF5JaCHbplXrnEbMAc0+E3O5ENXdWtWvzXaNI=; b=Ggq8/JPv3bg3R3clWpvIw5WzQ65da95nsyi11ZHMwhlRLA0qYBXUdZZzfUjJ6GK+fvYgFkqUd 8anqAeKysNHCp+9BCMrs/5YJMCQCC4vkgxsG7X/T+AwuiEwC6vX4Ucy X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::20) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|DB8PR04MB6985:EE_ X-MS-Office365-Filtering-Correlation-Id: 53ae3737-8719-4a34-56e8-08dd24bd1e3a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|1800799024|366016|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?HUFQzH0FjjT0CTkopUXgZjqH11lJqia?= =?utf-8?q?/bOW8Suj95m8VaN6BoftgoSscdiS5IXPr9HdD1AAAzQAl18N9JwJj2dhUFu5D8UOK?= =?utf-8?q?L7MJs3S0L//FGgglSCKRG0cG56DmWyQnU8YE5ZSfpm+w0RIIHCPD4DcYFcgHHjjbC?= =?utf-8?q?VXrx30uRg5hM41OyP7bEXlffqwsEaarxwQ3MAYQifFlxbcr+y16U379O57JL2ZJfV?= =?utf-8?q?WZ8RhMSip3iFX3g0TV/XugE2KqXzc26OOqu8OStNT/J7I0rSEV7VwPEXfwhLq0ohk?= =?utf-8?q?7yoGU2v7mp/23rQUSvbzNSrWUomcHAS8ZERD6rzN9pC6PpkHdGlpMgcFXsW0UWvDH?= =?utf-8?q?TbzNZnVfi1U71iHNh5IIsaookizvdTjlOUUN1m2likKGKON8wi6WDkY6eH53hqg/G?= =?utf-8?q?vTm9XxINCgE9TzhiPQ6WBBnSkvhz8oejktRsgKs32O5xDAq1vkXkOg+Z9q/bq9Iop?= =?utf-8?q?LO70/B+A/Iy9+zlH78Io0Cuv8qG2Ce0OoJ0rdkILDLCx09EbMz0jAni6ccMLL1gdA?= =?utf-8?q?OgQsfpDSALQSWvrbbnkLz2N5MD79KWJa8Xw1Sjt3sKCzYo9PsoA8vhvlD6MTez2G6?= =?utf-8?q?c4QxLcGfNPr06/icZLe9YUXGltAdTD7lOCYSgRe05IWTeSShjdfRXs5+Kc9+GM0F/?= =?utf-8?q?JBOTHTZVc7VxmS2PKdf72khoMysLxadOiCMExuKeH2aADnrYkRG5ImQ4SqlzQpkDG?= =?utf-8?q?CyXL8/fdWnEc6V5JYwSrlU1pWwtn6Rx8i5B1UJ0+1IaPRzsmuF8C1BXz5RMStCVlV?= =?utf-8?q?Wg5QPvdfKko+3gWQCKzOUy0gDT8o+SJd4PcUU20zeoJXNF10hQD38EdzQfMUVg3D2?= =?utf-8?q?HH4vbUZ/Cuf2EHW2y9DKloAZFZSpNpi9fdbcYvL4DDTVTsn2XGXzDWQ10KFjrddnE?= =?utf-8?q?isk4mrUYQrC1ZgCsa/CUTQHtQXNuJEo+hqhImodX5kqCISkNUVEjHfFvvF9MeCiUi?= =?utf-8?q?AiGaKLgiTGhnWG6G6NK98zWB8lf+qwo0Y39eO4iwM3kGZrncqoaYOqcAzQsGO+3Ns?= =?utf-8?q?9vJ+a+VkLLK2LW7zh3XscWaYKcBHqe5lkkK5bO0I7LlW+cmiCoUZZ8tp30F+sjKfm?= =?utf-8?q?P0TVOHFo/ppVpmOBloCl4eQkTLo8dCNh4yojQ5bILGRwLDf2lVtNkTICE+8shrodD?= =?utf-8?q?ofMyWBGyvSFCRv+DSeLgn4ckE3tP4/46YSN6Cu97R5kjWKzBGej5QIgsgJMkvJLfy?= =?utf-8?q?Y51uunRmIoK0ot5ubwrnaz0hE8Q418rveDXVwDlI9EF6DVbM5TiG3roj/SsdT5LB/?= =?utf-8?q?YvQpQ4fB0bs6mDCvi8xQ34XWrc1mgb3tytegPUxPlprieCui9R07E7NWNDL/TVriB?= =?utf-8?q?EtzHhSPsv1nhAjzClvsfBc5yHjeLO0s0put7sWu+etge8pAz/OkxVfW+Y0E97leG+?= =?utf-8?q?71Rb8d0gjyojFHE22eAS9Q58OjjldKdmQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(1800799024)(366016)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?OAAdF0f7MyyxloxpWzVYZ7nPJH5Z?= =?utf-8?q?3C2ph/DVplC1EGpi719qj1I3OfORHVKldKGluQ1wWqOGAGaPwBl6+YiKO+7iDUDIG?= =?utf-8?q?CqgdHbwIgUTUFEfapdc0AC0tE4RdJDFDzN2eikH4ah1lWbbl3BuFexJsweToC+4fF?= =?utf-8?q?LAEv9iKQRuPslSVHm85WeRLqkvLXYOhWiyVOEidGE6qZzKwahklAqHwLHU3dmk6DM?= =?utf-8?q?WvbgOl6TtV7kVGzTaGlI/3ZKRiOzFf9iPjXTCuIMRb+yM03PABqaXl+ypNHcyzLUb?= =?utf-8?q?pRYRBdgf3XsdoEsoEgL5/6xuxG7cCa9w+8w2AgaAZaRcfIFNmVFIYxl/n7/aMr8WO?= =?utf-8?q?qO02S03T0LhSjN4qCxyUz0N40F8GIfwtL+51eRli0jhRuVl+peG4zZU8HOqV1AHF6?= =?utf-8?q?Jp422AyytJQCSEEG0wKSoCaN83issm1yXm/Zhj7Ff9zpAccklPoNrDw01b2ScdI/O?= =?utf-8?q?ja+1/5YwutuzsjwRjZnG2IRuE0rLBPvRACptOKU2LfZLRJxRJtM5CjZhbT5IY02Ya?= =?utf-8?q?FlcN9H+6DfChJwsZXE/ylo9AcAUgMiOAtkQ/Q/BKi3xTRoZLbxLjwQQmemyKY5dL6?= =?utf-8?q?+hqhooqY5nzB49NdgIY7lsgBvQ+0DbYZrZShixfjyZLLXPYzGpZ7hiubLc+Bx8cBu?= =?utf-8?q?geIHvPYnogWTxGZCmbLfCj6enHE9dTRhV4+eHih0ImcQybThzD9M/2JeoD1COFl0x?= =?utf-8?q?+BZmu52MtZP+WzJUz0eclzSz71xprIm7XMoODA9TKu9EeHKfUSsL8PFr39+EoI5+m?= =?utf-8?q?omjzUdLXOoSG5klM2Z2/NngGHtTkNvCOSGDeF9hHVdFyJ/wFH0K9iQe8Zs0H4e0vS?= =?utf-8?q?9fNMBAieW34tfcksqnmrNN71YgUnvNSC9TKpwVp3DUSi9wCLkrtlQ9rxTAh6vmf93?= =?utf-8?q?+EucILMI+7pFaw/ELNl8/LcMpZlO4yI4WdenuX6QY86hq8hfsyX9PKTDIvgA0Vlsf?= =?utf-8?q?A+XkfJ8Sms4cKi7DFSVzUpiTdU9GVNy1g7QLZXhD9Xw2fuLea9IFR7NYP+QjBSDLI?= =?utf-8?q?DLQZIXjxyyoWvUFzmSzvN1/QaKg277ReFFS5UpizBXRF1enrE+Q+bIgMe5dPHJE/7?= =?utf-8?q?OY53dGbzZQ18PU8OfKQ+xlBV630EIR2+G3di8I7Zxcw72zn2+xUlaHC/cjAV3WpEQ?= =?utf-8?q?jpgRmoxFHc4ZO1PnsCsIPHbt98snRUZuBiEuFNh1gNXYjM2DzmQV3VPzF++gm8dNu?= =?utf-8?q?q6OTaXdRBNZH5Py0ZxvpWdz/GRZOaxEPXBUj4nlp1wYumMK5SgqCohsoZvk+UTebh?= =?utf-8?q?EJ9rouiZiPjqZmsSnUkuwsNwIUEXS9U50lxHT9PbVJaJSLrn21fnb0CVCLlIgQMnc?= =?utf-8?q?iOV1Rq5SiV4qjjg+ni1UG9QAdyIdQrtfWZREOcZqPOZlFYlyh87sd74aeadNmlzRX?= =?utf-8?q?pO6cGzSJ0DryBvlfA9Sl3aQlKaAwshE6xI6D0fjFHSs9zofirarkYBUdmpYbt7uYe?= =?utf-8?q?G9djjBjp0ewJfsX6FfumDb1SQiKjE+VX1FzAKbDjkhT+GyqMwWnFQCjiIUgMbKVJ1?= =?utf-8?q?ahs8RChcHIDB?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53ae3737-8719-4a34-56e8-08dd24bd1e3a X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2024 08:21:23.2427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l1zklGKYHV8MJmod+zBN26ObWYUTK87puK3Ks0YOvXTY3yr+9FgFAUV+Ksat1Q4GM38SKjAm7q9zJxgppxKcJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6985 From: Peng Fan Two drivers scmi_cpufreq.c and scmi_perf_domain.c both use SCMI_PROTCOL_PERF protocol, but with different name, so two scmi devices will be created. But the fwnode->dev could only point to one device. If scmi cpufreq device created earlier, the fwnode->dev will point to the scmi cpufreq device. Then the fw_devlink will link performance domain user device(consumer) to the scmi cpufreq device(supplier). But actually the performance domain user device, such as GPU, should use the scmi perf device as supplier. Also if 'cpufreq.off=1' in bootargs, the GPU driver will defer probe always, because of the scmi cpufreq device not ready. Because for cpufreq, no need use fw_devlink. So bypass setting fwnode for scmi cpufreq device. Fixes: 96da4a99ce50 ("firmware: arm_scmi: Set fwnode for the scmi_device") Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/bus.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index 157172a5f2b577ce4f04425f967f548230c1ebed..12190d4dabb65484543044b4424fbe3b67245466 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -345,6 +345,19 @@ static void __scmi_device_destroy(struct scmi_device *scmi_dev) device_unregister(&scmi_dev->dev); } +static int +__scmi_device_set_node(struct scmi_device *scmi_dev, struct device_node *np, + int protocol, const char *name) +{ + /* cpufreq device does not need to be supplier from devlink perspective */ + if ((protocol == SCMI_PROTOCOL_PERF) && !strcmp(name, "cpufreq")) + return 0; + + device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); + + return 0; +} + static struct scmi_device * __scmi_device_create(struct device_node *np, struct device *parent, int protocol, const char *name) @@ -397,7 +410,7 @@ __scmi_device_create(struct device_node *np, struct device *parent, scmi_dev->id = id; scmi_dev->protocol_id = protocol; scmi_dev->dev.parent = parent; - device_set_node(&scmi_dev->dev, of_fwnode_handle(np)); + __scmi_device_set_node(scmi_dev, np, protocol, name); scmi_dev->dev.bus = &scmi_bus_type; scmi_dev->dev.release = scmi_device_release; dev_set_name(&scmi_dev->dev, "scmi_dev.%d", id);