diff mbox series

[5/5] arm64: dts: imx95: add ref clock for pcie nodes

Message ID 20250128211559.1582598-5-Frank.Li@nxp.com (mailing list archive)
State New
Headers show
Series [1/5] arm64: dts: imx8-ss-hsio: fix indentation in pcie node | expand

Commit Message

Frank Li Jan. 28, 2025, 9:15 p.m. UTC 
Add "ref" clock for i.MX95's pcie and fix below CHECK_DTBS warnings:
arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: pcie@4c300000: clock-names: ['pcie', 'pcie_bus', 'pcie_phy', 'pcie_aux'] is too short
	from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx95.dtsi | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

Comments

Shawn Guo Feb. 22, 2025, 3 p.m. UTC | #1 
On Tue, Jan 28, 2025 at 04:15:59PM -0500, Frank Li wrote:
> Add "ref" clock for i.MX95's pcie and fix below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: pcie@4c300000: clock-names: ['pcie', 'pcie_bus', 'pcie_phy', 'pcie_aux'] is too short
> 	from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

#1 ~ #4 are applied and #5 doesn't apply.

Shawn
Richard Zhu Feb. 24, 2025, 2:10 a.m. UTC | #2 
> -----Original Message-----
> From: Shawn Guo <shawnguo2@yeah.net>
> Sent: 2025年2月22日 23:00
> To: Frank Li <frank.li@nxp.com>
> Cc: Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
> Conor Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; open list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <imx@lists.linux.dev>; moderated list:ARM/FREESCALE IMX /
> MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; open list
> <linux-kernel@vger.kernel.org>; Hongxing Zhu <hongxing.zhu@nxp.com>
> Subject: Re: [PATCH 5/5] arm64: dts: imx95: add ref clock for pcie nodes
> 
> On Tue, Jan 28, 2025 at 04:15:59PM -0500, Frank Li wrote:
> > Add "ref" clock for i.MX95's pcie and fix below CHECK_DTBS warnings:
> > arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: pcie@4c300000:
> clock-names: ['pcie', 'pcie_bus', 'pcie_phy', 'pcie_aux'] is too short
> > 	from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree
> .org%2Fschemas%2Fpci%2Ffsl%2Cimx6q-pcie.yaml&data=05%7C02%7Chongxin
> g.zhu%40nxp.com%7Cf373e5ed1a6b4c7aefc908dd5351a620%7C686ea1d3bc2
> b4c6fa92cd99c5c301635%7C0%7C0%7C638758332322731937%7CUnknown
> %7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOi
> JXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=glq
> vwWeavp1SMo6%2F8rZ%2FbGMXgJHCeYPYIZVW3vkTFHs%3D&reserved=0
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> 
> #1 ~ #4 are applied and #5 doesn't apply.
Hi Shawn:
Can you help to take the last one dts patch in one patch-set below instead?
https://patchwork.kernel.org/project/linux-pci/patch/20241126075702.4099164-11-hongxing.zhu@nxp.com/
Thanks in advanced.
BTW, the others had been merged in PCIe git tree.

Best Regards
Richard Zhu
> 
> Shawn
Frank Li Feb. 24, 2025, 5:11 p.m. UTC | #3 
On Mon, Feb 24, 2025 at 02:10:40AM +0000, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Shawn Guo <shawnguo2@yeah.net>
> > Sent: 2025年2月22日 23:00
> > To: Frank Li <frank.li@nxp.com>
> > Cc: Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
> > Conor Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>;
> > Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; open
> > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > <devicetree@vger.kernel.org>; open list:ARM/FREESCALE IMX / MXC ARM
> > ARCHITECTURE <imx@lists.linux.dev>; moderated list:ARM/FREESCALE IMX /
> > MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; open list
> > <linux-kernel@vger.kernel.org>; Hongxing Zhu <hongxing.zhu@nxp.com>
> > Subject: Re: [PATCH 5/5] arm64: dts: imx95: add ref clock for pcie nodes
> >
> > On Tue, Jan 28, 2025 at 04:15:59PM -0500, Frank Li wrote:
> > > Add "ref" clock for i.MX95's pcie and fix below CHECK_DTBS warnings:
> > > arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: pcie@4c300000:
> > clock-names: ['pcie', 'pcie_bus', 'pcie_phy', 'pcie_aux'] is too short
> > > 	from schema $id:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree
> > .org%2Fschemas%2Fpci%2Ffsl%2Cimx6q-pcie.yaml&data=05%7C02%7Chongxin
> > g.zhu%40nxp.com%7Cf373e5ed1a6b4c7aefc908dd5351a620%7C686ea1d3bc2
> > b4c6fa92cd99c5c301635%7C0%7C0%7C638758332322731937%7CUnknown
> > %7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOi
> > JXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=glq
> > vwWeavp1SMo6%2F8rZ%2FbGMXgJHCeYPYIZVW3vkTFHs%3D&reserved=0
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >
> > #1 ~ #4 are applied and #5 doesn't apply.
> Hi Shawn:
> Can you help to take the last one dts patch in one patch-set below instead?
> https://patchwork.kernel.org/project/linux-pci/patch/20241126075702.4099164-11-hongxing.zhu@nxp.com/
> Thanks in advanced.
> BTW, the others had been merged in PCIe git tree.

Richard:

	Still can't apply with your patch because usb3.0 nodes impact this.
	I resend my patch because it is easy to fix conflict and apply your
125mHz input part.

	https://lore.kernel.org/imx/20250224170751.146840-1-Frank.Li@nxp.com/T/#u

Frank

>
> Best Regards
> Richard Zhu
> >
> > Shawn
>
Richard Zhu Feb. 25, 2025, 12:48 a.m. UTC | #4 
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2025年2月25日 1:12
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: Shawn Guo <shawnguo2@yeah.net>; Rob Herring <robh@kernel.org>;
> Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Pengutronix Kernel Team <kernel@pengutronix.de>;
> Fabio Estevam <festevam@gmail.com>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; open
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <imx@lists.linux.dev>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@lists.infradead.org>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 5/5] arm64: dts: imx95: add ref clock for pcie nodes
> 
> On Mon, Feb 24, 2025 at 02:10:40AM +0000, Hongxing Zhu wrote:
> > > -----Original Message-----
> > > From: Shawn Guo <shawnguo2@yeah.net>
> > > Sent: 2025年2月22日 23:00
> > > To: Frank Li <frank.li@nxp.com>
> > > Cc: Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> > > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Shawn Guo
> > > <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> > > Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> > > <festevam@gmail.com>; open list:OPEN FIRMWARE AND FLATTENED DEVICE
> > > TREE BINDINGS <devicetree@vger.kernel.org>; open list:ARM/FREESCALE
> > > IMX / MXC ARM ARCHITECTURE <imx@lists.linux.dev>; moderated
> > > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > > <linux-arm-kernel@lists.infradead.org>; open list
> > > <linux-kernel@vger.kernel.org>; Hongxing Zhu <hongxing.zhu@nxp.com>
> > > Subject: Re: [PATCH 5/5] arm64: dts: imx95: add ref clock for pcie
> > > nodes
> > >
> > > On Tue, Jan 28, 2025 at 04:15:59PM -0500, Frank Li wrote:
> > > > Add "ref" clock for i.MX95's pcie and fix below CHECK_DTBS warnings:
> > > > arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: pcie@4c300000:
> > > clock-names: ['pcie', 'pcie_bus', 'pcie_phy', 'pcie_aux'] is too
> > > short
> > > > 	from schema $id:
> > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev
> > > icetree
> > > .org%2Fschemas%2Fpci%2Ffsl%2Cimx6q-pcie.yaml&data=05%7C02%7Chon
> gxin
> > >
> g.zhu%40nxp.com%7Cf373e5ed1a6b4c7aefc908dd5351a620%7C686ea1d3bc2
> > >
> b4c6fa92cd99c5c301635%7C0%7C0%7C638758332322731937%7CUnknown
> > > %7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIl
> AiOi
> > >
> JXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=glq
> > > vwWeavp1SMo6%2F8rZ%2FbGMXgJHCeYPYIZVW3vkTFHs%3D&reserved=0
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > >
> > > #1 ~ #4 are applied and #5 doesn't apply.
> > Hi Shawn:
> > Can you help to take the last one dts patch in one patch-set below instead?
> > https://patchwork.kernel.org/project/linux-pci/patch/20241126075702.40
> > 99164-11-hongxing.zhu@nxp.com/
> > Thanks in advanced.
> > BTW, the others had been merged in PCIe git tree.
> 
> Richard:
> 
> 	Still can't apply with your patch because usb3.0 nodes impact this.
> 	I resend my patch because it is easy to fix conflict and apply your 125mHz
> input part.
> 
> 	https://lore.kernel.org/imx/20250224170751.146840-1-Frank.Li@nxp.co
> m/T/#u
Okay.


Best Regards
Richard Zhu
> 
> Frank
> 
> >
> > Best Regards
> > Richard Zhu
> > >
> > > Shawn
> >
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi
index 2cebeda43a52d..f0dc8be2abffa 100644
--- a/arch/arm64/boot/dts/freescale/imx95.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx95.dtsi
@@ -1537,6 +1537,14 @@  smmu: iommu@490d0000 {
 			};
 		};
 
+		hsio_blk_ctl: syscon@4c0100c0 {
+			compatible = "nxp,imx95-hsio-blk-ctl", "syscon";
+			reg = <0x0 0x4c0100c0 0x0 0x1>;
+			#clock-cells = <1>;
+			power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>;
+			clocks = <&dummy>;
+		};
+
 		pcie0: pcie@4c300000 {
 			compatible = "fsl,imx95-pcie";
 			reg = <0 0x4c300000 0 0x10000>,
@@ -1564,8 +1572,9 @@  pcie0: pcie@4c300000 {
 			clocks = <&scmi_clk IMX95_CLK_HSIO>,
 				 <&scmi_clk IMX95_CLK_HSIOPLL>,
 				 <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
-				 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
-			clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
+				 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>,
+				 <&hsio_blk_ctl 0>;
+			clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux", "ref";
 			assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
 					 <&scmi_clk IMX95_CLK_HSIOPLL>,
 					 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
@@ -1637,8 +1646,9 @@  pcie1: pcie@4c380000 {
 			clocks = <&scmi_clk IMX95_CLK_HSIO>,
 				 <&scmi_clk IMX95_CLK_HSIOPLL>,
 				 <&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
-				 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;
-			clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux";
+				 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>,
+				 <&hsio_blk_ctl 0>;
+			clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux", "ref";
 			assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>,
 					 <&scmi_clk IMX95_CLK_HSIOPLL>,
 					 <&scmi_clk IMX95_CLK_HSIOPCIEAUX>;