| Message ID | 20250210-8qxp_camera-v3-10-324f5105accc@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: imx8: add camera support | expand |
Hi Frank, Thank you for the patch. On Mon, Feb 10, 2025 at 03:59:29PM -0500, Frank Li wrote: > Add fixed clock node clock-xtal24m to prepare to add camera support. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > change from v1 to v3 > - none > --- > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > index c6a17a0d739c5..40cd45cd9f88f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > @@ -590,6 +590,13 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll { > clock-output-names = "mipi_pll_div2_clk"; > }; > > + xtal24m: clock-xtal24m { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + clock-output-names = "xtal_24MHz"; > + }; This is a clock oscillator mounted on the PCB, isn't it ? It shouldn't be in imx8qm.dtsi, but in board-specific DT sources. > + > vpu_subsys_dsp: bus@55000000 { > compatible = "simple-bus"; > #address-cells = <1>;
On Thu, Mar 27, 2025 at 08:58:14PM +0200, Laurent Pinchart wrote: > Hi Frank, > > Thank you for the patch. > > On Mon, Feb 10, 2025 at 03:59:29PM -0500, Frank Li wrote: > > Add fixed clock node clock-xtal24m to prepare to add camera support. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > change from v1 to v3 > > - none > > --- > > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > > index c6a17a0d739c5..40cd45cd9f88f 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > > @@ -590,6 +590,13 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll { > > clock-output-names = "mipi_pll_div2_clk"; > > }; > > > > + xtal24m: clock-xtal24m { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <24000000>; > > + clock-output-names = "xtal_24MHz"; > > + }; > > This is a clock oscillator mounted on the PCB, isn't it ? It shouldn't > be in imx8qm.dtsi, but in board-specific DT sources. You add fixed regulators to arch/arm64/boot/dts/freescale/imx8qm-mek.dts and arch/arm64/boot/dts/freescale/imx8qxp-mek.dts in patch 12/12, the additional of the fixed clock could go there too, in the same patch. > > + > > vpu_subsys_dsp: bus@55000000 { > > compatible = "simple-bus"; > > #address-cells = <1>;
diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi index c6a17a0d739c5..40cd45cd9f88f 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi @@ -590,6 +590,13 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll { clock-output-names = "mipi_pll_div2_clk"; }; + xtal24m: clock-xtal24m { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <24000000>; + clock-output-names = "xtal_24MHz"; + }; + vpu_subsys_dsp: bus@55000000 { compatible = "simple-bus"; #address-cells = <1>;
Add fixed clock node clock-xtal24m to prepare to add camera support. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- change from v1 to v3 - none --- arch/arm64/boot/dts/freescale/imx8qm.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)