| Message ID | 20250221190929.31469-5-laurentiumihalcea111@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: imx8mp: fix parents of AUDIOMIX DSP/OCRAM_A | expand |
On Fri, Feb 21, 2025 at 1:11 PM Laurentiu Mihalcea <laurentiumihalcea111@gmail.com> wrote: > > From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > > AUDIO_AXI_CLK_ROOT can't run at currently requested 600MHz w/ its parent > SYS_PLL1 configured at 800MHz. Configure it to run at 800MHz as some > applications running on the DSP expect the core to run at this frequency > anyways. This change also affects the AUDIOMIX NoC. Unless I am missing something, the i.MX 8M Plus Applications Processor Datasheet (rev 2.1) has a table of frequencies, and AUDIO_AXI_CLK_ROOT is shown to be 600MHz nominal and 800MHz for overdrive. I agree that it's likely not running at 600MHz now, but 800MHz may be out of spec for people who are using the nominal voltage instead of the overdrive, since overdrive requires higher voltages than the nominal. adam > > Fixes: b739681b3f8b ("arm64: dts: imx8mp: Fix SDMA2/3 clocks") > Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 86c3055789ba..54147bce3b83 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -834,7 +834,7 @@ pgc_audio: power-domain@5 { > assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>, > <&clk IMX8MP_SYS_PLL1_800M>; > assigned-clock-rates = <400000000>, > - <600000000>; > + <800000000>; > }; > > pgc_gpu2d: power-domain@6 { > -- > 2.34.1 > >
On 21.02.2025 21:37, Adam Ford wrote: > On Fri, Feb 21, 2025 at 1:11 PM Laurentiu Mihalcea > <laurentiumihalcea111@gmail.com> wrote: >> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> >> >> AUDIO_AXI_CLK_ROOT can't run at currently requested 600MHz w/ its parent >> SYS_PLL1 configured at 800MHz. Configure it to run at 800MHz as some >> applications running on the DSP expect the core to run at this frequency >> anyways. This change also affects the AUDIOMIX NoC. > Unless I am missing something, the i.MX 8M Plus Applications Processor > Datasheet (rev 2.1) has a table of frequencies, and > AUDIO_AXI_CLK_ROOT is shown to be 600MHz nominal and 800MHz for > overdrive. I agree that it's likely not running at 600MHz now, but > 800MHz may be out of spec for people who are using the nominal voltage > instead of the overdrive, since overdrive requires higher voltages > than the nominal. > > adam You're right, this would not work if someone was using nominal voltage. Do you have an upstream board in mind/usecase which works with nominal voltage instead of overdrive? As far as I understood from Lucas's patch ([1]) there's no upstream board using nominal voltage? CC-ing Lucas on this as his patch ([1]) is similar to this in that they're both trying to use overdrive clock frequencies in the DTSI and I'd very much like to have some sort of consistency in the DTSI if possible. [1]: https://lore.kernel.org/imx/20250204182737.3361431-1-l.stach@pengutronix.de/
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 86c3055789ba..54147bce3b83 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -834,7 +834,7 @@ pgc_audio: power-domain@5 { assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>, <&clk IMX8MP_SYS_PLL1_800M>; assigned-clock-rates = <400000000>, - <600000000>; + <800000000>; }; pgc_gpu2d: power-domain@6 {