| Message ID | 20250403-dt-cpu-schema-v1-18-076be7171a85@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Arm cpu schema clean-ups | expand |
On Fri, 4 Apr 2025 at 05:06, Rob Herring (Arm) <robh@kernel.org> wrote: > > The "power-domains" and "power-domains-names" properties are missing any > constraints. Add the constraints and drop the generic descriptions. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > index 6f74ebfd38df..5bd5822db8af 100644 > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > @@ -313,19 +313,15 @@ properties: > maxItems: 1 > > power-domains: > - description: > - List of phandles and PM domain specifiers, as defined by bindings of the > - PM domain provider (see also ../power_domain.txt). > + maxItems: 1 There are more than one in some cases. The most is probably three, I think. > > power-domain-names: > description: > - A list of power domain name strings sorted in the same order as the > - power-domains property. > - > For PSCI based platforms, the name corresponding to the index of the PSCI > PM domain provider, must be "psci". For SCMI based platforms, the name > corresponding to the index of an SCMI performance domain provider, must be > "perf". > + enum: [ psci, perf, cpr ] > > resets: > maxItems: 1 > > -- > 2.47.2 > > Other than above, feel free to add: Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe
Il 04/04/25 04:59, Rob Herring (Arm) ha scritto: > The "power-domains" and "power-domains-names" properties are missing any > constraints. Add the constraints and drop the generic descriptions. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> For MediaTek: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Fri, Apr 4, 2025 at 5:37 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Fri, 4 Apr 2025 at 05:06, Rob Herring (Arm) <robh@kernel.org> wrote: > > > > The "power-domains" and "power-domains-names" properties are missing any > > constraints. Add the constraints and drop the generic descriptions. > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/arm/cpus.yaml | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > > index 6f74ebfd38df..5bd5822db8af 100644 > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > > @@ -313,19 +313,15 @@ properties: > > maxItems: 1 > > > > power-domains: > > - description: > > - List of phandles and PM domain specifiers, as defined by bindings of the > > - PM domain provider (see also ../power_domain.txt). > > + maxItems: 1 > > There are more than one in some cases. The most is probably three, I think. Unless I missed it, testing says otherwise. What would the names be if more than 1 entry? Rob
diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml index 6f74ebfd38df..5bd5822db8af 100644 --- a/Documentation/devicetree/bindings/arm/cpus.yaml +++ b/Documentation/devicetree/bindings/arm/cpus.yaml @@ -313,19 +313,15 @@ properties: maxItems: 1 power-domains: - description: - List of phandles and PM domain specifiers, as defined by bindings of the - PM domain provider (see also ../power_domain.txt). + maxItems: 1 power-domain-names: description: - A list of power domain name strings sorted in the same order as the - power-domains property. - For PSCI based platforms, the name corresponding to the index of the PSCI PM domain provider, must be "psci". For SCMI based platforms, the name corresponding to the index of an SCMI performance domain provider, must be "perf". + enum: [ psci, perf, cpr ] resets: maxItems: 1
The "power-domains" and "power-domains-names" properties are missing any constraints. Add the constraints and drop the generic descriptions. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- Documentation/devicetree/bindings/arm/cpus.yaml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)