From patchwork Fri Sep 14 06:54:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kulkarni, Vandita" X-Patchwork-Id: 10600499 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 65074112B for ; Fri, 14 Sep 2018 09:15:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4364D2A45B for ; Fri, 14 Sep 2018 09:15:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 379212B28B; Fri, 14 Sep 2018 09:15:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E68CD2A45B for ; Fri, 14 Sep 2018 09:15:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E6296E7C1; Fri, 14 Sep 2018 09:10:43 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2C0A6E070 for ; Fri, 14 Sep 2018 07:08:07 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2018 00:08:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,372,1531810800"; d="scan'208";a="83443479" Received: from vandita-desktop.iind.intel.com ([10.223.25.24]) by orsmga003.jf.intel.com with ESMTP; 14 Sep 2018 00:07:39 -0700 From: Vandita Kulkarni To: intel-gfx@lists.freedesktop.org Date: Fri, 14 Sep 2018 12:24:11 +0530 Message-Id: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com> X-Mailer: git-send-email 1.9.1 Subject: [Intel-gfx] [RFC 0/3] Enable ICL DSI PLL X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, paulo.r.zanoni@intel.com MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Gen11/ICL DSI has to choose one of the free available DPLL which can also be tied to DDI A/B combo phy ports. In legacy platforms that was not the case as DSI had separate/exclusive PLLs. ICL DPLL enable/disable steps are 80% common if DPLL is tied to DDI interface (HDMI/DP) or DSI. If DSI implements separate PLL enable/disable sequence like in legacy platform, lot of duplicate code will be added which is not the right way. Current DPLL enable/disable functions has some steps specific to DP/HDMI and require some redesign if DSI has to use these existing DPLL functions. RFC in this series alter existing DPLL functions to have common code for enabling DPLL and move encoder specific code (DP/HDMI/DSI) to encoder files. Currently changes are for *enabling DPLL only*. If this approach looks fine, RFC for disabling PLL will also be added. These RFC patches has been tested and Single/Dual Link Video mode works fine tested with https://github.com/madhavchauhan/Intel-DSI-Driver.git These RFC patches are developed on top of following published series: https://patchwork.freedesktop.org/series/44823/ Madhav Chauhan (3): drm/i915/icl: Restructure ICL DPLL enable functionality drm/i915/icl: Enable Gen11 DSI PLL drm/i915/icl: Calculate DPLL params for DSI drivers/gpu/drm/i915/icl_dsi.c | 41 ++++++++++++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_ddi.c | 12 ++++++++++ drivers/gpu/drm/i915/intel_display.c | 4 +++- drivers/gpu/drm/i915/intel_dpll_mgr.c | 26 +++++++--------------- drivers/gpu/drm/i915/intel_dpll_mgr.h | 2 +- 5 files changed, 64 insertions(+), 21 deletions(-)