mbox series

[0/3] drm/i915/icl: Fix TypeC legacy HPD handling

Message ID 20181213194850.25406-1-imre.deak@intel.com (mailing list archive)
Headers show
Series drm/i915/icl: Fix TypeC legacy HPD handling | expand

Message

Imre Deak Dec. 13, 2018, 7:48 p.m. UTC 
This patchset fixes the HPD handling for TypeC legacy ports. It depends
on an indirect detection method described in patch 2 and 3, which will
be replaced by a direct method once the BIOS/HW/FW team delivers a
promised SW/HW flag for this purpose.

There is no issue with the indirect method I know of, except for the DP
legacy case (as opposed to the HDMI case), where doing a modeset/DP AUX
read before the first HPD connect event will still result in mayham. But
that is already the situation now and we have a plan in place (the
direct method mentioned above), so the change is an improvement even for
the DP case.

This will leave the Thunderbolt and USB DP alternate mode HPD handling
still disfunctional, but that's another story, we have some plan to fix
that too (in cooperation with the HW/FW team).

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

Imre Deak (3):
  drm/i915/icl: Add a debug print for TypeC port disconnection
  drm/i915/icl: Add fix for TypeC legacy HDMI HPD handling
  drm/i915/icl: Add fix for TypeC legacy DP HPD handling

 drivers/gpu/drm/i915/intel_ddi.c | 54 +++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/intel_dp.c  | 69 +++++++++++++++++++++++++++++-----------
 drivers/gpu/drm/i915/intel_drv.h |  5 ++-
 3 files changed, 105 insertions(+), 23 deletions(-)