| Message ID | 20190218193137.22914-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Clean up ilk+ csc stuff | expand |
On Mon, Feb 18, 2019 at 08:35:33PM -0000, Patchwork wrote: > == Series Details == > > Series: drm/i915: Clean up ilk+ csc stuff > URL : https://patchwork.freedesktop.org/series/56857/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5628 -> Patchwork_12251 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_12251 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_12251, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/56857/revisions/1/mbox/ > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_12251: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@kms_chamelium@hdmi-edid-read: > - fi-kbl-7567u: PASS -> FAIL +2 > LSPCON stuck its head in the sand during suspend. Later on a second suspend cycle seems to have roused it back up. > Known issues > ------------ > > Here are the changes found in Patchwork_12251 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@debugfs_test@read_all_entries: > - fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] > > * igt@gem_exec_suspend@basic-s3: > - fi-kbl-7567u: PASS -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602] > > * igt@i915_module_load@reload: > - fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718] > > * igt@i915_selftest@live_execlists: > - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] > > * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: > - fi-kbl-7567u: PASS -> DMESG-FAIL [fdo#105079] > > * igt@pm_rpm@module-reload: > - fi-kbl-7567u: NOTRUN -> DMESG-WARN [fdo#108529] > > > #### Possible fixes #### > > * igt@gem_exec_suspend@basic-s4-devices: > - fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 > [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079 > [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 > [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 > [fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529 > [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 > [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 > [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 > [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 > [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 > > > Participating hosts (47 -> 40) > ------------------------------ > > Additional (1): fi-icl-u3 > Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus fi-skl-6700k2 > > > Build changes > ------------- > > * Linux: CI_DRM_5628 -> Patchwork_12251 > > CI_DRM_5628: 7f6ace5f10a9d6c5d277b95e39f862eff87fdb45 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4836: 51d069e07b3f7697f06fa8947ee92a196356d8b3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_12251: b73647fba7bc7cc31ceb1049e8ef419a81e7d02e @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > b73647fba7bc drm/i915: Split ilk vs. icl csc matrix handling > d2e4313a1339 drm/i915: Clean the csc limited range/identity programming > 3519fcb20e99 drm/i915: Extract ilk_csc_convert_ctm() > 34d9c779bc86 drm/i915: Clean up ilk/icl pipe/output CSC programming > 13b47b302e6a drm/i915: Extract ilk_csc_limited_range() > b20e16c5b848 drm/i915: Preocmpute/readout/check CHV CGM mode > b09761d15ddf drm/i915: Readout and check csc_mode > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12251/ > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Mar 15, 2019 at 06:19:08PM -0000, Patchwork wrote: > == Series Details == > > Series: drm/i915: Clean up ilk+ csc stuff (rev2) > URL : https://patchwork.freedesktop.org/series/56857/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12478_full > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_12478_full absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_12478_full, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_12478_full: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@kms_psr@psr2_sprite_plane_move: > - shard-iclb: PASS -> FAIL Some kind of psr fail. Starting subtest: psr2_sprite_plane_move (kms_psr:13846) CRITICAL: Test assertion failure function test_setup, file ../tests/kms_psr.c:394: (kms_psr:13846) CRITICAL: Failed assertion: psr_wait_entry_if_enabled(data) Subtest psr2_sprite_plane_move failed. > > > Known issues > ------------ > > Here are the changes found in Patchwork_12478_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_exec_parallel@bsd1: > - shard-skl: NOTRUN -> SKIP [fdo#109271] +78 > > * igt@gem_exec_params@no-blt: > - shard-iclb: NOTRUN -> SKIP [fdo#109283] > > * igt@gem_ppgtt@blt-vs-render-ctxn: > - shard-iclb: NOTRUN -> INCOMPLETE [fdo#107713] / [fdo#109766] / [fdo#109801] > > * igt@gem_pwrite@huge-gtt-random: > - shard-iclb: NOTRUN -> SKIP [fdo#109290] > > * igt@i915_pm_backlight@fade_with_suspend: > - shard-iclb: NOTRUN -> FAIL [fdo#107847] > > * igt@i915_pm_rpm@drm-resources-equal: > - shard-apl: PASS -> INCOMPLETE [fdo#103927] > > * igt@i915_pm_rps@reset: > - shard-iclb: NOTRUN -> FAIL [fdo#108059] +1 > > * igt@kms_busy@basic-modeset-e: > - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1 > > * igt@kms_busy@extended-modeset-hang-newfb-render-b: > - shard-hsw: PASS -> DMESG-WARN [fdo#107956] > > * igt@kms_busy@extended-pageflip-hang-oldfb-render-d: > - shard-iclb: NOTRUN -> SKIP [fdo#109278] +4 > > * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c: > - shard-iclb: PASS -> DMESG-WARN [fdo#107956] > - shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +1 > > * igt@kms_chamelium@vga-edid-read: > - shard-iclb: NOTRUN -> SKIP [fdo#109284] +1 > > * igt@kms_color@pipe-b-degamma: > - shard-skl: PASS -> FAIL [fdo#104782] > > * igt@kms_color@pipe-b-legacy-gamma: > - shard-iclb: NOTRUN -> FAIL [fdo#104782] > > * igt@kms_cursor_crc@cursor-128x128-onscreen: > - shard-skl: NOTRUN -> FAIL [fdo#103232] > > * igt@kms_cursor_crc@cursor-256x256-suspend: > - shard-skl: PASS -> FAIL [fdo#103191] / [fdo#103232] > > * igt@kms_cursor_crc@cursor-256x85-random: > - shard-apl: PASS -> FAIL [fdo#103232] > > * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: > - shard-glk: PASS -> FAIL [fdo#104873] +1 > > * igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: > - shard-glk: PASS -> FAIL [fdo#105454] > > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: > - shard-snb: PASS -> SKIP [fdo#109271] > > * igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions: > - shard-iclb: PASS -> FAIL [fdo#103355] +1 > > * igt@kms_dp_dsc@basic-dsc-enable-edp: > - shard-iclb: NOTRUN -> FAIL [fdo#109358] > > * igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible: > - shard-iclb: NOTRUN -> SKIP [fdo#109274] +1 > > * igt@kms_flip@dpms-vs-vblank-race: > - shard-kbl: PASS -> FAIL [fdo#103060] > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc: > - shard-skl: NOTRUN -> FAIL [fdo#103167] > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite: > - shard-apl: PASS -> FAIL [fdo#103167] +1 > > * igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw: > - shard-iclb: NOTRUN -> SKIP [fdo#109280] +14 > > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc: > - shard-snb: NOTRUN -> SKIP [fdo#109271] +44 > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt: > - shard-iclb: PASS -> FAIL [fdo#103167] +5 > > * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff: > - shard-iclb: NOTRUN -> FAIL [fdo#109247] +2 > > * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen: > - shard-iclb: NOTRUN -> FAIL [fdo#103167] +4 > > * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt: > - shard-iclb: PASS -> FAIL [fdo#109247] +21 > > * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: > - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] > > * igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb: > - shard-skl: NOTRUN -> FAIL [fdo#108145] +2 > > * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: > - shard-skl: PASS -> FAIL [fdo#108145] > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > - shard-skl: PASS -> FAIL [fdo#107815] > > * igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format: > - shard-iclb: NOTRUN -> FAIL [fdo#109052] > > * igt@kms_psr@cursor_plane_onoff: > - shard-iclb: NOTRUN -> FAIL [fdo#107383] > > * igt@kms_psr@cursor_render: > - shard-iclb: PASS -> FAIL [fdo#107383] +3 > > * igt@kms_psr@psr2_dpms: > - shard-iclb: PASS -> SKIP [fdo#109441] +1 > > * igt@kms_rotation_crc@bad-pixel-format: > - shard-iclb: NOTRUN -> SKIP [fdo#109289] > > * igt@kms_rotation_crc@multiplane-rotation-cropping-top: > - shard-kbl: PASS -> FAIL [fdo#109016] > > * igt@kms_universal_plane@cursor-fb-leak-pipe-d: > - shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +10 > > * igt@kms_vblank@pipe-c-ts-continuation-suspend: > - shard-iclb: PASS -> FAIL [fdo#104894] > > * igt@prime_nv_api@i915_nv_import_twice_check_flink_name: > - shard-iclb: NOTRUN -> SKIP [fdo#109291] +3 > > * igt@prime_vgem@coherency-gtt: > - shard-iclb: NOTRUN -> SKIP [fdo#109292] > > * igt@prime_vgem@fence-wait-bsd1: > - shard-iclb: NOTRUN -> SKIP [fdo#109276] +11 > > > #### Possible fixes #### > > * igt@gem_exec_schedule@wide-blt: > - shard-iclb: DMESG-WARN [fdo#109638] -> PASS > > * igt@gem_exec_suspend@basic-s3: > - shard-skl: INCOMPLETE [fdo#104108] -> PASS > > * igt@gem_mmap_gtt@big-copy-xy: > - shard-iclb: TIMEOUT [fdo#109673] -> PASS > > * igt@gem_partial_pwrite_pread@writes-after-reads-snoop: > - shard-iclb: INCOMPLETE [fdo#107713] -> PASS > > * igt@gem_ppgtt@blt-vs-render-ctx0: > - shard-iclb: INCOMPLETE [fdo#109100] / [fdo#109766] / [fdo#109801] -> PASS > > * igt@i915_selftest@live_workarounds: > - shard-iclb: DMESG-FAIL [fdo#108954] -> PASS > > * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing: > - shard-skl: FAIL [fdo#107815] / [fdo#108470] -> PASS > > * igt@kms_busy@extended-pageflip-hang-newfb-render-a: > - shard-glk: DMESG-WARN [fdo#107956] -> PASS > > * igt@kms_ccs@pipe-b-crc-sprite-planes-basic: > - shard-iclb: FAIL [fdo#107725] -> PASS > > * igt@kms_color@pipe-b-legacy-gamma: > - shard-apl: FAIL [fdo#104782] -> PASS > > * igt@kms_cursor_crc@cursor-128x128-sliding: > - shard-apl: FAIL [fdo#103232] -> PASS +1 > > * igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: > - shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS > > * igt@kms_cursor_legacy@cursor-vs-flip-legacy: > - shard-iclb: FAIL [fdo#103355] -> PASS +1 > > * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-gtt: > - shard-iclb: FAIL [fdo#103167] -> PASS +6 > > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff: > - shard-apl: FAIL [fdo#103167] -> PASS +2 > > * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff: > - shard-glk: FAIL [fdo#103167] -> PASS +1 > > * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-blt: > - shard-iclb: FAIL [fdo#109247] -> PASS +14 > > * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a: > - shard-skl: FAIL [fdo#107362] -> PASS > > * {igt@kms_plane@plane-position-covered-pipe-a-planes}: > - shard-apl: FAIL [fdo#110038] -> PASS > > * {igt@kms_plane@plane-position-covered-pipe-b-planes}: > - shard-iclb: FAIL [fdo#110038] -> PASS +1 > > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: > - shard-skl: FAIL [fdo#107815] / [fdo#108145] -> PASS > > * {igt@kms_plane_multiple@atomic-pipe-a-tiling-none}: > - shard-iclb: FAIL [fdo#110037] -> PASS > > * {igt@kms_plane_multiple@atomic-pipe-a-tiling-x}: > - shard-apl: FAIL [fdo#110037] -> PASS +2 > > * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping: > - shard-glk: SKIP [fdo#109271] / [fdo#109278] -> PASS > > * igt@kms_psr@cursor_mmap_cpu: > - shard-iclb: FAIL [fdo#107383] -> PASS > > * igt@kms_psr@psr2_primary_page_flip: > - shard-iclb: SKIP [fdo#109441] -> PASS +3 > > * igt@kms_rotation_crc@multiplane-rotation-cropping-bottom: > - shard-kbl: DMESG-FAIL [fdo#105763] -> PASS > > * igt@kms_setmode@basic: > - shard-apl: FAIL [fdo#99912] -> PASS > > > #### Warnings #### > > * igt@kms_frontbuffer_tracking@fbcpsr-suspend: > - shard-skl: FAIL [fdo#103167] -> INCOMPLETE [fdo#104108] / [fdo#106978] > > * igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format: > - shard-glk: SKIP [fdo#109271] / [fdo#109278] -> FAIL [fdo#110098] > > * igt@kms_plane_scaling@pipe-c-scaler-with-pixel-format: > - shard-glk: FAIL [fdo#110098] -> SKIP [fdo#109271] / [fdo#109278] > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 > [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 > [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 > [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782 > [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873 > [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894 > [fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454 > [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763 > [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509 > [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978 > [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 > [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383 > [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 > [fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725 > [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 > [fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847 > [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956 > [fdo#108059]: https://bugs.freedesktop.org/show_bug.cgi?id=108059 > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#108470]: https://bugs.freedesktop.org/show_bug.cgi?id=108470 > [fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954 > [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016 > [fdo#109052]: https://bugs.freedesktop.org/show_bug.cgi?id=109052 > [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 > [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247 > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 > [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 > [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 > [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 > [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 > [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 > [fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290 > [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 > [fdo#109292]: https://bugs.freedesktop.org/show_bug.cgi?id=109292 > [fdo#109358]: https://bugs.freedesktop.org/show_bug.cgi?id=109358 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#109638]: https://bugs.freedesktop.org/show_bug.cgi?id=109638 > [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673 > [fdo#109766]: https://bugs.freedesktop.org/show_bug.cgi?id=109766 > [fdo#109801]: https://bugs.freedesktop.org/show_bug.cgi?id=109801 > [fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037 > [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038 > [fdo#110098]: https://bugs.freedesktop.org/show_bug.cgi?id=110098 > [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 > > > Participating hosts (10 -> 10) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * Linux: CI_DRM_5753 -> Patchwork_12478 > > CI_DRM_5753: 0eb0838c0c26378949de6816166117c8b2d73caa @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_4887: 5a7c7575b5bb9542f722ed6ba095b9d62609cd56 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_12478: ad1b68919282082c87040e7d6bf6697865c23797 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12478/
From: Ville Syrjälä <ville.syrjala@linux.intel.com> I wanted to make some progress towards exposing more fancy gamma modes, and actually usin them. As a start I ended up with some 30 patches to clean up the mess that is intel_color_check(). Fortunately I can split this up into a few mostly independent chunks. The first of which is this series that cleans up the ilk+ csc code a bit. And I included a small piece for the CHV CGM as well. Ville Syrjälä (7): drm/i915: Readout and check csc_mode drm/i915: Preocmpute/readout/check CHV CGM mode drm/i915: Extract ilk_csc_limited_range() drm/i915: Clean up ilk/icl pipe/output CSC programming drm/i915: Extract ilk_csc_convert_ctm() drm/i915: Clean the csc limited range/identity programming drm/i915: Split ilk vs. icl csc matrix handling drivers/gpu/drm/i915/intel_color.c | 384 +++++++++++++++------------ drivers/gpu/drm/i915/intel_display.c | 11 + drivers/gpu/drm/i915/intel_drv.h | 9 +- 3 files changed, 233 insertions(+), 171 deletions(-)