mbox series

[v3,0/9] drm/i915/perf: add OA interrupt support

Message ID 20190226142911.9789-1-lionel.g.landwerlin@intel.com (mailing list archive)
Headers show
Series drm/i915/perf: add OA interrupt support | expand

Message

Lionel Landwerlin Feb. 26, 2019, 2:29 p.m. UTC
Hi all,

This third iteration adds an i915 perf revision number through
getparam so that application can more easily find out what feature of
i915-perf are available.

The patches containing uAPI updates have been updated to indicate what
version is required to those changes to be available.

Cheers,

Lionel Landwerlin (9):
  drm/i915/perf: rework aging tail workaround
  drm/i915/perf: move pollin setup to non hw specific code
  drm/i915/perf: only append status when data is available
  drm/i915/perf: introduce a versioning of the i915-perf uapi
  drm/i915/perf: add new open param to configure polling of OA buffer
  drm/i915: handle interrupts from the OA unit
  drm/i915/perf: add interrupt enabling parameter
  drm/i915/perf: add flushing ioctl
  drm/i915/perf: bump i915-perf revision

 drivers/gpu/drm/i915/i915_drv.c         |   3 +
 drivers/gpu/drm/i915/i915_drv.h         |  59 +++-
 drivers/gpu/drm/i915/i915_irq.c         |  39 ++-
 drivers/gpu/drm/i915/i915_perf.c        | 403 ++++++++++++++----------
 drivers/gpu/drm/i915/i915_reg.h         |   7 +
 drivers/gpu/drm/i915/intel_ringbuffer.c |   2 +
 include/uapi/drm/i915_drm.h             |  61 ++++
 7 files changed, 390 insertions(+), 184 deletions(-)

--
2.20.1

Comments

Lionel Landwerlin March 25, 2019, 10:34 a.m. UTC | #1
Ping?

On 26/02/2019 14:29, Lionel Landwerlin wrote:
> Hi all,
>
> This third iteration adds an i915 perf revision number through
> getparam so that application can more easily find out what feature of
> i915-perf are available.
>
> The patches containing uAPI updates have been updated to indicate what
> version is required to those changes to be available.
>
> Cheers,
>
> Lionel Landwerlin (9):
>    drm/i915/perf: rework aging tail workaround
>    drm/i915/perf: move pollin setup to non hw specific code
>    drm/i915/perf: only append status when data is available
>    drm/i915/perf: introduce a versioning of the i915-perf uapi
>    drm/i915/perf: add new open param to configure polling of OA buffer
>    drm/i915: handle interrupts from the OA unit
>    drm/i915/perf: add interrupt enabling parameter
>    drm/i915/perf: add flushing ioctl
>    drm/i915/perf: bump i915-perf revision
>
>   drivers/gpu/drm/i915/i915_drv.c         |   3 +
>   drivers/gpu/drm/i915/i915_drv.h         |  59 +++-
>   drivers/gpu/drm/i915/i915_irq.c         |  39 ++-
>   drivers/gpu/drm/i915/i915_perf.c        | 403 ++++++++++++++----------
>   drivers/gpu/drm/i915/i915_reg.h         |   7 +
>   drivers/gpu/drm/i915/intel_ringbuffer.c |   2 +
>   include/uapi/drm/i915_drm.h             |  61 ++++
>   7 files changed, 390 insertions(+), 184 deletions(-)
>
> --
> 2.20.1
>
Joonas Lahtinen April 2, 2019, 11:49 a.m. UTC | #2
Quoting Lionel Landwerlin (2019-03-25 12:34:44)
> Ping?

The last patch should be squashed, I think we want to minimize the
amount of versions. Or do you intend to backport only portion of
the series somewhere?

Can you link to the userspace side changes?

Regards, Joonas

> 
> On 26/02/2019 14:29, Lionel Landwerlin wrote:
> > Hi all,
> >
> > This third iteration adds an i915 perf revision number through
> > getparam so that application can more easily find out what feature of
> > i915-perf are available.
> >
> > The patches containing uAPI updates have been updated to indicate what
> > version is required to those changes to be available.
> >
> > Cheers,
> >
> > Lionel Landwerlin (9):
> >    drm/i915/perf: rework aging tail workaround
> >    drm/i915/perf: move pollin setup to non hw specific code
> >    drm/i915/perf: only append status when data is available
> >    drm/i915/perf: introduce a versioning of the i915-perf uapi
> >    drm/i915/perf: add new open param to configure polling of OA buffer
> >    drm/i915: handle interrupts from the OA unit
> >    drm/i915/perf: add interrupt enabling parameter
> >    drm/i915/perf: add flushing ioctl
> >    drm/i915/perf: bump i915-perf revision
> >
> >   drivers/gpu/drm/i915/i915_drv.c         |   3 +
> >   drivers/gpu/drm/i915/i915_drv.h         |  59 +++-
> >   drivers/gpu/drm/i915/i915_irq.c         |  39 ++-
> >   drivers/gpu/drm/i915/i915_perf.c        | 403 ++++++++++++++----------
> >   drivers/gpu/drm/i915/i915_reg.h         |   7 +
> >   drivers/gpu/drm/i915/intel_ringbuffer.c |   2 +
> >   include/uapi/drm/i915_drm.h             |  61 ++++
> >   7 files changed, 390 insertions(+), 184 deletions(-)
> >
> > --
> > 2.20.1
> >
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Lionel Landwerlin April 2, 2019, 4:36 p.m. UTC | #3
On 02/04/2019 14:49, Joonas Lahtinen wrote:
> Quoting Lionel Landwerlin (2019-03-25 12:34:44)
>> Ping?
> The last patch should be squashed, I think we want to minimize the
> amount of versions. Or do you intend to backport only portion of
> the series somewhere?


No backport intended :)


>
> Can you link to the userspace side changes?


https://github.com/rib/gputop/pull/198


>
> Regards, Joonas
>
>> On 26/02/2019 14:29, Lionel Landwerlin wrote:
>>> Hi all,
>>>
>>> This third iteration adds an i915 perf revision number through
>>> getparam so that application can more easily find out what feature of
>>> i915-perf are available.
>>>
>>> The patches containing uAPI updates have been updated to indicate what
>>> version is required to those changes to be available.
>>>
>>> Cheers,
>>>
>>> Lionel Landwerlin (9):
>>>     drm/i915/perf: rework aging tail workaround
>>>     drm/i915/perf: move pollin setup to non hw specific code
>>>     drm/i915/perf: only append status when data is available
>>>     drm/i915/perf: introduce a versioning of the i915-perf uapi
>>>     drm/i915/perf: add new open param to configure polling of OA buffer
>>>     drm/i915: handle interrupts from the OA unit
>>>     drm/i915/perf: add interrupt enabling parameter
>>>     drm/i915/perf: add flushing ioctl
>>>     drm/i915/perf: bump i915-perf revision
>>>
>>>    drivers/gpu/drm/i915/i915_drv.c         |   3 +
>>>    drivers/gpu/drm/i915/i915_drv.h         |  59 +++-
>>>    drivers/gpu/drm/i915/i915_irq.c         |  39 ++-
>>>    drivers/gpu/drm/i915/i915_perf.c        | 403 ++++++++++++++----------
>>>    drivers/gpu/drm/i915/i915_reg.h         |   7 +
>>>    drivers/gpu/drm/i915/intel_ringbuffer.c |   2 +
>>>    include/uapi/drm/i915_drm.h             |  61 ++++
>>>    7 files changed, 390 insertions(+), 184 deletions(-)
>>>
>>> --
>>> 2.20.1
>>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Lionel Landwerlin April 26, 2019, 8:20 a.m. UTC | #4
FYI,

MDAPI got tired of waiting for this to land upstream : 
https://github.com/intel/metrics-discovery/commit/7b6399d5d5e5ef5fcc018a48853b46d0803da441

Apart from squashing the last commit, any other change needed?

Thanks,

-Lionel

On 03/04/2019 00:36, Lionel Landwerlin wrote:
> On 02/04/2019 14:49, Joonas Lahtinen wrote:
>> Quoting Lionel Landwerlin (2019-03-25 12:34:44)
>>> Ping?
>> The last patch should be squashed, I think we want to minimize the
>> amount of versions. Or do you intend to backport only portion of
>> the series somewhere?
>
>
> No backport intended :)
>
>
>>
>> Can you link to the userspace side changes?
>
>
> https://github.com/rib/gputop/pull/198
>
>
>>
>> Regards, Joonas
>>
>>> On 26/02/2019 14:29, Lionel Landwerlin wrote:
>>>> Hi all,
>>>>
>>>> This third iteration adds an i915 perf revision number through
>>>> getparam so that application can more easily find out what feature of
>>>> i915-perf are available.
>>>>
>>>> The patches containing uAPI updates have been updated to indicate what
>>>> version is required to those changes to be available.
>>>>
>>>> Cheers,
>>>>
>>>> Lionel Landwerlin (9):
>>>>     drm/i915/perf: rework aging tail workaround
>>>>     drm/i915/perf: move pollin setup to non hw specific code
>>>>     drm/i915/perf: only append status when data is available
>>>>     drm/i915/perf: introduce a versioning of the i915-perf uapi
>>>>     drm/i915/perf: add new open param to configure polling of OA 
>>>> buffer
>>>>     drm/i915: handle interrupts from the OA unit
>>>>     drm/i915/perf: add interrupt enabling parameter
>>>>     drm/i915/perf: add flushing ioctl
>>>>     drm/i915/perf: bump i915-perf revision
>>>>
>>>>    drivers/gpu/drm/i915/i915_drv.c         |   3 +
>>>>    drivers/gpu/drm/i915/i915_drv.h         |  59 +++-
>>>>    drivers/gpu/drm/i915/i915_irq.c         |  39 ++-
>>>>    drivers/gpu/drm/i915/i915_perf.c        | 403 
>>>> ++++++++++++++----------
>>>>    drivers/gpu/drm/i915/i915_reg.h         |   7 +
>>>>    drivers/gpu/drm/i915/intel_ringbuffer.c |   2 +
>>>>    include/uapi/drm/i915_drm.h             |  61 ++++
>>>>    7 files changed, 390 insertions(+), 184 deletions(-)
>>>>
>>>> -- 
>>>> 2.20.1
>>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx