From patchwork Wed Mar 6 01:26:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas De Marchi X-Patchwork-Id: 10840289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A30C917E0 for ; Wed, 6 Mar 2019 01:26:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 912042CFEF for ; Wed, 6 Mar 2019 01:26:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 850442CFF7; Wed, 6 Mar 2019 01:26:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 50BEE2CFEF for ; Wed, 6 Mar 2019 01:26:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E5F66E03E; Wed, 6 Mar 2019 01:26:53 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B88D6E034 for ; Wed, 6 Mar 2019 01:26:51 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 17:26:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,445,1544515200"; d="scan'208";a="149616606" Received: from ldmartin-desk.jf.intel.com ([10.24.9.41]) by fmsmga004.fm.intel.com with ESMTP; 05 Mar 2019 17:26:49 -0800 From: Lucas De Marchi To: intel-gfx@lists.freedesktop.org Date: Tue, 5 Mar 2019 17:26:31 -0800 Message-Id: <20190306012636.18619-1-lucas.demarchi@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 0/5] drm/i915/icl: split pll functions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This should achieve a similar goal as in https://patchwork.freedesktop.org/patch/287567/?series=57116&rev=1, decoupling the PLL ids from the type. I actually prefer the other implementation in which we can use the pll_info struct to store the info about the pll rather than spreading that across several functions. It's not a strong preference though. Anyway, this should be sufficient to allow future platforms to share common functions. Warning: this is only build-tested... I want to confirm if this is the way to go. Lucas De Marchi (5): drm/i915/icl: split combo and mg pll enable drm/i915/icl: use a function pointer for pll_write when enabling drm/i915/icl: split combo and mg pll disable drm/i915/icl: split combo and tbt pll funcs drm/i915/icl: remove intel_dpll_is_combophy() drivers/gpu/drm/i915/intel_display.c | 3 - drivers/gpu/drm/i915/intel_dpll_mgr.c | 127 ++++++++++++++++++-------- 2 files changed, 87 insertions(+), 43 deletions(-)