mbox series

[v2,0/7] drm/i915: Finish the GAMMA_LUT stuff

Message ID 20190401200231.2333-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Finish the GAMMA_LUT stuff | expand

Message

Ville Syrjälä April 1, 2019, 8:02 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Rebased due to Uma's EXT_GC_MAX fix, and I added Matt's proposed
behavioural change (expose 1024 entry LUTs in split gamma mode
and just discard half the entries) as an extra patch on top.

Everything is reviewed except patches 2 and 7.

Ville Syrjälä (7):
  drm/i915: Extract ilk_lut_10()
  drm/i915: Don't use split gamma when we don't have to
  drm/i915: Implement split/10bit gamma for ivb/hsw
  drm/i915: Add 10bit LUT for ilk/snb
  drm/i915: Add "10.6" LUT mode for i965+
  drm/i915: Expose the legacy LUT via the GAMMA_LUT/GAMMA_LUT_SIZE props
    on gen2/3
  drm/i915: Expose full 1024 LUT entries on ivb+

 drivers/gpu/drm/i915/i915_pci.c    |  23 +-
 drivers/gpu/drm/i915/i915_reg.h    |  15 ++
 drivers/gpu/drm/i915/intel_color.c | 375 ++++++++++++++++++++---------
 3 files changed, 292 insertions(+), 121 deletions(-)

Comments

Shankar, Uma April 3, 2019, 1:57 p.m. UTC | #1
>-----Original Message-----
>From: Ville Syrjala [mailto:ville.syrjala@linux.intel.com]
>Sent: Tuesday, April 2, 2019 1:32 AM
>To: intel-gfx@lists.freedesktop.org
>Cc: Shankar, Uma <uma.shankar@intel.com>; Roper, Matthew D
><matthew.d.roper@intel.com>
>Subject: [PATCH v2 0/7] drm/i915: Finish the GAMMA_LUT stuff
>
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>Rebased due to Uma's EXT_GC_MAX fix, and I added Matt's proposed behavioural
>change (expose 1024 entry LUTs in split gamma mode and just discard half the
>entries) as an extra patch on top.
>
>Everything is reviewed except patches 2 and 7.

Reviewed the whole series and it looks perfect.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

>
>Ville Syrjälä (7):
>  drm/i915: Extract ilk_lut_10()
>  drm/i915: Don't use split gamma when we don't have to
>  drm/i915: Implement split/10bit gamma for ivb/hsw
>  drm/i915: Add 10bit LUT for ilk/snb
>  drm/i915: Add "10.6" LUT mode for i965+
>  drm/i915: Expose the legacy LUT via the GAMMA_LUT/GAMMA_LUT_SIZE props
>    on gen2/3
>  drm/i915: Expose full 1024 LUT entries on ivb+
>
> drivers/gpu/drm/i915/i915_pci.c    |  23 +-
> drivers/gpu/drm/i915/i915_reg.h    |  15 ++
> drivers/gpu/drm/i915/intel_color.c | 375 ++++++++++++++++++++---------
> 3 files changed, 292 insertions(+), 121 deletions(-)
>
>--
>2.19.2
Ville Syrjälä April 3, 2019, 7:35 p.m. UTC | #2
On Wed, Apr 03, 2019 at 01:57:00PM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Ville Syrjala [mailto:ville.syrjala@linux.intel.com]
> >Sent: Tuesday, April 2, 2019 1:32 AM
> >To: intel-gfx@lists.freedesktop.org
> >Cc: Shankar, Uma <uma.shankar@intel.com>; Roper, Matthew D
> ><matthew.d.roper@intel.com>
> >Subject: [PATCH v2 0/7] drm/i915: Finish the GAMMA_LUT stuff
> >
> >From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> >Rebased due to Uma's EXT_GC_MAX fix, and I added Matt's proposed behavioural
> >change (expose 1024 entry LUTs in split gamma mode and just discard half the
> >entries) as an extra patch on top.
> >
> >Everything is reviewed except patches 2 and 7.
> 
> Reviewed the whole series and it looks perfect.
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>

Cool. Thanks for reading through it. Now pushed to dinq.

> 
> >
> >Ville Syrjälä (7):
> >  drm/i915: Extract ilk_lut_10()
> >  drm/i915: Don't use split gamma when we don't have to
> >  drm/i915: Implement split/10bit gamma for ivb/hsw
> >  drm/i915: Add 10bit LUT for ilk/snb
> >  drm/i915: Add "10.6" LUT mode for i965+
> >  drm/i915: Expose the legacy LUT via the GAMMA_LUT/GAMMA_LUT_SIZE props
> >    on gen2/3
> >  drm/i915: Expose full 1024 LUT entries on ivb+
> >
> > drivers/gpu/drm/i915/i915_pci.c    |  23 +-
> > drivers/gpu/drm/i915/i915_reg.h    |  15 ++
> > drivers/gpu/drm/i915/intel_color.c | 375 ++++++++++++++++++++---------
> > 3 files changed, 292 insertions(+), 121 deletions(-)
> >
> >--
> >2.19.2
>