| Message ID | 20190614151731.17608-1-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Implicit dev_priv removal and GT compartmentalization | expand |
On Fri, Jun 14, 2019 at 04:17:00PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Most of v3 review feedback plus more of: > """" > Also, while nosing around in the code I have spotted more opportunities to > compartmentalize, either using intel_gt, or some other object as appropriate. > """ > > This time even smoke tested. Oh, I forgot to tell you that even your v1 version was smoke tested and it was working for my cases :) > > Tvrtko Ursulin (31): > drm/i915: Convert intel_vgt_(de)balloon to uncore > drm/i915: Introduce struct intel_gt as replacement for anonymous > i915->gt > drm/i915: Move intel_gt initialization to a separate file > drm/i915: Store some backpointers in struct intel_gt > drm/i915: Make i915_check_and_clear_faults take intel_gt > drm/i915: Convert i915_gem_init_swizzling to intel_gt > drm/i915: Convert init_unused_rings to intel_gt > drm/i915: Convert gt workarounds to intel_gt > drm/i915: Store backpointer to intel_gt in the engine > drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt > drm/i915: Convert i915_ppgtt_init_hw to intel_gt > drm/i915: Consolidate some open coded mmio rmw > drm/i915: Convert i915_gem_init_hw to intel_gt > drm/i915: Move intel_engines_resume into common init > drm/i915: Stop using I915_READ/WRITE in intel_wopcm_init_hw > drm/i915: Compartmentalize i915_ggtt_probe_hw > drm/i915: Compartmentalize i915_ggtt_init_hw > drm/i915: Make ggtt invalidation work on ggtt > drm/i915: Store intel_gt backpointer in vm > drm/i915: Compartmentalize i915_gem_suspend/restore_gtt_mappings > drm/i915: Convert i915_gem_flush_ggtt_writes to intel_gt > drm/i915: Move i915_gem_chipset_flush to intel_gt > drm/i915: Compartmentalize timeline_init/park/fini > drm/i915: Compartmentalize i915_ggtt_cleanup_hw > drm/i915: Compartmentalize i915_gem_init_ggtt > drm/i915: Store ggtt pointer in intel_gt > drm/i915: Compartmentalize ring buffer creation > drm/i915: Save trip via top-level i915 in a few more places > drm/i915: Make timelines gt centric > drm/i915: Rename i915_timeline to intel_timeline and move under gt > drm/i915: Eliminate dual personality of i915_scratch_offset > > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gpu/drm/i915/Makefile.header-test | 1 - > drivers/gpu/drm/i915/gem/i915_gem_context.c | 10 +- > .../gpu/drm/i915/gem/i915_gem_context_types.h | 4 +- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 +- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 5 +- > drivers/gpu/drm/i915/gem/i915_gem_phys.c | 3 +- > drivers/gpu/drm/i915/gem/i915_gem_pm.c | 2 +- > .../gpu/drm/i915/gem/selftests/huge_pages.c | 7 +- > .../drm/i915/gem/selftests/i915_gem_context.c | 3 +- > .../drm/i915/gem/selftests/i915_gem_mman.c | 3 +- > drivers/gpu/drm/i915/gt/intel_engine.h | 4 +- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 33 +- > drivers/gpu/drm/i915/gt/intel_engine_types.h | 8 +- > drivers/gpu/drm/i915/gt/intel_gt.c | 195 ++++++++++ > drivers/gpu/drm/i915/gt/intel_gt.h | 35 ++ > drivers/gpu/drm/i915/gt/intel_gt_types.h | 61 +++ > drivers/gpu/drm/i915/gt/intel_lrc.c | 32 +- > drivers/gpu/drm/i915/gt/intel_mocs.c | 52 ++- > drivers/gpu/drm/i915/gt/intel_mocs.h | 3 +- > drivers/gpu/drm/i915/gt/intel_reset.c | 128 +----- > drivers/gpu/drm/i915/gt/intel_reset.h | 2 - > drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 68 ++-- > .../{i915_timeline.c => gt/intel_timeline.c} | 204 +++++----- > .../{i915_timeline.h => gt/intel_timeline.h} | 71 ++-- > .../intel_timeline_types.h} | 8 +- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +- > drivers/gpu/drm/i915/gt/intel_workarounds.h | 6 +- > drivers/gpu/drm/i915/gt/mock_engine.c | 18 +- > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 20 +- > .../selftest_timeline.c} | 124 +++--- > .../gpu/drm/i915/gt/selftest_workarounds.c | 7 +- > .../i915/{ => gt}/selftests/mock_timeline.c | 8 +- > .../i915/{ => gt}/selftests/mock_timeline.h | 6 +- > drivers/gpu/drm/i915/i915_drv.c | 9 +- > drivers/gpu/drm/i915/i915_drv.h | 52 +-- > drivers/gpu/drm/i915/i915_gem.c | 227 +++++------ > drivers/gpu/drm/i915/i915_gem_fence_reg.c | 37 ++ > drivers/gpu/drm/i915/i915_gem_fence_reg.h | 3 + > drivers/gpu/drm/i915/i915_gem_gtt.c | 367 +++++++++++------- > drivers/gpu/drm/i915/i915_gem_gtt.h | 10 +- > drivers/gpu/drm/i915/i915_gem_render_state.c | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 +- > drivers/gpu/drm/i915/i915_request.c | 16 +- > drivers/gpu/drm/i915/i915_request.h | 8 +- > drivers/gpu/drm/i915/i915_vgpu.c | 24 +- > drivers/gpu/drm/i915/i915_vgpu.h | 4 +- > drivers/gpu/drm/i915/i915_vma.c | 3 +- > drivers/gpu/drm/i915/intel_wopcm.c | 31 +- > drivers/gpu/drm/i915/intel_wopcm.h | 4 +- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > .../drm/i915/selftests/i915_live_selftests.h | 2 +- > .../drm/i915/selftests/i915_mock_selftests.h | 2 +- > drivers/gpu/drm/i915/selftests/i915_request.c | 10 +- > drivers/gpu/drm/i915/selftests/igt_spinner.c | 7 +- > drivers/gpu/drm/i915/selftests/igt_spinner.h | 3 + > .../gpu/drm/i915/selftests/mock_gem_device.c | 11 +- > 57 files changed, 1143 insertions(+), 846 deletions(-) > create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.c > create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.h > create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_types.h > rename drivers/gpu/drm/i915/{i915_timeline.c => gt/intel_timeline.c} (72%) > rename drivers/gpu/drm/i915/{i915_timeline.h => gt/intel_timeline.h} (53%) > rename drivers/gpu/drm/i915/{i915_timeline_types.h => gt/intel_timeline_types.h} (92%) > rename drivers/gpu/drm/i915/{selftests/i915_timeline.c => gt/selftest_timeline.c} (86%) > rename drivers/gpu/drm/i915/{ => gt}/selftests/mock_timeline.c (70%) > rename drivers/gpu/drm/i915/{ => gt}/selftests/mock_timeline.h (53%) > > -- > 2.20.1 >
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Most of v3 review feedback plus more of: """" Also, while nosing around in the code I have spotted more opportunities to compartmentalize, either using intel_gt, or some other object as appropriate. """ This time even smoke tested. Tvrtko Ursulin (31): drm/i915: Convert intel_vgt_(de)balloon to uncore drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gt drm/i915: Move intel_gt initialization to a separate file drm/i915: Store some backpointers in struct intel_gt drm/i915: Make i915_check_and_clear_faults take intel_gt drm/i915: Convert i915_gem_init_swizzling to intel_gt drm/i915: Convert init_unused_rings to intel_gt drm/i915: Convert gt workarounds to intel_gt drm/i915: Store backpointer to intel_gt in the engine drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt drm/i915: Convert i915_ppgtt_init_hw to intel_gt drm/i915: Consolidate some open coded mmio rmw drm/i915: Convert i915_gem_init_hw to intel_gt drm/i915: Move intel_engines_resume into common init drm/i915: Stop using I915_READ/WRITE in intel_wopcm_init_hw drm/i915: Compartmentalize i915_ggtt_probe_hw drm/i915: Compartmentalize i915_ggtt_init_hw drm/i915: Make ggtt invalidation work on ggtt drm/i915: Store intel_gt backpointer in vm drm/i915: Compartmentalize i915_gem_suspend/restore_gtt_mappings drm/i915: Convert i915_gem_flush_ggtt_writes to intel_gt drm/i915: Move i915_gem_chipset_flush to intel_gt drm/i915: Compartmentalize timeline_init/park/fini drm/i915: Compartmentalize i915_ggtt_cleanup_hw drm/i915: Compartmentalize i915_gem_init_ggtt drm/i915: Store ggtt pointer in intel_gt drm/i915: Compartmentalize ring buffer creation drm/i915: Save trip via top-level i915 in a few more places drm/i915: Make timelines gt centric drm/i915: Rename i915_timeline to intel_timeline and move under gt drm/i915: Eliminate dual personality of i915_scratch_offset drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/Makefile.header-test | 1 - drivers/gpu/drm/i915/gem/i915_gem_context.c | 10 +- .../gpu/drm/i915/gem/i915_gem_context_types.h | 4 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 +- drivers/gpu/drm/i915/gem/i915_gem_object.c | 5 +- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 2 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 7 +- .../drm/i915/gem/selftests/i915_gem_context.c | 3 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine.h | 4 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 33 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 8 +- drivers/gpu/drm/i915/gt/intel_gt.c | 195 ++++++++++ drivers/gpu/drm/i915/gt/intel_gt.h | 35 ++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 61 +++ drivers/gpu/drm/i915/gt/intel_lrc.c | 32 +- drivers/gpu/drm/i915/gt/intel_mocs.c | 52 ++- drivers/gpu/drm/i915/gt/intel_mocs.h | 3 +- drivers/gpu/drm/i915/gt/intel_reset.c | 128 +----- drivers/gpu/drm/i915/gt/intel_reset.h | 2 - drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 68 ++-- .../{i915_timeline.c => gt/intel_timeline.c} | 204 +++++----- .../{i915_timeline.h => gt/intel_timeline.h} | 71 ++-- .../intel_timeline_types.h} | 8 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 +- drivers/gpu/drm/i915/gt/intel_workarounds.h | 6 +- drivers/gpu/drm/i915/gt/mock_engine.c | 18 +- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 20 +- .../selftest_timeline.c} | 124 +++--- .../gpu/drm/i915/gt/selftest_workarounds.c | 7 +- .../i915/{ => gt}/selftests/mock_timeline.c | 8 +- .../i915/{ => gt}/selftests/mock_timeline.h | 6 +- drivers/gpu/drm/i915/i915_drv.c | 9 +- drivers/gpu/drm/i915/i915_drv.h | 52 +-- drivers/gpu/drm/i915/i915_gem.c | 227 +++++------ drivers/gpu/drm/i915/i915_gem_fence_reg.c | 37 ++ drivers/gpu/drm/i915/i915_gem_fence_reg.h | 3 + drivers/gpu/drm/i915/i915_gem_gtt.c | 367 +++++++++++------- drivers/gpu/drm/i915/i915_gem_gtt.h | 10 +- drivers/gpu/drm/i915/i915_gem_render_state.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 4 +- drivers/gpu/drm/i915/i915_request.c | 16 +- drivers/gpu/drm/i915/i915_request.h | 8 +- drivers/gpu/drm/i915/i915_vgpu.c | 24 +- drivers/gpu/drm/i915/i915_vgpu.h | 4 +- drivers/gpu/drm/i915/i915_vma.c | 3 +- drivers/gpu/drm/i915/intel_wopcm.c | 31 +- drivers/gpu/drm/i915/intel_wopcm.h | 4 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- .../drm/i915/selftests/i915_live_selftests.h | 2 +- .../drm/i915/selftests/i915_mock_selftests.h | 2 +- drivers/gpu/drm/i915/selftests/i915_request.c | 10 +- drivers/gpu/drm/i915/selftests/igt_spinner.c | 7 +- drivers/gpu/drm/i915/selftests/igt_spinner.h | 3 + .../gpu/drm/i915/selftests/mock_gem_device.c | 11 +- 57 files changed, 1143 insertions(+), 846 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gt.h create mode 100644 drivers/gpu/drm/i915/gt/intel_gt_types.h rename drivers/gpu/drm/i915/{i915_timeline.c => gt/intel_timeline.c} (72%) rename drivers/gpu/drm/i915/{i915_timeline.h => gt/intel_timeline.h} (53%) rename drivers/gpu/drm/i915/{i915_timeline_types.h => gt/intel_timeline_types.h} (92%) rename drivers/gpu/drm/i915/{selftests/i915_timeline.c => gt/selftest_timeline.c} (86%) rename drivers/gpu/drm/i915/{ => gt}/selftests/mock_timeline.c (70%) rename drivers/gpu/drm/i915/{ => gt}/selftests/mock_timeline.h (53%)