mbox series

[v4,0/5] EHL port programming

Message ID 20190703233736.5816-1-matthew.d.roper@intel.com (mailing list archive)
Headers show
Series EHL port programming | expand

Message

Matt Roper July 3, 2019, 11:37 p.m. UTC
Previous series revisions were here:
  v3: https://lists.freedesktop.org/archives/intel-gfx/2019-June/203287.html
  v1/2: https://lists.freedesktop.org/archives/intel-gfx/2019-June/202776.html

Only two patches from the previous series have yet to land; this
revision splits up the first of those into four separate patches to ease
the review process a bit.

This revision also updates a handful of combo PHY registers to use the
new namespace that were missed in the previous iteration and caught by
Jose.

As before, this series doesn't even try to touch the TC code (aside from
the type check function).  EHL has no combo PHYs, so it's probably
better to wait until TGL support lands in the tree before tackling that
to avoid causing unnecessary conflicts.  Even patch #4 of this series
may want to wait until TGL lands before being merged.

Cc: José Roberto de Souza <jose.souza@intel.com>

Matt Roper (5):
  drm/i915/gen11: Start distinguishing 'phy' from 'port'
  drm/i915/gen11: Program DPCLKA_CFGCR0_ICL according to PHY
  drm/i915/gen11: Convert combo PHY logic to use new 'enum phy'
    namespace
  drm/i915: Transition port type checks to phy checks
  drm/i915/ehl: Enable DDI-D

 drivers/gpu/drm/i915/display/icl_dsi.c        | 136 ++++++++---------
 drivers/gpu/drm/i915/display/intel_bios.c     |   4 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    | 143 +++++++++---------
 .../gpu/drm/i915/display/intel_combo_phy.h    |   3 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 130 +++++++++-------
 drivers/gpu/drm/i915/display/intel_display.c  |  39 +++--
 drivers/gpu/drm/i915/display/intel_display.h  |  20 +++
 .../drm/i915/display/intel_display_power.c    |  20 +--
 drivers/gpu/drm/i915/display/intel_dp.c       |  15 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  11 +-
 drivers/gpu/drm/i915/display/intel_dsi.h      |  12 +-
 drivers/gpu/drm/i915/i915_reg.h               |  86 ++++++-----
 drivers/gpu/drm/i915/intel_drv.h              |   4 +-
 13 files changed, 348 insertions(+), 275 deletions(-)

Comments

Souza, Jose July 3, 2019, 11:56 p.m. UTC | #1
On Wed, 2019-07-03 at 16:37 -0700, Matt Roper wrote:
> Previous series revisions were here:
>   v3: 
> https://lists.freedesktop.org/archives/intel-gfx/2019-June/203287.html
>   v1/2: 
> https://lists.freedesktop.org/archives/intel-gfx/2019-June/202776.html
> 
> Only two patches from the previous series have yet to land; this
> revision splits up the first of those into four separate patches to
> ease
> the review process a bit.
> 
> This revision also updates a handful of combo PHY registers to use
> the
> new namespace that were missed in the previous iteration and caught
> by
> Jose.
> 
> As before, this series doesn't even try to touch the TC code (aside
> from
> the type check function).  EHL has no combo PHYs, so it's probably

EHL has no TC combo phys

> better to wait until TGL support lands in the tree before tackling
> that
> to avoid causing unnecessary conflicts.  Even patch #4 of this series
> may want to wait until TGL lands before being merged.
> 

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Should it wait? Thoughts?

> Cc: José Roberto de Souza <jose.souza@intel.com>
> 
> Matt Roper (5):
>   drm/i915/gen11: Start distinguishing 'phy' from 'port'
>   drm/i915/gen11: Program DPCLKA_CFGCR0_ICL according to PHY
>   drm/i915/gen11: Convert combo PHY logic to use new 'enum phy'
>     namespace
>   drm/i915: Transition port type checks to phy checks
>   drm/i915/ehl: Enable DDI-D
> 
>  drivers/gpu/drm/i915/display/icl_dsi.c        | 136 ++++++++------
> ---
>  drivers/gpu/drm/i915/display/intel_bios.c     |   4 +-
>  .../gpu/drm/i915/display/intel_combo_phy.c    | 143 +++++++++-------
> --
>  .../gpu/drm/i915/display/intel_combo_phy.h    |   3 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 130 +++++++++-------
>  drivers/gpu/drm/i915/display/intel_display.c  |  39 +++--
>  drivers/gpu/drm/i915/display/intel_display.h  |  20 +++
>  .../drm/i915/display/intel_display_power.c    |  20 +--
>  drivers/gpu/drm/i915/display/intel_dp.c       |  15 +-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  11 +-
>  drivers/gpu/drm/i915/display/intel_dsi.h      |  12 +-
>  drivers/gpu/drm/i915/i915_reg.h               |  86 ++++++-----
>  drivers/gpu/drm/i915/intel_drv.h              |   4 +-
>  13 files changed, 348 insertions(+), 275 deletions(-)
>