From patchwork Thu Aug 8 01:44:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniele Ceraolo Spurio X-Patchwork-Id: 11083065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3F5C3112C for ; Thu, 8 Aug 2019 01:44:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C29828694 for ; Thu, 8 Aug 2019 01:44:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B1B228AE0; Thu, 8 Aug 2019 01:44:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B038C28694 for ; Thu, 8 Aug 2019 01:44:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C73DC6E0A2; Thu, 8 Aug 2019 01:44:43 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E4556E0A2 for ; Thu, 8 Aug 2019 01:44:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 18:44:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,358,1559545200"; d="scan'208";a="165538115" Received: from dceraolo-linux.fm.intel.com ([10.1.27.145]) by orsmga007.jf.intel.com with ESMTP; 07 Aug 2019 18:44:41 -0700 From: Daniele Ceraolo Spurio To: intel-gfx@lists.freedesktop.org Date: Wed, 7 Aug 2019 18:44:20 -0700 Message-Id: <20190808014423.20377-1-daniele.ceraolospurio@intel.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Subject: [Intel-gfx] [RFC 0/3] Display uncore X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Lucas De Marchi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP I've been trying to identify MMIO ranges to clearly define what belongs to display_uncore to do a check on access, but there are lots of exceptions and differences across gens (with a few more coming with TGL), so I don't think that's a viable way. The alternative option implemented here is to differentiate the register by type, which should ensure we never mix them up, but at the cost of a more complex transition. Thoughts? I'm very open to (and I actually hope for) better ideas. Cc: Ville Syrjälä Cc: Chris Wilson Cc: Jani Nikula Cc: Lucas De Marchi Daniele Ceraolo Spurio (3): drm/i915: split out uncore_mmio_debug drm/i915: introduce display_uncore drm/i915: convert a couple of registers to _DE_MMIO .../gpu/drm/i915/display/intel_display_reg.h | 66 ++++++++++++ drivers/gpu/drm/i915/display/intel_hdmi.c | 32 +++--- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 20 +++- drivers/gpu/drm/i915/i915_drv.h | 32 ++++++ drivers/gpu/drm/i915/i915_reg.h | 44 -------- drivers/gpu/drm/i915/intel_uncore.c | 100 +++++++++++++----- drivers/gpu/drm/i915/intel_uncore.h | 18 ++-- 8 files changed, 215 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_reg.h