mbox series

[v2,0/9] drm/i915: Gamma cleanups

Message ID 20200303173313.28117-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Gamma cleanups | expand

Message

Ville Syrjala March 3, 2020, 5:33 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Remainder of my earlier gamma cleanups, rebased due to
hw vs. uapi split and intel_de_{read,write}().

Ville Syrjälä (9):
  drm/i915: Polish CHV CGM CSC loading
  drm/i915: Clean up i9xx_load_luts_internal()
  drm/i915: Split i9xx_read_lut_8() to gmch vs. ilk variants
  drm/i915: s/blob_data/lut/
  drm/i915: s/chv_read_cgm_lut/chv_read_cgm_gamma/
  drm/i915: Clean up integer types in color code
  drm/i915: Refactor LUT read functions
  drm/i915: Fix readout of PIPEGCMAX
  drm/i915: Pass the crtc to the low level read_lut() funcs

 drivers/gpu/drm/i915/display/intel_color.c | 407 ++++++++++++---------
 drivers/gpu/drm/i915/i915_reg.h            |   1 -
 2 files changed, 225 insertions(+), 183 deletions(-)

Comments

Sharma, Swati2 March 6, 2020, 3:40 p.m. UTC | #1
On 03-Mar-20 11:03 PM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Remainder of my earlier gamma cleanups, rebased due to
> hw vs. uapi split and intel_de_{read,write}().

I didn't get patch#8. Everything looks good to me.
There is BAT failure https://patchwork.freedesktop.org/series/69136/
Please check that.

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
> 
> Ville Syrjälä (9):
>    drm/i915: Polish CHV CGM CSC loading
>    drm/i915: Clean up i9xx_load_luts_internal()
>    drm/i915: Split i9xx_read_lut_8() to gmch vs. ilk variants
>    drm/i915: s/blob_data/lut/
>    drm/i915: s/chv_read_cgm_lut/chv_read_cgm_gamma/
>    drm/i915: Clean up integer types in color code
>    drm/i915: Refactor LUT read functions
>    drm/i915: Fix readout of PIPEGCMAX
>    drm/i915: Pass the crtc to the low level read_lut() funcs
> 
>   drivers/gpu/drm/i915/display/intel_color.c | 407 ++++++++++++---------
>   drivers/gpu/drm/i915/i915_reg.h            |   1 -
>   2 files changed, 225 insertions(+), 183 deletions(-)
>
Ville Syrjala March 9, 2020, 8:26 p.m. UTC | #2
On Fri, Mar 06, 2020 at 09:10:56PM +0530, Sharma, Swati2 wrote:
> 
> 
> On 03-Mar-20 11:03 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Remainder of my earlier gamma cleanups, rebased due to
> > hw vs. uapi split and intel_de_{read,write}().
> 
> I didn't get patch#8. Everything looks good to me.
> There is BAT failure https://patchwork.freedesktop.org/series/69136/
> Please check that.
> 
> Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

Series pushed to dinq. Thanks for the review.

> > 
> > Ville Syrjälä (9):
> >    drm/i915: Polish CHV CGM CSC loading
> >    drm/i915: Clean up i9xx_load_luts_internal()
> >    drm/i915: Split i9xx_read_lut_8() to gmch vs. ilk variants
> >    drm/i915: s/blob_data/lut/
> >    drm/i915: s/chv_read_cgm_lut/chv_read_cgm_gamma/
> >    drm/i915: Clean up integer types in color code
> >    drm/i915: Refactor LUT read functions
> >    drm/i915: Fix readout of PIPEGCMAX
> >    drm/i915: Pass the crtc to the low level read_lut() funcs
> > 
> >   drivers/gpu/drm/i915/display/intel_color.c | 407 ++++++++++++---------
> >   drivers/gpu/drm/i915/i915_reg.h            |   1 -
> >   2 files changed, 225 insertions(+), 183 deletions(-)
> > 
> 
> -- 
> ~Swati Sharma