[0/3] Tigerlake workaround updates

Message

Matt Roper April 14, 2020, 9:11 p.m. UTC

A recent bspec update updated Wa_1409767108 and added Wa_14010477008 to
the TGL list.  Also, register 0xFDC details are missing from the gen12
section of the bspec, but we have offline confirmation from the hardware
folks that this register does indeed still exist and behave as it did on
gen11, so we should still use it to steer multicast registers when
applying workarounds.

Matt Roper (3):
  drm/i915/tgl: Extend Wa_1409767108:tgl to B0 stepping
  drm/i915/tgl: Add Wa_14010477008:tgl
  drm/i915/tgl: Initialize multicast register steering for workarounds

 .../gpu/drm/i915/display/intel_display_power.c  |  2 +-
 drivers/gpu/drm/i915/display/intel_sprite.c     | 17 ++++++++++++-----
 drivers/gpu/drm/i915/gt/intel_workarounds.c     |  2 ++
 drivers/gpu/drm/i915/i915_drv.h                 |  2 ++
 4 files changed, 17 insertions(+), 6 deletions(-)

Comments

Matt Roper April 15, 2020, 10:33 p.m. UTC | #1

On Wed, Apr 15, 2020 at 09:47:21PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: Tigerlake workaround updates
> URL   : https://patchwork.freedesktop.org/series/75944/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8298_full -> Patchwork_17302_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.

Switched the order of patch 1 and 2 as suggested by Jose and applied to
dinq.  Thanks Jose for the reviews.


Matt

> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_17302_full:
> 
> ### IGT changes ###
> 
> #### Suppressed ####
> 
>   The following results come from untrusted machines, tests, or statuses.
>   They do not affect the overall result.
> 
>   * {igt@gem_exec_parallel@engines@fds}:
>     - shard-skl:          [PASS][1] -> [FAIL][2] +1 similar issue
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl7/igt@gem_exec_parallel@[e-mail]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl8/igt@gem_exec_parallel@[e-mail]
> 
>   
> New tests
> ---------
> 
>   New tests have been introduced between CI_DRM_8298_full and Patchwork_17302_full:
> 
> ### New IGT tests (27) ###
> 
>   * igt@kms_plane_cursor@pipe-a-overlay-size-128:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.66, 3.66] s
> 
>   * igt@kms_plane_cursor@pipe-a-overlay-size-256:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.64, 3.64] s
> 
>   * igt@kms_plane_cursor@pipe-a-overlay-size-64:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.65, 3.65] s
> 
>   * igt@kms_plane_cursor@pipe-a-primary-size-128:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.64, 3.49] s
> 
>   * igt@kms_plane_cursor@pipe-a-primary-size-256:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.64, 3.47] s
> 
>   * igt@kms_plane_cursor@pipe-a-primary-size-64:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.63, 3.34] s
> 
>   * igt@kms_plane_cursor@pipe-a-viewport-size-128:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.65, 3.69] s
> 
>   * igt@kms_plane_cursor@pipe-a-viewport-size-256:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.64, 3.69] s
> 
>   * igt@kms_plane_cursor@pipe-a-viewport-size-64:
>     - Statuses : 8 pass(s)
>     - Exec time: [1.64, 3.66] s
> 
>   * igt@kms_plane_cursor@pipe-b-overlay-size-128:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.21, 4.86] s
> 
>   * igt@kms_plane_cursor@pipe-b-overlay-size-256:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.23, 4.91] s
> 
>   * igt@kms_plane_cursor@pipe-b-overlay-size-64:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.23, 4.82] s
> 
>   * igt@kms_plane_cursor@pipe-b-primary-size-128:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.21, 4.65] s
> 
>   * igt@kms_plane_cursor@pipe-b-primary-size-256:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.21, 4.63] s
> 
>   * igt@kms_plane_cursor@pipe-b-primary-size-64:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.20, 4.65] s
> 
>   * igt@kms_plane_cursor@pipe-b-viewport-size-128:
>     - Statuses :
>     - Exec time: [None] s
> 
>   * igt@kms_plane_cursor@pipe-b-viewport-size-256:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.22, 4.86] s
> 
>   * igt@kms_plane_cursor@pipe-b-viewport-size-64:
>     - Statuses : 8 pass(s)
>     - Exec time: [2.23, 4.91] s
> 
>   * igt@kms_plane_cursor@pipe-c-overlay-size-128:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.79] s
> 
>   * igt@kms_plane_cursor@pipe-c-overlay-size-256:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.88] s
> 
>   * igt@kms_plane_cursor@pipe-c-overlay-size-64:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.85] s
> 
>   * igt@kms_plane_cursor@pipe-c-primary-size-128:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.66] s
> 
>   * igt@kms_plane_cursor@pipe-c-primary-size-256:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.74] s
> 
>   * igt@kms_plane_cursor@pipe-c-primary-size-64:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.56] s
> 
>   * igt@kms_plane_cursor@pipe-c-viewport-size-128:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.85] s
> 
>   * igt@kms_plane_cursor@pipe-c-viewport-size-256:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.89] s
> 
>   * igt@kms_plane_cursor@pipe-c-viewport-size-64:
>     - Statuses : 7 pass(s) 1 skip(s)
>     - Exec time: [0.0, 4.86] s
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_17302_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_ctx_exec@basic-norecovery:
>     - shard-skl:          [PASS][3] -> [SKIP][4] ([fdo#109271]) +4 similar issues
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl7/igt@[e-mail]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl8/igt@[e-mail]
> 
>   * igt@gem_exec_create@madvise:
>     - shard-hsw:          [PASS][5] -> [INCOMPLETE][6] ([i915#61]) +1 similar issue
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-hsw1/igt@[e-mail]
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-hsw4/igt@[e-mail]
> 
>   * igt@gem_exec_suspend@basic-s3:
>     - shard-kbl:          [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +1 similar issue
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl4/igt@[e-mail]
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-kbl7/igt@[e-mail]
> 
>   * igt@gen9_exec_parse@allowed-all:
>     - shard-skl:          [PASS][9] -> [DMESG-WARN][10] ([i915#716])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl8/igt@[e-mail]
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl10/igt@[e-mail]
> 
>   * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
>     - shard-glk:          [PASS][11] -> [FAIL][12] ([i915#72])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-glk2/igt@[e-mail]
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-glk7/igt@[e-mail]
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-skl:          [PASS][13] -> [FAIL][14] ([i915#79])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl7/igt@[e-mail]
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl8/igt@[e-mail]
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible:
>     - shard-iclb:         [PASS][15] -> [INCOMPLETE][16] ([i915#1185] / [i915#221])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb7/igt@[e-mail]
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-iclb3/igt@[e-mail]
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
>     - shard-kbl:          [PASS][17] -> [DMESG-WARN][18] ([i915#180] / [i915#93] / [i915#95])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl3/igt@[e-mail]
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-kbl1/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl3/igt@[e-mail]
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl6/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_primary_page_flip:
>     - shard-iclb:         [PASS][21] -> [SKIP][22] ([fdo#109441])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-iclb6/igt@kms_psr@psr2_primary_page_flip.html
> 
>   * igt@kms_setmode@basic:
>     - shard-skl:          [PASS][23] -> [FAIL][24] ([i915#31])
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl7/igt@[e-mail]
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl9/igt@[e-mail]
> 
>   * igt@kms_vblank@pipe-a-ts-continuation-suspend:
>     - shard-apl:          [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +4 similar issues
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl6/igt@[e-mail]
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-apl8/igt@[e-mail]
> 
>   
> #### Possible fixes ####
> 
>   * {igt@gem_wait@write-wait@all}:
>     - shard-skl:          [FAIL][27] ([i915#1676]) -> [PASS][28]
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl2/igt@gem_wait@[e-mail]
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl9/igt@gem_wait@[e-mail]
> 
>   * igt@gen9_exec_parse@allowed-all:
>     - shard-apl:          [DMESG-WARN][29] ([i915#716]) -> [PASS][30]
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl3/igt@[e-mail]
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-apl1/igt@[e-mail]
> 
>   * igt@kms_hdr@bpc-switch-dpms:
>     - shard-skl:          [FAIL][31] ([i915#1188]) -> [PASS][32]
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl10/igt@[e-mail]
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl10/igt@[e-mail]
> 
>   * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
>     - shard-kbl:          [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +2 similar issues
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl7/igt@[e-mail]
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-kbl2/igt@[e-mail]
> 
>   * igt@kms_psr@psr2_cursor_mmap_cpu:
>     - shard-iclb:         [SKIP][35] ([fdo#109441]) -> [PASS][36] +3 similar issues
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
> 
>   * igt@kms_setmode@basic:
>     - shard-glk:          [FAIL][37] ([i915#31]) -> [PASS][38]
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-glk2/igt@[e-mail]
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-glk8/igt@[e-mail]
> 
>   * igt@kms_vblank@pipe-b-ts-continuation-suspend:
>     - shard-apl:          [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +3 similar issues
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl4/igt@[e-mail]
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-apl4/igt@[e-mail]
> 
>   * {igt@perf@blocking-parameterized}:
>     - shard-hsw:          [FAIL][41] ([i915#1542]) -> [PASS][42] +1 similar issue
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-hsw6/igt@[e-mail]
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-hsw7/igt@[e-mail]
> 
>   * {igt@sysfs_heartbeat_interval@mixed@vcs0}:
>     - shard-skl:          [INCOMPLETE][43] ([i915#198]) -> [PASS][44]
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl7/igt@sysfs_heartbeat_interval@[e-mail]
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl10/igt@sysfs_heartbeat_interval@[e-mail]
> 
>   
> #### Warnings ####
> 
>   * igt@kms_fbcon_fbt@fbc-suspend:
>     - shard-kbl:          [DMESG-FAIL][45] ([i915#180] / [i915#95]) -> [FAIL][46] ([i915#93] / [i915#95])
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl6/igt@[e-mail]
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-kbl3/igt@[e-mail]
> 
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          [FAIL][47] ([i915#79]) -> [FAIL][48] ([i915#46])
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-skl8/igt@[e-mail]
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-skl5/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
>     - shard-apl:          [FAIL][49] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][50] ([fdo#108145] / [i915#265])
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl1/igt@[e-mail]
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-apl2/igt@[e-mail]
> 
>   * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
>     - shard-kbl:          [FAIL][51] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][52] ([fdo#108145] / [i915#265])
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-kbl2/igt@[e-mail]
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-kbl6/igt@[e-mail]
> 
>   * igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm:
>     - shard-hsw:          [SKIP][53] ([fdo#109271]) -> [INCOMPLETE][54] ([i915#61])
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-hsw7/igt@[e-mail]
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-hsw8/igt@[e-mail]
> 
>   * igt@runner@aborted:
>     - shard-apl:          ([FAIL][55], [FAIL][56]) ([i915#1423] / [i915#716]) -> [FAIL][57] ([i915#1423])
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl3/igt@[e-mail]
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8298/shard-apl3/igt@[e-mail]
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/shard-apl3/igt@[e-mail]
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
>   [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
>   [i915#1423]: https://gitlab.freedesktop.org/drm/intel/issues/1423
>   [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
>   [i915#1676]: https://gitlab.freedesktop.org/drm/intel/issues/1676
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
>   [i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
>   [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
>   [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
>   [i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
>   [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
>   [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
>   [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
>   [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
>   [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
>   [i915#935]: https://gitlab.freedesktop.org/drm/intel/issues/935
>   [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_8298 -> Patchwork_17302
> 
>   CI-20190529: 20190529
>   CI_DRM_8298: 17f82f0c2857d0b442adbdb62eb44b61d0f5b775 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5589: 31962324ac86f029e2841e56e97c42cf9d572956 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_17302: 70839f0c2611d7ce6d8c19410571db921cab265c @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17302/index.html