mbox series

[i-g-t,v2,00/16] tests/core_hotunplug: Fixes and enhancements

Message ID 20200807092002.32350-1-janusz.krzysztofik@linux.intel.com (mailing list archive)
Headers show
Series tests/core_hotunplug: Fixes and enhancements | expand

Message

Janusz Krzysztofik Aug. 7, 2020, 9:19 a.m. UTC 
Clean up the test code and unblock unbind variants.

@Michał: Since most v2 updates are trivial, I've preserved your
Reviewd-by: except for patch 11/16 "Follow failed subtests with health
checks" - please have a look and confirm if you are still OK with it.

Thanks,
Janusz

Janusz Krzysztofik (16):
  tests/core_hotunplug: Use igt_assert_fd()
  tests/core_hotunplug: Constify dev_bus_addr string
  tests/core_hotunplug: Consolidate duplicated debug messages
  tests/core_hotunplug: Assert successful device filter application
  tests/core_hotunplug: Fix missing newline
  tests/core_hotunplug: Maintain a single data structure instance
  tests/core_hotunplug: Pass errors via a data structure field
  tests/core_hotunplug: Handle device close errors
  tests/core_hotunplug: Prepare invariant data once per test run
  tests/core_hotunplug: Skip selectively on sysfs close errors
  tests/core_hotunplug: Follow failed subtests with health checks
  tests/core_hotunplug: Fail subtests on device close errors
  tests/core_hotunplug: Process return values of sysfs operations
  tests/core_hotunplug: Assert expected device presence/absence
  tests/core_hotunplug: Explicitly ignore unused return values
  tests/core_hotunplug: Un-blocklist *unbind* subtests

 tests/core_hotunplug.c       | 334 +++++++++++++++++++++--------------
 tests/intel-ci/blacklist.txt |   2 +-
 2 files changed, 204 insertions(+), 132 deletions(-)

Comments

Janusz Krzysztofik Aug. 10, 2020, 9:33 a.m. UTC | #1 
On Fri, 2020-08-07 at 11:19 +0200, Janusz Krzysztofik wrote:
> Clean up the test code and unblock unbind variants.

From the CI report it looks for me like driver (hot)unbind-rebind
operations affect hardware and the driver doesn't handle this
correctly.  Moreover, the test doesn't currently detect this faulty
condition and happily returns success.

On the other hand, the hardware seems not stuck permanently, it looks
like it just requires engines to be reset.

Then, I'm going to extend the series with a more thorough health check
and a more careful recovery.  The unbind-rebind subtest shall report a
failure as soon as it detects that engines require a reset, I believe,
but igt_abort shall not be called unless the recovery phase fails.

Thanks,
Janusz

> 
> @Michał: Since most v2 updates are trivial, I've preserved your
> Reviewd-by: except for patch 11/16 "Follow failed subtests with health
> checks" - please have a look and confirm if you are still OK with it.
> 
> Thanks,
> Janusz
> 
> Janusz Krzysztofik (16):
>   tests/core_hotunplug: Use igt_assert_fd()
>   tests/core_hotunplug: Constify dev_bus_addr string
>   tests/core_hotunplug: Consolidate duplicated debug messages
>   tests/core_hotunplug: Assert successful device filter application
>   tests/core_hotunplug: Fix missing newline
>   tests/core_hotunplug: Maintain a single data structure instance
>   tests/core_hotunplug: Pass errors via a data structure field
>   tests/core_hotunplug: Handle device close errors
>   tests/core_hotunplug: Prepare invariant data once per test run
>   tests/core_hotunplug: Skip selectively on sysfs close errors
>   tests/core_hotunplug: Follow failed subtests with health checks
>   tests/core_hotunplug: Fail subtests on device close errors
>   tests/core_hotunplug: Process return values of sysfs operations
>   tests/core_hotunplug: Assert expected device presence/absence
>   tests/core_hotunplug: Explicitly ignore unused return values
>   tests/core_hotunplug: Un-blocklist *unbind* subtests
> 
>  tests/core_hotunplug.c       | 334 +++++++++++++++++++++--------------
>  tests/intel-ci/blacklist.txt |   2 +-
>  2 files changed, 204 insertions(+), 132 deletions(-)
>