mbox series

[i-g-t,v3,00/19] tests/core_hotunplug: Fixes and enhancements

Message ID 20200820145215.13238-1-janusz.krzysztofik@linux.intel.com (mailing list archive)
Headers show
Series tests/core_hotunplug: Fixes and enhancements | expand

Message

Janusz Krzysztofik Aug. 20, 2020, 2:51 p.m. UTC 
Clean up the test code, add some new basic subtests, then unblock
unbind test variants.

One patch has been renamed, three new patches added to the series, and
one more patch form a formerly submitted series with new subtests
included.

@Michał: Since most v2/v3 updates are trivial, I've preserved your
v1/v2 Reviewd-by: except for a few patches with non-trivial changes,
where I marked your R-b as v1/v2 applicable.  Please have a look and
confirm if you are still OK with them.

@Tvrtko: Please support my attempt to remove the unbind test variants
from the blocklist.

@Petri, @Martin: Please give me your green lite for merging this
series if you have no objections.

Thanks,
Janusz

Janusz Krzysztofik (19):
  tests/core_hotunplug: Use igt_assert_fd()
  tests/core_hotunplug: Constify dev_bus_addr string
  tests/core_hotunplug: Clean up device open error handling
  tests/core_hotunplug: Consolidate duplicated debug messages # new
  tests/core_hotunplug: Assert successful device filter application
  tests/core_hotunplug: Maintain a single data structure instance
  tests/core_hotunplug: Pass errors via a data structure field
  tests/core_hotunplug: Handle device close errors
  tests/core_hotunplug: Prepare invariant data once per test run
  tests/core_hotunplug: Skip selectively on sysfs close errors
  tests/core_hotunplug: Recover from subtest failures # renamed
  tests/core_hotunplug: Fail subtests on device close errors
  tests/core_hotunplug: Let the driver time out essential sysfs operations # new
  tests/core_hotunplug: Process return values of sysfs operations
  tests/core_hotunplug: Assert expected device presence/absence
  tests/core_hotunplug: Explicitly ignore unused return values
  tests/core_hotunplug: More thorough i915 healthcheck and recovery # new
  tests/core_hotunplug: Add 'lateclose before restore' variants # included
  tests/core_hotunplug: Un-blocklist *bind* subtests

 tests/core_hotunplug.c       | 525 ++++++++++++++++++++++++++---------
 tests/intel-ci/blacklist.txt |   2 +-
 2 files changed, 396 insertions(+), 131 deletions(-)

Comments

Janusz Krzysztofik Aug. 21, 2020, 10:11 a.m. UTC | #1 
On Thu, 2020-08-20 at 16:51 +0200, Janusz Krzysztofik wrote:
> Clean up the test code, add some new basic subtests, then unblock
> unbind test variants.

Hi,

CI results show that i915 recovery after a failed healthcheck still
needs some work, so please hold on with your reviews.  I'm going to
submit v4 soon.

Thanks,
Janusz

> 
> One patch has been renamed, three new patches added to the series, and
> one more patch form a formerly submitted series with new subtests
> included.
> 
> @Michał: Since most v2/v3 updates are trivial, I've preserved your
> v1/v2 Reviewd-by: except for a few patches with non-trivial changes,
> where I marked your R-b as v1/v2 applicable.  Please have a look and
> confirm if you are still OK with them.
> 
> @Tvrtko: Please support my attempt to remove the unbind test variants
> from the blocklist.
> 
> @Petri, @Martin: Please give me your green lite for merging this
> series if you have no objections.
> 
> Thanks,
> Janusz
> 
> Janusz Krzysztofik (19):
>   tests/core_hotunplug: Use igt_assert_fd()
>   tests/core_hotunplug: Constify dev_bus_addr string
>   tests/core_hotunplug: Clean up device open error handling
>   tests/core_hotunplug: Consolidate duplicated debug messages # new
>   tests/core_hotunplug: Assert successful device filter application
>   tests/core_hotunplug: Maintain a single data structure instance
>   tests/core_hotunplug: Pass errors via a data structure field
>   tests/core_hotunplug: Handle device close errors
>   tests/core_hotunplug: Prepare invariant data once per test run
>   tests/core_hotunplug: Skip selectively on sysfs close errors
>   tests/core_hotunplug: Recover from subtest failures # renamed
>   tests/core_hotunplug: Fail subtests on device close errors
>   tests/core_hotunplug: Let the driver time out essential sysfs operations # new
>   tests/core_hotunplug: Process return values of sysfs operations
>   tests/core_hotunplug: Assert expected device presence/absence
>   tests/core_hotunplug: Explicitly ignore unused return values
>   tests/core_hotunplug: More thorough i915 healthcheck and recovery # new
>   tests/core_hotunplug: Add 'lateclose before restore' variants # included
>   tests/core_hotunplug: Un-blocklist *bind* subtests
> 
>  tests/core_hotunplug.c       | 525 ++++++++++++++++++++++++++---------
>  tests/intel-ci/blacklist.txt |   2 +-
>  2 files changed, 396 insertions(+), 131 deletions(-)
>