| Message ID | 20210304170421.10901-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Silence pipe tracepoint WARNs | expand |
On Thu, 4 Mar 2021 19:04:17 +0200 Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > I believe this should silence the WARN spew from the > pipe disable tracepoint Steve reported. And I tossed in > a few other minor improvements as well. > > Cc: Steven Rostedt <rostedt@goodmis.org> It seemed to have stopped the general protection faults when tracing all events on my machine. Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve > > Ville Syrjälä (4): > drm/i915: Move pipe enable/disable tracepoints to > intel_crtc_vblank_{on,off}() > drm/i915: Don't try to query the frame counter for disabled pipes > drm/i915: Return zero as the scanline counter for disabled pipes > drm/i915: Fix DSI TE max_vblank_count handling > > drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++--- > drivers/gpu/drm/i915/display/intel_display.c | 8 +------ > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 3 files changed, 23 insertions(+), 11 deletions(-) >
On Thu, 04 Mar 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > I believe this should silence the WARN spew from the > pipe disable tracepoint Steve reported. And I tossed in > a few other minor improvements as well. On some of the patches I'll just have to take your word for what it says in the commit messages, but the patches do what they say. On the series, Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > Cc: Steven Rostedt <rostedt@goodmis.org> > > Ville Syrjälä (4): > drm/i915: Move pipe enable/disable tracepoints to > intel_crtc_vblank_{on,off}() > drm/i915: Don't try to query the frame counter for disabled pipes > drm/i915: Return zero as the scanline counter for disabled pipes > drm/i915: Fix DSI TE max_vblank_count handling > > drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++--- > drivers/gpu/drm/i915/display/intel_display.c | 8 +------ > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 3 files changed, 23 insertions(+), 11 deletions(-)
On Thu, Mar 04, 2021 at 02:20:22PM -0500, Steven Rostedt wrote: > On Thu, 4 Mar 2021 19:04:17 +0200 > Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > I believe this should silence the WARN spew from the > > pipe disable tracepoint Steve reported. And I tossed in > > a few other minor improvements as well. > > > > Cc: Steven Rostedt <rostedt@goodmis.org> > > It seemed to have stopped the general protection faults when tracing all > events on my machine. > > Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Series pushed to drm-intel-next. Thanks for reporting the problem. > > -- Steve > > > > > Ville Syrjälä (4): > > drm/i915: Move pipe enable/disable tracepoints to > > intel_crtc_vblank_{on,off}() > > drm/i915: Don't try to query the frame counter for disabled pipes > > drm/i915: Return zero as the scanline counter for disabled pipes > > drm/i915: Fix DSI TE max_vblank_count handling > > > > drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++--- > > drivers/gpu/drm/i915/display/intel_display.c | 8 +------ > > drivers/gpu/drm/i915/i915_irq.c | 2 +- > > 3 files changed, 23 insertions(+), 11 deletions(-) > >
From: Ville Syrjälä <ville.syrjala@linux.intel.com> I believe this should silence the WARN spew from the pipe disable tracepoint Steve reported. And I tossed in a few other minor improvements as well. Cc: Steven Rostedt <rostedt@goodmis.org> Ville Syrjälä (4): drm/i915: Move pipe enable/disable tracepoints to intel_crtc_vblank_{on,off}() drm/i915: Don't try to query the frame counter for disabled pipes drm/i915: Return zero as the scanline counter for disabled pipes drm/i915: Fix DSI TE max_vblank_count handling drivers/gpu/drm/i915/display/intel_crtc.c | 24 +++++++++++++++++--- drivers/gpu/drm/i915/display/intel_display.c | 8 +------ drivers/gpu/drm/i915/i915_irq.c | 2 +- 3 files changed, 23 insertions(+), 11 deletions(-)