mbox series

[v3,00/20] drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers

Message ID 20210419225523.184856-1-lyude@redhat.com (mailing list archive)
Headers show
Series drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers | expand

Message

Lyude Paul April 19, 2021, 10:55 p.m. UTC
Since it's been asked quite a few times on some of the various DP
related patch series I've submitted to use the new DRM printk helpers,
and it technically wasn't really trivial to do this before due to the
lack of a consistent way to find a drm_device for an AUX channel, this
patch series aims to address this. In this series we:

* (NEW!) Move i2c adapter setup into drm_dp_aux_init() and add
  drm_dp_aux_fini()
* Clean-up potentially erroneous usages of drm_dp_aux_init() and
  drm_dp_aux_register() so that actual AUX registration doesn't happen
  until we have an associated DRM device
* Clean-up any obvious errors in drivers we find along the way
* Add a backpointer to the respective drm_device for an AUX channel in
  drm_dp_aux.drm_dev, and hook it up in every driver with an AUX channel
  across the tree
* Add a new ratelimited print helper we'll need for converting the DP
  helpers over to using the new DRM printk helpers
* Fix any inconsistencies with logging in drm_dp_helper.c so we always
  have the aux channel name printed
* Prepare the various DP helpers so they can find the correct drm_device
  to use for logging
* And finally, convert all of the DP helpers over to using drm_dbg_*()
  and drm_err().

Lyude Paul (20):
  drm/amdgpu: Add error handling to amdgpu_dm_initialize_dp_connector()
  drm/dp: Add __no_check to drm_dp_aux_register()
  drm/dp: Move i2c init to drm_dp_aux_init, add __must_check and fini
  drm/bridge/cdns-mhdp8546: Register DP aux channel with userspace
  drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late
    register/early unregister
  drm/dp: Add backpointer to drm_device in drm_dp_aux
  drm/dp: Clarify DP AUX registration time
  drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()
  drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()
  drm/dp: Always print aux channel name in logs
  drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_detect()
  drm/dp_dual_mode: Pass drm_device to
    drm_dp_dual_mode_set_tmds_output()
  drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_max_tmds_clock()
  drm/dp_dual_mode: Pass drm_device to
    drm_dp_dual_mode_get_tmds_output()
  drm/dp_dual_mode: Pass drm_device to drm_lspcon_(get|set)_mode()
  drm/dp_mst: Pass drm_dp_mst_topology_mgr to drm_dp_get_vc_payload_bw()
  drm/print: Handle potentially NULL drm_devices in drm_dbg_*
  drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_*()
  drm/dp_dual_mode: Convert drm_dp_dual_mode_helper.c to using
    drm_err/drm_dbg_kms()
  drm/dp_mst: Convert drm_dp_mst_topology.c to drm_err()/drm_dbg*()

 .../gpu/drm/amd/amdgpu/amdgpu_connectors.c    |   7 +-
 drivers/gpu/drm/amd/amdgpu/atombios_dp.c      |  17 +-
 drivers/gpu/drm/amd/amdgpu/atombios_dp.h      |   2 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  29 +-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.c   |  49 ++-
 .../display/amdgpu_dm/amdgpu_dm_mst_types.h   |   6 +-
 .../drm/bridge/analogix/analogix-anx6345.c    |   3 +
 .../drm/bridge/analogix/analogix-anx78xx.c    |   3 +
 .../drm/bridge/analogix/analogix_dp_core.c    |   2 +
 .../drm/bridge/cadence/cdns-mhdp8546-core.c   |  26 +-
 drivers/gpu/drm/bridge/tc358767.c             |   6 +-
 drivers/gpu/drm/bridge/ti-sn65dsi86.c         |  17 +-
 drivers/gpu/drm/drm_dp_aux_dev.c              |   6 +
 drivers/gpu/drm/drm_dp_dual_mode_helper.c     |  68 ++--
 drivers/gpu/drm/drm_dp_helper.c               | 260 +++++++-----
 drivers/gpu/drm/drm_dp_mst_topology.c         | 376 +++++++++---------
 drivers/gpu/drm/i915/display/intel_dp_aux.c   |  11 +-
 drivers/gpu/drm/i915/display/intel_dp_aux.h   |   2 +-
 .../drm/i915/display/intel_dp_link_training.c |   6 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   7 +-
 drivers/gpu/drm/i915/display/intel_lspcon.c   |  17 +-
 drivers/gpu/drm/msm/dp/dp_aux.c               |   1 +
 drivers/gpu/drm/msm/dp/dp_ctrl.c              |   6 +-
 drivers/gpu/drm/msm/edp/edp.h                 |   3 +-
 drivers/gpu/drm/msm/edp/edp_aux.c             |   6 +-
 drivers/gpu/drm/msm/edp/edp_ctrl.c            |   8 +-
 drivers/gpu/drm/nouveau/nouveau_connector.c   |  27 +-
 drivers/gpu/drm/radeon/atombios_dp.c          |   5 +-
 drivers/gpu/drm/radeon/radeon_connectors.c    |   1 +
 drivers/gpu/drm/tegra/dpaux.c                 |  15 +-
 drivers/gpu/drm/xlnx/zynqmp_dp.c              |   6 +-
 include/drm/drm_dp_dual_mode_helper.h         |  14 +-
 include/drm/drm_dp_helper.h                   |  24 +-
 include/drm/drm_dp_mst_helper.h               |   3 +-
 include/drm/drm_print.h                       |  20 +-
 36 files changed, 631 insertions(+), 431 deletions(-)

Comments

Lyude Paul April 20, 2021, 3:22 a.m. UTC | #1
whoops, will definitely fix this and respin tomorrow

On Mon, 2021-04-19 at 23:25 +0000, Patchwork wrote:
> Patch Details
> Series:drm: Use new DRM printk funcs (like drm_dbg_*()) in DP helpers
> (rev6)URL:https://patchwork.freedesktop.org/series/87242/State:failure
> Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19953/index.html
> CI Bug Log - changes from CI_DRM_9983 -> Patchwork_19953SummaryFAILURE
> Serious unknown changes coming with Patchwork_19953 absolutely need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_19953, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_19953/index.html
> Possible new issuesHere are the unknown changes that may have been introduced in
> Patchwork_19953:
> CI changesPossible regressions * boot:fi-apl-guc: PASS -> FAILfi-kbl-8809g: PASS -> FAILfi-snb-2520m: PASS -
>    > FAILfi-bsw-nick: PASS -> FAILfi-icl-u2: PASS -> FAILfi-cfl-8109u: PASS ->
>    FAILfi-cfl-8700k: PASS -> FAILfi-bxt-dsi: PASS -> FAILfi-cml-u2: PASS ->
>    FAILfi-ilk-650: PASS -> FAILfi-tgl-u2: PASS -> FAILfi-hsw-4770: PASS ->
>    FAILfi-cfl-guc: PASS -> FAILfi-kbl-soraka: PASS -> FAILfi-cml-s: PASS ->
>    FAILfi-elk-e7500: PASS -> FAILfi-glk-dsi: PASS -> FAILfi-snb-2600: PASS ->
>    FAILfi-tgl-y: PASS -> FAILfi-kbl-guc: PASS -> FAILfi-kbl-x1275: PASS ->
>    FAILfi-bdw-gvtdvm: PASS -> FAILfi-kbl-7500u: PASS -> FAILfi-bdw-5557u: PASS
>    -> FAILfi-kbl-r: PASS -> FAILfi-kbl-7567u: PASS -> FAIL
> SuppressedThe following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
>  * boot:{fi-tgl-dsi}: PASS -> FAIL{fi-hsw-gt1}: PASS -> FAIL{fi-jsl-1}: PASS -
>    > FAIL{fi-ehl-1}: PASS -> FAIL{fi-rkl-11500t}: PASS -> FAIL{fi-ehl-2}: PASS
>    -> FAIL
> Known issuesHere are the changes found in Patchwork_19953 that come from known issues:
> CI changesIssues hit * boot:fi-skl-6600u: PASS -> FAIL (i915#3174)fi-skl-6700k2: PASS -> FAIL
>    (i915#3174)fi-skl-guc: PASS -> FAIL (i915#3174)
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> Participating hosts (42 -> 38)Missing (4): fi-icl-y fi-bsw-cyan fi-bsw-kefka fi-bdw-samus 
> Build changes * Linux: CI_DRM_9983 -> Patchwork_19953
> CI-20190529: 20190529
> CI_DRM_9983: 03ed13adf40fd6827c888186a9f356a537237c3f @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6070: 907705f0c3f6b5ae6358a4822434dd6d7a070cff @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19953: 4d85fbc4cd3fcfecee0f4ea8d2cc5f7f3d29985c @
> git://anongit.freedesktop.org/gfx-ci/linux
> == Linux commits ==
> 4d85fbc4cd3f drm/dp_mst: Convert drm_dp_mst_topology.c to
> drm_err()/drm_dbg()
> 2cdf118000c8 drm/dp_dual_mode: Convert drm_dp_dual_mode_helper.c to using
> drm_err/drm_dbg_kms()
> 8529dfa260fc drm/dp: Convert drm_dp_helper.c to using drm_err/drm_dbg_()
> fa4bf5cbb3bb drm/print: Handle potentially NULL drm_devices in drm_dbg_
> ce547d2b0cb9 drm/dp_mst: Pass drm_dp_mst_topology_mgr to
> drm_dp_get_vc_payload_bw()
> c4f143e80afd drm/dp_dual_mode: Pass drm_device to
> drm_lspcon_(get|set)_mode()
> 70e25b343fb6 drm/dp_dual_mode: Pass drm_device to
> drm_dp_dual_mode_get_tmds_output()
> 91c92d211983 drm/dp_dual_mode: Pass drm_device to
> drm_dp_dual_mode_max_tmds_clock()
> 8947ebf4721c drm/dp_dual_mode: Pass drm_device to
> drm_dp_dual_mode_set_tmds_output()
> 37dae984861b drm/dp_dual_mode: Pass drm_device to drm_dp_dual_mode_detect()
> 33109c79827e drm/dp: Always print aux channel name in logs
> a12a22656307 drm/dp: Pass drm_dp_aux to drm_dp_link_train_channel_eq_delay()
> 764073b4a508 drm/dp: Pass drm_dp_aux to
> drm_dp_link_train_clock_recovery_delay()
> d52ff25d184a drm/dp: Clarify DP AUX registration time
> 057f5073ee57 drm/dp: Add backpointer to drm_device in drm_dp_aux
> b05faee9e18d drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late
> register/early unregister
> 0f2070c3486f drm/bridge/cdns-mhdp8546: Register DP aux channel with
> userspace
> 6b4b8b73edda drm/dp: Move i2c init to drm_dp_aux_init, add __must_check and
> fini
> 996c7d026bb9 drm/dp: Add __no_check to drm_dp_aux_register()
> fffba1b63bf6 drm/amdgpu: Add error handling to
> amdgpu_dm_initialize_dp_connector()
Alex Deucher April 21, 2021, 3:22 p.m. UTC | #2
[AMD Official Use Only - Internal Distribution Only]

I'm fine with having these changes go through drm-misc.

Alex