mbox series

[v3,0/3] Introduce Raptor Lake S

Message ID 20211203063545.2254380-1-anusha.srivatsa@intel.com (mailing list archive)
Headers show
Series Introduce Raptor Lake S | expand

Message

Srivatsa, Anusha Dec. 3, 2021, 6:35 a.m. UTC
Raptor Lake S(RPL-S) is a version 12
Display, Media and Render. For all i915
purposes it is the same as Alder Lake S (ADL-S).

The series introduces it as a subplatform
of ADL-S. The one difference is the GuC
submission which is default on RPL-S but
was not the case with ADL-S.

All patches are reviewed. Jani has acked the series.
Looking for other acks in order to merge these to
respective branches.

Cc: x86@kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>

Anusha Srivatsa (3):
  drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
  drm/i915/rpl-s: Add PCH Support for Raptor Lake S
  drm/i915/rpl-s: Enable guc submission by default

 arch/x86/kernel/early-quirks.c           | 1 +
 drivers/gpu/drm/i915/gt/uc/intel_uc.c    | 2 +-
 drivers/gpu/drm/i915/i915_drv.h          | 2 ++
 drivers/gpu/drm/i915/i915_pci.c          | 1 +
 drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
 drivers/gpu/drm/i915/intel_device_info.h | 3 +++
 drivers/gpu/drm/i915/intel_pch.c         | 1 +
 drivers/gpu/drm/i915/intel_pch.h         | 1 +
 include/drm/i915_pciids.h                | 9 +++++++++
 9 files changed, 26 insertions(+), 1 deletion(-)

Comments

Tvrtko Ursulin Dec. 3, 2021, 9:27 a.m. UTC | #1
On 03/12/2021 06:35, Anusha Srivatsa wrote:
> Raptor Lake S(RPL-S) is a version 12
> Display, Media and Render. For all i915
> purposes it is the same as Alder Lake S (ADL-S).
> 
> The series introduces it as a subplatform
> of ADL-S. The one difference is the GuC
> submission which is default on RPL-S but
> was not the case with ADL-S.

As a side note, not a blocker of any kind, I am slightly disheartened 
but the confusion of ADL_P and ADL_S being separate platforms, but then 
RPL_S is subplatform of ADL_S. Maybe it is just me not being able to 
keep track of things.

> All patches are reviewed. Jani has acked the series.
> Looking for other acks in order to merge these to
> respective branches.

Which branches would that be for this series? First two to 
drm-intel-next and last one to drm-intel-gt-next? Is that complication 
needed and/or worth the effort?

Regards,

Tvrtko

> Cc: x86@kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> 
> Anusha Srivatsa (3):
>    drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
>    drm/i915/rpl-s: Add PCH Support for Raptor Lake S
>    drm/i915/rpl-s: Enable guc submission by default
> 
>   arch/x86/kernel/early-quirks.c           | 1 +
>   drivers/gpu/drm/i915/gt/uc/intel_uc.c    | 2 +-
>   drivers/gpu/drm/i915/i915_drv.h          | 2 ++
>   drivers/gpu/drm/i915/i915_pci.c          | 1 +
>   drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
>   drivers/gpu/drm/i915/intel_device_info.h | 3 +++
>   drivers/gpu/drm/i915/intel_pch.c         | 1 +
>   drivers/gpu/drm/i915/intel_pch.h         | 1 +
>   include/drm/i915_pciids.h                | 9 +++++++++
>   9 files changed, 26 insertions(+), 1 deletion(-)
>
Srivatsa, Anusha Dec. 6, 2021, 4:29 a.m. UTC | #2
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: Friday, December 3, 2021 2:57 PM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: Re: [v3 0/3] Introduce Raptor Lake S
> 
> 
> On 03/12/2021 06:35, Anusha Srivatsa wrote:
> > Raptor Lake S(RPL-S) is a version 12
> > Display, Media and Render. For all i915 purposes it is the same as
> > Alder Lake S (ADL-S).
> >
> > The series introduces it as a subplatform of ADL-S. The one difference
> > is the GuC submission which is default on RPL-S but was not the case
> > with ADL-S.
> 
> As a side note, not a blocker of any kind, I am slightly disheartened but the
> confusion of ADL_P and ADL_S being separate platforms, but then RPL_S is
> subplatform of ADL_S. Maybe it is just me not being able to keep track of
> things.
> 
> > All patches are reviewed. Jani has acked the series.
> > Looking for other acks in order to merge these to respective branches.
> 
> Which branches would that be for this series? First two to drm-intel-next and
> last one to drm-intel-gt-next? Is that complication needed and/or worth the
> effort?

Tvrtko,
 All three have to land to drm-intel-next. The last one has dependency on the first patch and is a trivial change.

Anusha
> Regards,
> 
> Tvrtko
> 
> > Cc: x86@kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Anusha Srivatsa (3):
> >    drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> >    drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> >    drm/i915/rpl-s: Enable guc submission by default
> >
> >   arch/x86/kernel/early-quirks.c           | 1 +
> >   drivers/gpu/drm/i915/gt/uc/intel_uc.c    | 2 +-
> >   drivers/gpu/drm/i915/i915_drv.h          | 2 ++
> >   drivers/gpu/drm/i915/i915_pci.c          | 1 +
> >   drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> >   drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> >   drivers/gpu/drm/i915/intel_pch.c         | 1 +
> >   drivers/gpu/drm/i915/intel_pch.h         | 1 +
> >   include/drm/i915_pciids.h                | 9 +++++++++
> >   9 files changed, 26 insertions(+), 1 deletion(-)
> >
Srivatsa, Anusha Dec. 7, 2021, 9:53 a.m. UTC | #3
> -----Original Message-----
> From: Srivatsa, Anusha
> Sent: Monday, December 6, 2021 9:59 AM
> To: 'Tvrtko Ursulin' <tvrtko.ursulin@linux.intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> <dave.hansen@linux.intel.com>; Joonas Lahtinen
> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
> Subject: RE: [v3 0/3] Introduce Raptor Lake S
> 
> 
> 
> > -----Original Message-----
> > From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > Sent: Friday, December 3, 2021 2:57 PM
> > To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
> > <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
> > <dave.hansen@linux.intel.com>; Joonas Lahtinen
> > <joonas.lahtinen@linux.intel.com>; Nikula, Jani
> > <jani.nikula@intel.com>
> > Subject: Re: [v3 0/3] Introduce Raptor Lake S
> >
> >
> > On 03/12/2021 06:35, Anusha Srivatsa wrote:
> > > Raptor Lake S(RPL-S) is a version 12 Display, Media and Render. For
> > > all i915 purposes it is the same as Alder Lake S (ADL-S).
> > >
> > > The series introduces it as a subplatform of ADL-S. The one
> > > difference is the GuC submission which is default on RPL-S but was
> > > not the case with ADL-S.
> >
> > As a side note, not a blocker of any kind, I am slightly disheartened
> > but the confusion of ADL_P and ADL_S being separate platforms, but
> > then RPL_S is subplatform of ADL_S. Maybe it is just me not being able
> > to keep track of things.
> >
> > > All patches are reviewed. Jani has acked the series.
> > > Looking for other acks in order to merge these to respective branches.
> >
> > Which branches would that be for this series? First two to
> > drm-intel-next and last one to drm-intel-gt-next? Is that complication
> > needed and/or worth the effort?
> 
> Tvrtko,
>  All three have to land to drm-intel-next. The last one has dependency on the
> first patch and is a trivial change.

@Ursulin, Tvrtko @Joonas Lahtinen can I get an ack to merge these into drm-intel-next branch?


Anusha
> Anusha
> > Regards,
> >
> > Tvrtko
> >
> > > Cc: x86@kernel.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: Ingo Molnar <mingo@redhat.com>
> > > Cc: Borislav Petkov <bp@alien8.de>
> > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > Anusha Srivatsa (3):
> > >    drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
> > >    drm/i915/rpl-s: Add PCH Support for Raptor Lake S
> > >    drm/i915/rpl-s: Enable guc submission by default
> > >
> > >   arch/x86/kernel/early-quirks.c           | 1 +
> > >   drivers/gpu/drm/i915/gt/uc/intel_uc.c    | 2 +-
> > >   drivers/gpu/drm/i915/i915_drv.h          | 2 ++
> > >   drivers/gpu/drm/i915/i915_pci.c          | 1 +
> > >   drivers/gpu/drm/i915/intel_device_info.c | 7 +++++++
> > >   drivers/gpu/drm/i915/intel_device_info.h | 3 +++
> > >   drivers/gpu/drm/i915/intel_pch.c         | 1 +
> > >   drivers/gpu/drm/i915/intel_pch.h         | 1 +
> > >   include/drm/i915_pciids.h                | 9 +++++++++
> > >   9 files changed, 26 insertions(+), 1 deletion(-)
> > >
Tvrtko Ursulin Dec. 8, 2021, 9:52 a.m. UTC | #4
On 06/12/2021 04:29, Srivatsa, Anusha wrote:
>> -----Original Message-----
>> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Sent: Friday, December 3, 2021 2:57 PM
>> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Cc: x86@kernel.org; dri-devel@lists.freedesktop.org; Ingo Molnar
>> <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; Dave Hansen
>> <dave.hansen@linux.intel.com>; Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com>; Nikula, Jani <jani.nikula@intel.com>
>> Subject: Re: [v3 0/3] Introduce Raptor Lake S
>>
>>
>> On 03/12/2021 06:35, Anusha Srivatsa wrote:
>>> Raptor Lake S(RPL-S) is a version 12
>>> Display, Media and Render. For all i915 purposes it is the same as
>>> Alder Lake S (ADL-S).
>>>
>>> The series introduces it as a subplatform of ADL-S. The one difference
>>> is the GuC submission which is default on RPL-S but was not the case
>>> with ADL-S.
>>
>> As a side note, not a blocker of any kind, I am slightly disheartened but the
>> confusion of ADL_P and ADL_S being separate platforms, but then RPL_S is
>> subplatform of ADL_S. Maybe it is just me not being able to keep track of
>> things.
>>
>>> All patches are reviewed. Jani has acked the series.
>>> Looking for other acks in order to merge these to respective branches.
>>
>> Which branches would that be for this series? First two to drm-intel-next and
>> last one to drm-intel-gt-next? Is that complication needed and/or worth the
>> effort?
> 
> Tvrtko,
>   All three have to land to drm-intel-next. The last one has dependency on the first patch and is a trivial change.

One more ack for a good measure:

Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko