| Message ID | 20220213091458.2364014-1-alexander.usyskin@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add driver for GSC controller | expand |
On Sun, Feb 13, 2022 at 11:14:53AM +0200, Alexander Usyskin wrote: > GSC is a graphics system controller, it provides > a chassis controller for graphics discrete cards. > > There are two MEI interfaces in GSC: HECI1 and HECI2. > > This series includes instantiation of the auxiliary devices for HECI2 > and mei-gsc auxiliary device driver that binds to the auxiliary device. > > In v2 the platform device was replaced by the auxiliary device. > v3 is the rebase over drm-tip to make public CI running. > In v4 the not needed debug prints and empty line were removed, > 'select' were replaced by 'depends on' in MEI Kconfig, > the new include file now listed in the MAINTATINERS file. > V5, rebase and add Greg KH Reviewed-by > V6, rebase and drop redundant assignments found by the kernel test robot. > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> This line needs to be added to the individual patches if you want any tool or maintainer to pick that up. thanks, greg k-h
> -----Original Message----- > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Sent: Sunday, February 13, 2022 11:56 > To: Usyskin, Alexander <alexander.usyskin@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen > <joonas.lahtinen@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; > David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Winkler, > Tomas <tomas.winkler@intel.com>; Lubart, Vitaly <vitaly.lubart@intel.com>; > intel-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v6 0/5] Add driver for GSC controller > > On Sun, Feb 13, 2022 at 11:14:53AM +0200, Alexander Usyskin wrote: > > GSC is a graphics system controller, it provides > > a chassis controller for graphics discrete cards. > > > > There are two MEI interfaces in GSC: HECI1 and HECI2. > > > > This series includes instantiation of the auxiliary devices for HECI2 > > and mei-gsc auxiliary device driver that binds to the auxiliary device. > > > > In v2 the platform device was replaced by the auxiliary device. > > v3 is the rebase over drm-tip to make public CI running. > > In v4 the not needed debug prints and empty line were removed, > > 'select' were replaced by 'depends on' in MEI Kconfig, > > the new include file now listed in the MAINTATINERS file. > > V5, rebase and add Greg KH Reviewed-by > > V6, rebase and drop redundant assignments found by the kernel test > robot. > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > This line needs to be added to the individual patches if you want any > tool or maintainer to pick that up. > Thanks for a tip, will send with your review added to the individual patches. > thanks, > > greg k-h
GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device. In v2 the platform device was replaced by the auxiliary device. v3 is the rebase over drm-tip to make public CI running. In v4 the not needed debug prints and empty line were removed, 'select' were replaced by 'depends on' in MEI Kconfig, the new include file now listed in the MAINTATINERS file. V5, rebase and add Greg KH Reviewed-by V6, rebase and drop redundant assignments found by the kernel test robot. Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Alexander Usyskin (2): mei: gsc: setup char driver alive in spite of firmware handshake failure mei: gsc: retrieve the firmware version Tomas Winkler (3): drm/i915/gsc: add gsc as a mei auxiliary device mei: add support for graphics system controller (gsc) devices mei: gsc: add runtime pm handlers MAINTAINERS | 1 + drivers/gpu/drm/i915/Kconfig | 1 + drivers/gpu/drm/i915/Makefile | 3 + drivers/gpu/drm/i915/gt/intel_gsc.c | 196 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gsc.h | 37 ++++ drivers/gpu/drm/i915/gt/intel_gt.c | 3 + drivers/gpu/drm/i915/gt/intel_gt.h | 5 + drivers/gpu/drm/i915/gt/intel_gt_irq.c | 13 ++ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 + drivers/gpu/drm/i915/i915_drv.h | 8 + drivers/gpu/drm/i915/i915_pci.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 2 + drivers/gpu/drm/i915/intel_device_info.h | 2 + drivers/misc/mei/Kconfig | 14 ++ drivers/misc/mei/Makefile | 3 + drivers/misc/mei/bus-fixup.c | 25 +++ drivers/misc/mei/gsc-me.c | 252 +++++++++++++++++++++++ drivers/misc/mei/hw-me.c | 29 ++- drivers/misc/mei/hw-me.h | 2 + include/linux/mei_aux.h | 19 ++ 21 files changed, 618 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/intel_gsc.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gsc.h create mode 100644 drivers/misc/mei/gsc-me.c create mode 100644 include/linux/mei_aux.h