mbox series

[0/9] drm/i915: Display info cleanup

Message ID 20220623130900.26078-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Display info cleanup | expand

Message

Ville Syrjälä June 23, 2022, 1:08 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Collect more stuff under INTEL_INFO->display, and clean up
some messy stuff in the related register macros.

Ville Syrjälä (9):
  drm/i915: Move dbuf details to INTEL_INFO->display
  drm/i195: Move pipe_offsets[] & co. to INTEL_INFO->display
  drm/i915: Move display_mmio_offset under INTEL_INFO->display
  drm/i915: Make pipe_offsets[] & co. u32
  drm/i915: s/_CURSOR2/_MMIO_CURSOR2//
  drm/i915: Use _MMIO_TRANS2() where appropriate
  drm/i915: Use _MMIO_PIPE2() where appropriate
  drm/i915: Get rid of XE_LPD_CURSOR_OFFSETS
  drm/i915: Move the color stuff under INTEL_INFO->display

 drivers/gpu/drm/i915/display/intel_color.c    |  28 ++---
 drivers/gpu/drm/i915/display/intel_display.h  |   2 +-
 .../drm/i915/display/intel_display_power.c    |   2 +-
 drivers/gpu/drm/i915/i915_pci.c               | 112 +++++++++---------
 drivers/gpu/drm/i915/i915_reg.h               |  47 ++++----
 drivers/gpu/drm/i915/intel_device_info.h      |  39 +++---
 drivers/gpu/drm/i915/intel_pm.c               |   8 +-
 7 files changed, 117 insertions(+), 121 deletions(-)

Comments

Jani Nikula June 23, 2022, 6:27 p.m. UTC | #1
On Thu, 23 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Collect more stuff under INTEL_INFO->display, and clean up
> some messy stuff in the related register macros.

Makes me wonder if we should have DISPLAY_INFO(i915) macro that returns
a pointer to the display sub-struct.

Anyway, the series is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Ville Syrjälä (9):
>   drm/i915: Move dbuf details to INTEL_INFO->display
>   drm/i195: Move pipe_offsets[] & co. to INTEL_INFO->display
>   drm/i915: Move display_mmio_offset under INTEL_INFO->display
>   drm/i915: Make pipe_offsets[] & co. u32
>   drm/i915: s/_CURSOR2/_MMIO_CURSOR2//
>   drm/i915: Use _MMIO_TRANS2() where appropriate
>   drm/i915: Use _MMIO_PIPE2() where appropriate
>   drm/i915: Get rid of XE_LPD_CURSOR_OFFSETS
>   drm/i915: Move the color stuff under INTEL_INFO->display
>
>  drivers/gpu/drm/i915/display/intel_color.c    |  28 ++---
>  drivers/gpu/drm/i915/display/intel_display.h  |   2 +-
>  .../drm/i915/display/intel_display_power.c    |   2 +-
>  drivers/gpu/drm/i915/i915_pci.c               | 112 +++++++++---------
>  drivers/gpu/drm/i915/i915_reg.h               |  47 ++++----
>  drivers/gpu/drm/i915/intel_device_info.h      |  39 +++---
>  drivers/gpu/drm/i915/intel_pm.c               |   8 +-
>  7 files changed, 117 insertions(+), 121 deletions(-)
Jani Nikula June 23, 2022, 6:29 p.m. UTC | #2
On Thu, 23 Jun 2022, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 23 Jun 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Collect more stuff under INTEL_INFO->display, and clean up
>> some messy stuff in the related register macros.
>
> Makes me wonder if we should have DISPLAY_INFO(i915) macro that returns
> a pointer to the display sub-struct.
>
> Anyway, the series is
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

PS. Here's a somewhat related device info cleanup:

https://patchwork.freedesktop.org/series/105358/


>
>
>>
>> Ville Syrjälä (9):
>>   drm/i915: Move dbuf details to INTEL_INFO->display
>>   drm/i195: Move pipe_offsets[] & co. to INTEL_INFO->display
>>   drm/i915: Move display_mmio_offset under INTEL_INFO->display
>>   drm/i915: Make pipe_offsets[] & co. u32
>>   drm/i915: s/_CURSOR2/_MMIO_CURSOR2//
>>   drm/i915: Use _MMIO_TRANS2() where appropriate
>>   drm/i915: Use _MMIO_PIPE2() where appropriate
>>   drm/i915: Get rid of XE_LPD_CURSOR_OFFSETS
>>   drm/i915: Move the color stuff under INTEL_INFO->display
>>
>>  drivers/gpu/drm/i915/display/intel_color.c    |  28 ++---
>>  drivers/gpu/drm/i915/display/intel_display.h  |   2 +-
>>  .../drm/i915/display/intel_display_power.c    |   2 +-
>>  drivers/gpu/drm/i915/i915_pci.c               | 112 +++++++++---------
>>  drivers/gpu/drm/i915/i915_reg.h               |  47 ++++----
>>  drivers/gpu/drm/i915/intel_device_info.h      |  39 +++---
>>  drivers/gpu/drm/i915/intel_pm.c               |   8 +-
>>  7 files changed, 117 insertions(+), 121 deletions(-)