| Message ID | 20220712193910.439171-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/kms: Stop registering multiple /sys/class/backlight devs for a single display | expand |
On Tue, Jul 12, 2022 at 9:39 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi All, > > As mentioned in my RFC titled "drm/kms: control display brightness through > drm_connector properties": > https://lore.kernel.org/dri-devel/0d188965-d809-81b5-74ce-7d30c49fee2d@redhat.com/ > > The first step towards this is to deal with some existing technical debt > in backlight handling on x86/ACPI boards, specifically we need to stop > registering multiple /sys/class/backlight devs for a single display. > > This series implements my RFC describing my plan for these cleanups: > https://lore.kernel.org/dri-devel/98519ba0-7f18-201a-ea34-652f50343158@redhat.com/ > > This new version addresses the few small remarks made on version 1 (mainly > changing patch 1/29) and more importantly this finishes the refactoring by > else addressing all the bits from the "Other issues" section of > the refactor RFC (resulting in patches 15-29 which are new in v2). > > Please review and test! I hope to be able to make an immutable branch > based on 5.20-rc1 + this series available for merging into the various > touched subsystems once 5.20-rc2 is out. Please feel free to add Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> to all of the ACPI video patches in this series. Thanks! > Hans de Goede (29): > ACPI: video: Add acpi_video_backlight_use_native() helper > drm/i915: Don't register backlight when another backlight should be > used > drm/amdgpu: Don't register backlight when another backlight should be > used > drm/radeon: Don't register backlight when another backlight should be > used > drm/nouveau: Don't register backlight when another backlight should be > used > ACPI: video: Drop backlight_device_get_by_type() call from > acpi_video_get_backlight_type() > ACPI: video: Remove acpi_video_bus from list before tearing it down > ACPI: video: Simplify acpi_video_unregister_backlight() > ACPI: video: Make backlight class device registration a separate step > ACPI: video: Remove code to unregister acpi_video backlight when a > native backlight registers > drm/i915: Call acpi_video_register_backlight() (v2) > drm/nouveau: Register ACPI video backlight when nv_backlight > registration fails > drm/amdgpu: Register ACPI video backlight when skipping amdgpu > backlight registration > drm/radeon: Register ACPI video backlight when skipping radeon > backlight registration > ACPI: video: Refactor acpi_video_get_backlight_type() a bit > ACPI: video: Add Nvidia WMI EC brightness control detection > ACPI: video: Add Apple GMUX brightness control detection > platform/x86: apple-gmux: Stop calling acpi/video.h functions > platform/x86: toshiba_acpi: Stop using > acpi_video_set_dmi_backlight_type() > platform/x86: acer-wmi: Move backlight DMI quirks to > acpi/video_detect.c > platform/x86: asus-wmi: Drop DMI chassis-type check from backlight > handling > platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI > video_detect.c > platform/x86: asus-wmi: Move acpi_backlight=native quirks to ACPI > video_detect.c > platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] > quirks to ACPI video_detect.c > ACPI: video: Remove acpi_video_set_dmi_backlight_type() > ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk > ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native > quirks > ACPI: video: Fix indentation of video_detect_dmi_table[] entries > drm/todo: Add entry about dealing with brightness control on devices > with > 1 panel > > Documentation/gpu/todo.rst | 68 +++ > drivers/acpi/Kconfig | 1 + > drivers/acpi/acpi_video.c | 59 ++- > drivers/acpi/video_detect.c | 415 +++++++++++------- > drivers/gpu/drm/Kconfig | 12 + > .../gpu/drm/amd/amdgpu/atombios_encoders.c | 14 +- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + > drivers/gpu/drm/gma500/Kconfig | 2 + > drivers/gpu/drm/i915/Kconfig | 2 + > .../gpu/drm/i915/display/intel_backlight.c | 7 + > drivers/gpu/drm/i915/display/intel_display.c | 8 + > drivers/gpu/drm/i915/display/intel_panel.c | 3 + > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/nouveau/nouveau_backlight.c | 14 + > drivers/gpu/drm/radeon/atombios_encoders.c | 7 + > drivers/gpu/drm/radeon/radeon_encoders.c | 11 +- > .../gpu/drm/radeon/radeon_legacy_encoders.c | 7 + > drivers/platform/x86/acer-wmi.c | 66 --- > drivers/platform/x86/apple-gmux.c | 3 - > drivers/platform/x86/asus-nb-wmi.c | 21 - > drivers/platform/x86/asus-wmi.c | 13 - > drivers/platform/x86/asus-wmi.h | 2 - > drivers/platform/x86/eeepc-wmi.c | 25 +- > drivers/platform/x86/samsung-laptop.c | 87 ---- > drivers/platform/x86/toshiba_acpi.c | 16 - > include/acpi/video.h | 9 +- > 26 files changed, 468 insertions(+), 415 deletions(-) > > -- > 2.36.0 >
I assume you're probably good on review for the non-nouveau stuff, but if you end up needing any help with that feel free to poke me! On Tue, 2022-07-12 at 21:38 +0200, Hans de Goede wrote: > Hi All, > > As mentioned in my RFC titled "drm/kms: control display brightness through > drm_connector properties": > https://lore.kernel.org/dri-devel/0d188965-d809-81b5-74ce-7d30c49fee2d@redhat.com/ > > The first step towards this is to deal with some existing technical debt > in backlight handling on x86/ACPI boards, specifically we need to stop > registering multiple /sys/class/backlight devs for a single display. > > This series implements my RFC describing my plan for these cleanups: > https://lore.kernel.org/dri-devel/98519ba0-7f18-201a-ea34-652f50343158@redhat.com/ > > This new version addresses the few small remarks made on version 1 (mainly > changing patch 1/29) and more importantly this finishes the refactoring by > else addressing all the bits from the "Other issues" section of > the refactor RFC (resulting in patches 15-29 which are new in v2). > > Please review and test! I hope to be able to make an immutable branch > based on 5.20-rc1 + this series available for merging into the various > touched subsystems once 5.20-rc2 is out. > > Regards, > > Hans > > > Hans de Goede (29): > ACPI: video: Add acpi_video_backlight_use_native() helper > drm/i915: Don't register backlight when another backlight should be > used > drm/amdgpu: Don't register backlight when another backlight should be > used > drm/radeon: Don't register backlight when another backlight should be > used > drm/nouveau: Don't register backlight when another backlight should be > used > ACPI: video: Drop backlight_device_get_by_type() call from > acpi_video_get_backlight_type() > ACPI: video: Remove acpi_video_bus from list before tearing it down > ACPI: video: Simplify acpi_video_unregister_backlight() > ACPI: video: Make backlight class device registration a separate step > ACPI: video: Remove code to unregister acpi_video backlight when a > native backlight registers > drm/i915: Call acpi_video_register_backlight() (v2) > drm/nouveau: Register ACPI video backlight when nv_backlight > registration fails > drm/amdgpu: Register ACPI video backlight when skipping amdgpu > backlight registration > drm/radeon: Register ACPI video backlight when skipping radeon > backlight registration > ACPI: video: Refactor acpi_video_get_backlight_type() a bit > ACPI: video: Add Nvidia WMI EC brightness control detection > ACPI: video: Add Apple GMUX brightness control detection > platform/x86: apple-gmux: Stop calling acpi/video.h functions > platform/x86: toshiba_acpi: Stop using > acpi_video_set_dmi_backlight_type() > platform/x86: acer-wmi: Move backlight DMI quirks to > acpi/video_detect.c > platform/x86: asus-wmi: Drop DMI chassis-type check from backlight > handling > platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI > video_detect.c > platform/x86: asus-wmi: Move acpi_backlight=native quirks to ACPI > video_detect.c > platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] > quirks to ACPI video_detect.c > ACPI: video: Remove acpi_video_set_dmi_backlight_type() > ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk > ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native > quirks > ACPI: video: Fix indentation of video_detect_dmi_table[] entries > drm/todo: Add entry about dealing with brightness control on devices > with > 1 panel > > Documentation/gpu/todo.rst | 68 +++ > drivers/acpi/Kconfig | 1 + > drivers/acpi/acpi_video.c | 59 ++- > drivers/acpi/video_detect.c | 415 +++++++++++------- > drivers/gpu/drm/Kconfig | 12 + > .../gpu/drm/amd/amdgpu/atombios_encoders.c | 14 +- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + > drivers/gpu/drm/gma500/Kconfig | 2 + > drivers/gpu/drm/i915/Kconfig | 2 + > .../gpu/drm/i915/display/intel_backlight.c | 7 + > drivers/gpu/drm/i915/display/intel_display.c | 8 + > drivers/gpu/drm/i915/display/intel_panel.c | 3 + > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/nouveau/nouveau_backlight.c | 14 + > drivers/gpu/drm/radeon/atombios_encoders.c | 7 + > drivers/gpu/drm/radeon/radeon_encoders.c | 11 +- > .../gpu/drm/radeon/radeon_legacy_encoders.c | 7 + > drivers/platform/x86/acer-wmi.c | 66 --- > drivers/platform/x86/apple-gmux.c | 3 - > drivers/platform/x86/asus-nb-wmi.c | 21 - > drivers/platform/x86/asus-wmi.c | 13 - > drivers/platform/x86/asus-wmi.h | 2 - > drivers/platform/x86/eeepc-wmi.c | 25 +- > drivers/platform/x86/samsung-laptop.c | 87 ---- > drivers/platform/x86/toshiba_acpi.c | 16 - > include/acpi/video.h | 9 +- > 26 files changed, 468 insertions(+), 415 deletions(-) >
On Tue, Jul 12, 2022 at 08:39:32PM -0000, Patchwork wrote: > Patch Details > > Series: drm/kms: Stop registering multiple /sys/class/backlight devs > for a single display (rev2) > URL: [1]https://patchwork.freedesktop.org/series/104084/ > State: failure > Details: > [2]https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/index.ht > ml > > CI Bug Log - changes from CI_DRM_11877 -> Patchwork_104084v2 > > Summary > > FAILURE > > Serious unknown changes coming with Patchwork_104084v2 absolutely need > to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_104084v2, please notify your bug team to allow > them > to document this new failure mode, which will reduce false positives in > CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/index.html > > Participating hosts (39 -> 33) > > Missing (6): bat-dg1-5 bat-dg2-8 bat-adlp-6 bat-adln-1 bat-rpls-2 > bat-jsl-1 > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_104084v2: > > IGT changes > > Possible regressions > > * igt@i915_selftest@live@evict: > + fi-bdw-5557u: [3]PASS -> [4]INCOMPLETE > > Known issues > > Here are the changes found in Patchwork_104084v2 that come from known > issues: > > CI changes > > Issues hit > > * boot: > + fi-bxt-dsi: [5]PASS -> [6]FAIL ([7]i915#6003) > > IGT changes > > Issues hit > > * igt@i915_pm_backlight@basic-brightness: > + fi-bsw-kefka: [8]PASS -> [9]SKIP ([10]fdo#109271) > + fi-kbl-soraka: [11]PASS -> [12]SKIP ([13]fdo#109271) Hans, did you have a change to check this? > * igt@i915_selftest@live@gtt: > + fi-bdw-5557u: [14]PASS -> [15]INCOMPLETE ([16]i915#5685) > * igt@kms_chamelium@common-hpd-after-suspend: > + fi-pnv-d510: NOTRUN -> [17]SKIP ([18]fdo#109271) > > Possible fixes > > * igt@i915_module_load@load: > + {fi-tgl-dsi}: [19]DMESG-WARN ([20]i915#1982) -> [21]PASS > * igt@i915_selftest@live@requests: > + fi-pnv-d510: [22]DMESG-FAIL ([23]i915#4528) -> [24]PASS > > {name}: This element is suppressed. This means it is ignored when > computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > Build changes > > * Linux: CI_DRM_11877 -> Patchwork_104084v2 > > CI-20190529: 20190529 > CI_DRM_11877: e55cefc370de5a38ee848aa96082d9d9f4cacdb9 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_6578: 7d289d89131ec37c1145bcdb86149914587d7406 @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_104084v2: e55cefc370de5a38ee848aa96082d9d9f4cacdb9 @ > git://anongit.freedesktop.org/gfx-ci/linux > > Linux commits > > 03434f3a9b5d drm/todo: Add entry about dealing with brightness control > on devices with > 1 panel > f60a678ae3cb ACPI: video: Fix indentation of video_detect_dmi_table[] > entries > 997c977f175b ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU > acpi_backlight=native quirks > d1d4384a3f9c ACPI: video: Drop "Samsung X360" acpi_backlight=native > quirk > 6c3fca7964c0 ACPI: video: Remove acpi_video_set_dmi_backlight_type() > 337df08b0d51 platform/x86: samsung-laptop: Move > acpi_backlight=[vendor|native] quirks to ACPI video_detect.c > 88a0cccaf8a5 platform/x86: asus-wmi: Move acpi_backlight=native quirks > to ACPI video_detect.c > 2c02ab2a967a platform/x86: asus-wmi: Move acpi_backlight=vendor quirks > to ACPI video_detect.c > b544046af222 platform/x86: asus-wmi: Drop DMI chassis-type check from > backlight handling > 47ec79e43441 platform/x86: acer-wmi: Move backlight DMI quirks to > acpi/video_detect.c > 8ac54c7cc01a platform/x86: toshiba_acpi: Stop using > acpi_video_set_dmi_backlight_type() > 2c9a9d9c994e platform/x86: apple-gmux: Stop calling acpi/video.h > functions > b8f094cb3d41 ACPI: video: Add Apple GMUX brightness control detection > 94c7368718d0 ACPI: video: Add Nvidia WMI EC brightness control > detection > 76f5965ce704 ACPI: video: Refactor acpi_video_get_backlight_type() a > bit > 18c8318ff838 drm/radeon: Register ACPI video backlight when skipping > radeon backlight registration > 55191d4ed5dd drm/amdgpu: Register ACPI video backlight when skipping > amdgpu backlight registration > 6bf61ef3e8c1 drm/nouveau: Register ACPI video backlight when > nv_backlight registration fails > c4b53a8741ca drm/i915: Call acpi_video_register_backlight() (v2) > 2632beb4f21e ACPI: video: Remove code to unregister acpi_video > backlight when a native backlight registers > f50e9be5558a ACPI: video: Make backlight class device registration a > separate step > f488f7b8b479 ACPI: video: Simplify acpi_video_unregister_backlight() > c7f3edec1b91 ACPI: video: Remove acpi_video_bus from list before > tearing it down > 50ef46fbcd30 ACPI: video: Drop backlight_device_get_by_type() call from > acpi_video_get_backlight_type() > 7c7ce022fbbb drm/nouveau: Don't register backlight when another > backlight should be used > bd0a8b322333 drm/radeon: Don't register backlight when another > backlight should be used > 28317e03719e drm/amdgpu: Don't register backlight when another > backlight should be used > a657e3a2b224 drm/i915: Don't register backlight when another backlight > should be used > 804bae42c403 ACPI: video: Add acpi_video_backlight_use_native() helper > > References > > 1. https://patchwork.freedesktop.org/series/104084/ > 2. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/index.html > 3. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-bdw-5557u/igt@i915_selftest@live@evict.html > 4. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-bdw-5557u/igt@i915_selftest@live@evict.html > 5. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-bxt-dsi/boot.html > 6. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-bxt-dsi/boot.html > 7. https://gitlab.freedesktop.org/drm/intel/issues/6003 > 8. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-bsw-kefka/igt@i915_pm_backlight@basic-brightness.html > 9. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-bsw-kefka/igt@i915_pm_backlight@basic-brightness.html > 10. https://bugs.freedesktop.org/show_bug.cgi?id=109271 > 11. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-kbl-soraka/igt@i915_pm_backlight@basic-brightness.html > 12. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-kbl-soraka/igt@i915_pm_backlight@basic-brightness.html > 13. https://bugs.freedesktop.org/show_bug.cgi?id=109271 > 14. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-bdw-5557u/igt@i915_selftest@live@gtt.html > 15. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-bdw-5557u/igt@i915_selftest@live@gtt.html > 16. https://gitlab.freedesktop.org/drm/intel/issues/5685 > 17. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html > 18. https://bugs.freedesktop.org/show_bug.cgi?id=109271 > 19. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-tgl-dsi/igt@i915_module_load@load.html > 20. https://gitlab.freedesktop.org/drm/intel/issues/1982 > 21. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-tgl-dsi/igt@i915_module_load@load.html > 22. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11877/fi-pnv-d510/igt@i915_selftest@live@requests.html > 23. https://gitlab.freedesktop.org/drm/intel/issues/4528 > 24. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104084v2/fi-pnv-d510/igt@i915_selftest@live@requests.html
Hi All, As mentioned in my RFC titled "drm/kms: control display brightness through drm_connector properties": https://lore.kernel.org/dri-devel/0d188965-d809-81b5-74ce-7d30c49fee2d@redhat.com/ The first step towards this is to deal with some existing technical debt in backlight handling on x86/ACPI boards, specifically we need to stop registering multiple /sys/class/backlight devs for a single display. This series implements my RFC describing my plan for these cleanups: https://lore.kernel.org/dri-devel/98519ba0-7f18-201a-ea34-652f50343158@redhat.com/ This new version addresses the few small remarks made on version 1 (mainly changing patch 1/29) and more importantly this finishes the refactoring by else addressing all the bits from the "Other issues" section of the refactor RFC (resulting in patches 15-29 which are new in v2). Please review and test! I hope to be able to make an immutable branch based on 5.20-rc1 + this series available for merging into the various touched subsystems once 5.20-rc2 is out. Regards, Hans Hans de Goede (29): ACPI: video: Add acpi_video_backlight_use_native() helper drm/i915: Don't register backlight when another backlight should be used drm/amdgpu: Don't register backlight when another backlight should be used drm/radeon: Don't register backlight when another backlight should be used drm/nouveau: Don't register backlight when another backlight should be used ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type() ACPI: video: Remove acpi_video_bus from list before tearing it down ACPI: video: Simplify acpi_video_unregister_backlight() ACPI: video: Make backlight class device registration a separate step ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers drm/i915: Call acpi_video_register_backlight() (v2) drm/nouveau: Register ACPI video backlight when nv_backlight registration fails drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration drm/radeon: Register ACPI video backlight when skipping radeon backlight registration ACPI: video: Refactor acpi_video_get_backlight_type() a bit ACPI: video: Add Nvidia WMI EC brightness control detection ACPI: video: Add Apple GMUX brightness control detection platform/x86: apple-gmux: Stop calling acpi/video.h functions platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type() platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c platform/x86: asus-wmi: Move acpi_backlight=native quirks to ACPI video_detect.c platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] quirks to ACPI video_detect.c ACPI: video: Remove acpi_video_set_dmi_backlight_type() ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks ACPI: video: Fix indentation of video_detect_dmi_table[] entries drm/todo: Add entry about dealing with brightness control on devices with > 1 panel Documentation/gpu/todo.rst | 68 +++ drivers/acpi/Kconfig | 1 + drivers/acpi/acpi_video.c | 59 ++- drivers/acpi/video_detect.c | 415 +++++++++++------- drivers/gpu/drm/Kconfig | 12 + .../gpu/drm/amd/amdgpu/atombios_encoders.c | 14 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + drivers/gpu/drm/gma500/Kconfig | 2 + drivers/gpu/drm/i915/Kconfig | 2 + .../gpu/drm/i915/display/intel_backlight.c | 7 + drivers/gpu/drm/i915/display/intel_display.c | 8 + drivers/gpu/drm/i915/display/intel_panel.c | 3 + drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/nouveau/nouveau_backlight.c | 14 + drivers/gpu/drm/radeon/atombios_encoders.c | 7 + drivers/gpu/drm/radeon/radeon_encoders.c | 11 +- .../gpu/drm/radeon/radeon_legacy_encoders.c | 7 + drivers/platform/x86/acer-wmi.c | 66 --- drivers/platform/x86/apple-gmux.c | 3 - drivers/platform/x86/asus-nb-wmi.c | 21 - drivers/platform/x86/asus-wmi.c | 13 - drivers/platform/x86/asus-wmi.h | 2 - drivers/platform/x86/eeepc-wmi.c | 25 +- drivers/platform/x86/samsung-laptop.c | 87 ---- drivers/platform/x86/toshiba_acpi.c | 16 - include/acpi/video.h | 9 +- 26 files changed, 468 insertions(+), 415 deletions(-)