From patchwork Wed Sep 14 07:12:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kandpal, Suraj" X-Patchwork-Id: 12975704 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12F7AECAAD8 for ; Wed, 14 Sep 2022 07:13:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE23910E422; Wed, 14 Sep 2022 07:13:40 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFF5B10E422 for ; Wed, 14 Sep 2022 07:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663139611; x=1694675611; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kv2LL6+qgyKdpmz4susJnLQjzqxXnG9+gl8iM9lxbq0=; b=J94jUEppeOCyJUIl5JEpkwX1Lm1JAFgVA3s2gnrCDQ+gs55j1ml+8zWM tqZvYMxypKXT1RclzSIv6S9PUwoUHmzWbJ/bcKyfH6XyO4YTKgOJOXQDo agsTyZQF2xkUay6ufM324yaQD2d4vKzCg23qCxpwQ/mnht1RFxYqETuGF lXq9cH2E2jaHSJ5C+f4ruBQgyBmc/xqRyKG+dPtSHS/h592AINxFNuHSi X7JW696k0/+CHYv31TJVuu6Mkdta3GJYgsVKltqb+CxSljgENTlcZFQ/k lf+PRKXMMfqu7hj6FhhkNlU+jmADshc1u6AKioE6pZWeJzBdLAZufQCb0 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="299170976" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="299170976" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 00:13:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="567904150" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.32]) by orsmga003.jf.intel.com with ESMTP; 14 Sep 2022 00:13:28 -0700 From: "Kandpal, Suraj" To: intel-gfx@lists.freedesktop.org Date: Wed, 14 Sep 2022 12:42:25 +0530 Message-Id: <20220914071228.1595878-1-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v4 0/3] Enable Pipewriteback X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" A patch series was floated in the drm mailing list which aimed to change the drm_connector and drm_encoder fields to pointer in the drm_connector_writeback structure, this received a huge pushback from the community but since i915 expects each connector present in the drm_device list to be a intel_connector but drm_writeback framework makes us have a connector which cannot be embedded in an intel_connector structure. [1] https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/ [2] https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/ Since no one had an issue with encoder field being changed into a pointer it was decided to break the connector and encoder pointer changes into two different series.The encoder field changes is currently being worked upon by Abhinav Kumar and the changes have been merged. [3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565 Going forward we use a drm_connector which is not embedded in intel_connector. We also create a intel_encoder to avoid changes to many iterators but no intel_connector. We also changed all iterators that ---v2 solving BAT issues ---v3 -removing unecessary comments from i915_reg.h [Arun] -moving wd_init into its own if condition [Arun] -fixing comment styling and alignment in intel_wd.c [Arun] -removing continue from loop and calling function if condition is met [Arun] -removing useless arguments from intel_queue_writeback_job and intel_enabling_capture [Arun] --v4 Adding Reviewed-by to patches which were previously reviewd Suraj Kandpal (3): drm/i915: Define WD trancoder for i915 drm/i915 : Changing intel_connector iterators drm/i915: Enabling WD Transcoder drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_acpi.c | 1 + drivers/gpu/drm/i915/display/intel_crtc.c | 6 + .../drm/i915/display/intel_crtc_state_dump.c | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 6 + drivers/gpu/drm/i915/display/intel_display.c | 68 +- drivers/gpu/drm/i915/display/intel_display.h | 18 +- .../drm/i915/display/intel_display_debugfs.c | 13 +- .../drm/i915/display/intel_display_types.h | 32 +- drivers/gpu/drm/i915/display/intel_dpll.c | 6 + .../drm/i915/display/intel_modeset_setup.c | 119 ++- .../drm/i915/display/intel_modeset_verify.c | 17 +- drivers/gpu/drm/i915/display/intel_opregion.c | 3 + drivers/gpu/drm/i915/display/intel_wd.c | 695 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_wd.h | 48 ++ drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 8 +- drivers/gpu/drm/i915/i915_pci.c | 7 +- drivers/gpu/drm/i915/i915_reg.h | 137 ++++ 19 files changed, 1132 insertions(+), 55 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h