mbox series

[v3,0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types

Message ID 20221019072930.17755-1-alan.previn.teres.alexis@intel.com (mailing list archive)
Headers show
Series drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types | expand

Message

Teres Alexis, Alan Previn Oct. 19, 2022, 7:29 a.m. UTC
After initial upstream merge of GuC error-capture feature, we eventually
decided to remove a lot of unnecessary warning messages when we couldn't
retrieve register lists for ADS-error-state-capture initialization. It was
a justified decision because the majority of that noise was being repeated
three times per GT reset and included list-types that are not supported
upstream. However after that change, we are not able to catch cases of
missing register lists for new engines that hadn't been added.

This series introduces new selective checks and warnings (such as skipping
if its a VF or if its an empty register list). This series also adds register
list for compute engine which is merely a duplicate of render class list.

Changes from prior revs:

   v2 : - Fix build error.
   v1 : - Fix the drm_warn string split (Tvrtko Ursulin / John Harrison)
        - Minor cosmetics around the drm_warn message checks (Tvrtko Ursulin /
          John Harrison)
        - Dont use empy string in stringify functions (Tvrtko Ursulin)
        - Ensure guc_capture_output_min_size_est doesn't trigger
          the drm_warn when calculating estimation size for worst case
          engine counts that may not exist (Alan Previn).

Alan Previn (2):
  drm/i915/guc: Add error-capture init warnings when needed
  drm/i915/guc: Add compute reglist for guc err capture

 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 82 +++++++++++++++++--
 1 file changed, 73 insertions(+), 9 deletions(-)


base-commit: b249abef9f86f788e6bacc657ae8eb7743948200

Comments

Teres Alexis, Alan Previn Oct. 24, 2022, 8:25 p.m. UTC | #1
I believe that the issues below are not related to this series because they were running on platforms that do not use guc-submission. Additionally, both patches of this series impact steps very early in the guc initialization phase and never again - and do not impact runtime operation of display. That said, an issue if resulting from this series were to occur, it would be noticed very early in the i915 loading process.

...alan

On Wed, 2022-10-19 at 15:54 +0000, Patchwork wrote:
Patch Details
Series: drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)
URL:    https://patchwork.freedesktop.org/series/109737/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/index.html
CI Bug Log - changes from CI_DRM_12259_full -> Patchwork_109737v3_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_109737v3_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109737v3_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (9 -> 11)

Additional (2): shard-rkl shard-dg1

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_109737v3_full:

IGT changes
Possible regressions

  *   igt@i915_suspend@fence-restore-tiled2untiled:

     *   shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html>
  *   igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk3/igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk5/igt@kms_plane_lowres@tiling-none@pipe-c-hdmi-a-2.html> +1 similar issue

Warnings

  *   igt@gem_pwrite@basic-exhaustion:

     *   shard-glk: WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-glk9/igt@gem_pwrite@basic-exhaustion.html> (i915#2658<https://gitlab.freedesktop.org/drm/intel/issues/2658>) ->INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-glk8/igt@gem_pwrite@basic-exhaustion.html>
  *   igt@runner@aborted:

     *   shard-skl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@runner@aborted.html>,FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl4/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl5/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl2/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl9/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12259/shard-skl1/igt@runner@aborted.html>) (i915#3002<https://gitlab.freedesktop.org/drm/intel/issues/3002> /i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312> / i915#6949<https://gitlab.freedesktop.org/drm/intel/issues/6949>) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl4/igt@runner@aborted.html>,FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl10/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109737v3/shard-skl1/igt@runner@aborted.html>) (i915#4312<https://gitlab.freedesktop.org/drm/intel/issues/4312>)