mbox series

[0/9] drm/i915/dvo: DVO init fixes/cleanps

Message ID 20221118105525.27254-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915/dvo: DVO init fixes/cleanps | expand

Message

Ville Syrjala Nov. 18, 2022, 10:55 a.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The DVO encoder init code is meesy. Try to clean it
up a bit, and fix a few buglets while at it.

Ville Syrjälä (9):
  drm/i915/dvo: Remove unused panel_wants_dither
  drm/i915/dvo: Don't leak connector state on DVO init failure
  drm/i915/dvo: Actually initialize the DVO encoder type
  drm/i915/dvo: Introduce intel_dvo_connector_type()
  drm/i915/dvo: Eliminate useless 'port' variable
  drm/i915/dvo: Flatten intel_dvo_init()
  drm/i915/dvo: s/intel_encoder/encoder/ etc.
  drm/i915/dvo: s/dev_priv/i915/
  drm/i915/dvo: Use per device debugs

 drivers/gpu/drm/i915/display/intel_dvo.c | 375 ++++++++++++-----------
 1 file changed, 201 insertions(+), 174 deletions(-)

Comments

Jani Nikula Nov. 18, 2022, 11:39 a.m. UTC | #1
On Fri, 18 Nov 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The DVO encoder init code is meesy. Try to clean it
> up a bit, and fix a few buglets while at it.

On the series,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Ville Syrjälä (9):
>   drm/i915/dvo: Remove unused panel_wants_dither
>   drm/i915/dvo: Don't leak connector state on DVO init failure
>   drm/i915/dvo: Actually initialize the DVO encoder type
>   drm/i915/dvo: Introduce intel_dvo_connector_type()
>   drm/i915/dvo: Eliminate useless 'port' variable
>   drm/i915/dvo: Flatten intel_dvo_init()
>   drm/i915/dvo: s/intel_encoder/encoder/ etc.
>   drm/i915/dvo: s/dev_priv/i915/
>   drm/i915/dvo: Use per device debugs
>
>  drivers/gpu/drm/i915/display/intel_dvo.c | 375 ++++++++++++-----------
>  1 file changed, 201 insertions(+), 174 deletions(-)