mbox series

[v3,0/8] GuC oriented print macros

Message ID 20230128195907.1837-1-michal.wajdeczko@intel.com (mailing list archive)
Headers show
Series GuC oriented print macros | expand

Message

Michal Wajdeczko Jan. 28, 2023, 7:58 p.m. UTC
This is a follow up series for existing commit 67804e48b494
("drm/i915/gt: Start adding module oriented dmesg output")
that was focusing just on the GT.

Now extend changes to uc/ folder and focus on the GuC.

v2: applying feedback from John
v3: more feedback from John

Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>	

Michal Wajdeczko (8):
  drm/i915/guc: Add GuC oriented print macros
  drm/i915/guc: Update GuC messages in intel_guc.c
  drm/i915/guc: Update GuC messages in intel_guc_ads.c
  drm/i915/guc: Update GuC messages in intel_guc_ct.c
  drm/i915/guc: Update GuC messages in intel_guc_fw.c
  drm/i915/guc: Update GuC messages in intel_guc_log.c
  drm/i915/guc: Update GuC messages in intel_guc_submission.c
  drm/i915/guc: Update GT/GuC messages in intel_uc.c

 drivers/gpu/drm/i915/gt/uc/intel_guc.c        | 31 ++++---
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  8 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     | 23 +-----
 drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c     | 17 ++--
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c    | 38 ++++-----
 drivers/gpu/drm/i915/gt/uc/intel_guc_print.h  | 48 +++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 61 ++++++--------
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         | 80 +++++++++----------
 8 files changed, 164 insertions(+), 142 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_print.h

Comments

Tvrtko Ursulin Jan. 31, 2023, 12:25 p.m. UTC | #1
On 28/01/2023 22:11, Patchwork wrote:
> *Patch Details*
> *Series:*	GuC oriented print macros (rev3)
> *URL:*	https://patchwork.freedesktop.org/series/113162/ 
> <https://patchwork.freedesktop.org/series/113162/>
> *State:*	success
> *Details:* 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/index.html 
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/index.html>
> 
> 
>   CI Bug Log - changes from CI_DRM_12658_full -> Patchwork_113162v3_full
> 
> 
>     Summary
> 
> *SUCCESS*
> 
> No regressions found.

Pushed to drm-intel-gt-next, thanks for the patches and reviews!

Regards,

Tvrtko

> 
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/index.html
> 
> 
>     Participating hosts (10 -> 10)
> 
> No changes in participating hosts
> 
> 
>     Possible new issues
> 
> Here are the unknown changes that may have been introduced in 
> Patchwork_113162v3_full:
> 
> 
>       IGT changes
> 
> 
>         Suppressed
> 
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
> 
>   *
> 
>     igt@gem_exec_suspend@basic-s3-devices@smem:
> 
>       o {shard-rkl}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-6/igt@gem_exec_suspend@basic-s3-devices@smem.html> -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-3/igt@gem_exec_suspend@basic-s3-devices@smem.html>
>   *
> 
>     igt@gem_exec_whisper@basic-fds-priority-all:
> 
>       o {shard-tglu-10}: NOTRUN -> INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-tglu-10/igt@gem_exec_whisper@basic-fds-priority-all.html>
> 
> 
>     Known issues
> 
> Here are the changes found in Patchwork_113162v3_full that come from 
> known issues:
> 
> 
>       IGT changes
> 
> 
>         Issues hit
> 
>   * igt@gem_exec_fair@basic-pace-solo@rcs0:
>       o shard-glk: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html> -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html> (i915#2842 <https://gitlab.freedesktop.org/drm/intel/issues/2842>)
> 
> 
>         Possible fixes
> 
>   *
> 
>     igt@drm_fdinfo@idle@rcs0:
> 
>       o {shard-rkl}: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-4/igt@drm_fdinfo@idle@rcs0.html> (i915#7742 <https://gitlab.freedesktop.org/drm/intel/issues/7742>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-1/igt@drm_fdinfo@idle@rcs0.html>
>   *
> 
>     igt@fbdev@eof:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-1/igt@fbdev@eof.html> (i915#2582 <https://gitlab.freedesktop.org/drm/intel/issues/2582>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@fbdev@eof.html> +1 similar issue
>   *
> 
>     igt@gem_exec_capture@pi@vcs0:
> 
>       o {shard-rkl}: ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-6/igt@gem_exec_capture@pi@vcs0.html> -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-4/igt@gem_exec_capture@pi@vcs0.html>
>   *
> 
>     igt@gem_exec_reloc@basic-gtt-wc-noreloc:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-2/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html> (i915#3281 <https://gitlab.freedesktop.org/drm/intel/issues/3281>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html> +6 similar issues
>   *
> 
>     igt@gem_partial_pwrite_pread@writes-after-reads:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-2/igt@gem_partial_pwrite_pread@writes-after-reads.html> (i915#3282 <https://gitlab.freedesktop.org/drm/intel/issues/3282>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads.html> +3 similar issues
>   *
> 
>     igt@gem_sync@basic-all:
> 
>       o shard-glk: DMESG-WARN
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-glk4/igt@gem_sync@basic-all.html> (i915#118 <https://gitlab.freedesktop.org/drm/intel/issues/118>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-glk1/igt@gem_sync@basic-all.html>
>   *
> 
>     igt@gen9_exec_parse@unaligned-access:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-2/igt@gen9_exec_parse@unaligned-access.html> (i915#2527 <https://gitlab.freedesktop.org/drm/intel/issues/2527>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-5/igt@gen9_exec_parse@unaligned-access.html> +1 similar issue
>   *
> 
>     igt@i915_pipe_stress@stress-xrgb8888-ytiled:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-1/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html> (i915#4098 <https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html>
>   *
> 
>     igt@i915_pm_dc@dc9-dpms:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html> (i915#3361 <https://gitlab.freedesktop.org/drm/intel/issues/3361>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-1/igt@i915_pm_dc@dc9-dpms.html>
>   *
> 
>     igt@i915_pm_rc6_residency@rc6-idle@vcs0:
> 
>       o {shard-rkl}: WARN
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-5/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html> (i915#2681 <https://gitlab.freedesktop.org/drm/intel/issues/2681>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-1/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html>
>   *
> 
>     igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
> 
>       o shard-glk: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html> (i915#2346 <https://gitlab.freedesktop.org/drm/intel/issues/2346>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html>
>   *
> 
>     igt@kms_dp_aux_dev:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-4/igt@kms_dp_aux_dev.html> (i915#1257 <https://gitlab.freedesktop.org/drm/intel/issues/1257>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@kms_dp_aux_dev.html>
>   *
> 
>     igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
> 
>       o shard-glk: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html> (i915#79 <https://gitlab.freedesktop.org/drm/intel/issues/79>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html>
>   *
> 
>     igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html> (i915#1849 <https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#4098 <https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html> +21 similar issues
>   *
> 
>     igt@kms_psr@primary_mmap_gtt:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-2/igt@kms_psr@primary_mmap_gtt.html> (i915#1072 <https://gitlab.freedesktop.org/drm/intel/issues/1072>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@kms_psr@primary_mmap_gtt.html> +1 similar issue
>   *
> 
>     igt@kms_universal_plane@universal-plane-pipe-a-functional:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-1/igt@kms_universal_plane@universal-plane-pipe-a-functional.html> (i915#1845 <https://gitlab.freedesktop.org/drm/intel/issues/1845> / i915#4070 <https://gitlab.freedesktop.org/drm/intel/issues/4070> / i915#4098 <https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-a-functional.html>
>   *
> 
>     igt@kms_vblank@pipe-b-query-idle:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-2/igt@kms_vblank@pipe-b-query-idle.html> (i915#1845 <https://gitlab.freedesktop.org/drm/intel/issues/1845> / i915#4098 <https://gitlab.freedesktop.org/drm/intel/issues/4098>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-6/igt@kms_vblank@pipe-b-query-idle.html> +23 similar issues
>   *
> 
>     igt@perf@mi-rpc:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-3/igt@perf@mi-rpc.html> (i915#2434 <https://gitlab.freedesktop.org/drm/intel/issues/2434>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-5/igt@perf@mi-rpc.html>
>   *
> 
>     igt@prime_vgem@coherency-gtt:
> 
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12658/shard-rkl-3/igt@prime_vgem@coherency-gtt.html> (fdo#109295 <https://bugs.freedesktop.org/show_bug.cgi?id=109295> / fdo#111656 <https://bugs.freedesktop.org/show_bug.cgi?id=111656> / i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v3/shard-rkl-5/igt@prime_vgem@coherency-gtt.html>
> 
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> 
>     Build changes
> 
>   * Linux: CI_DRM_12658 -> Patchwork_113162v3
> 
> CI-20190529: 20190529
> CI_DRM_12658: a9e72f4e0baf2e3e306da0063f98099044d85285 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7141: a978df7912acda18eada1b1d2ae4b438ed3e940b @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_113162v3: a9e72f4e0baf2e3e306da0063f98099044d85285 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>