| Message ID | 20230222053153.3658345-1-suraj.kandpal@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enable YCbCr420 format for VDSC | expand |
On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > This patch series aims to enable the YCbCr420 format > for DSC. Changes are mostly compute params related for > hdmi,dp and dsi along with the addition of new rc_tables > for native_420 and corresponding changes to macros used to > fetch them. > There have been discussions prior to this series in which some patches > have gotten rb and can be found in the below link > https://patchwork.freedesktop.org/series/113729 I think it would be useful to get [1] from Dmitry merged to drm-misc-next first, have that in drm-next, and again backmerged to drm-intel-next before this. At least patches 1-5. There's not much point in all drivers duplicating the parameters, and we need to move towards common code. Dmitry has been helpful in contributing this to us. BR, Jani. [1] https://patchwork.freedesktop.org/series/114473/ > > Ankit Nautiyal (2): > drm/dp_helper: Add helper to check DSC support with given o/p format > drm/i915/dp: Check if DSC supports the given output_format > > Suraj Kandpal (4): > drm/i915: Adding the new registers for DSC > drm/i915: Enable YCbCr420 for VDSC > drm/i915/display: Fill in native_420 field > drm/i915/vdsc: Check slice design requirement > > Swati Sharma (1): > drm/i915/dsc: Add debugfs entry to validate DSC output formats > > drivers/gpu/drm/i915/display/icl_dsi.c | 2 - > .../drm/i915/display/intel_crtc_state_dump.c | 4 +- > .../drm/i915/display/intel_crtc_state_dump.h | 2 + > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ > .../drm/i915/display/intel_display_types.h | 1 + > drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- > .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- > .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- > drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- > drivers/gpu/drm/i915/i915_reg.h | 28 +++ > include/drm/display/drm_dp_helper.h | 13 ++ > 11 files changed, 442 insertions(+), 24 deletions(-)
On 08/03/2023 13:30, Jani Nikula wrote: > On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: >> This patch series aims to enable the YCbCr420 format >> for DSC. Changes are mostly compute params related for >> hdmi,dp and dsi along with the addition of new rc_tables >> for native_420 and corresponding changes to macros used to >> fetch them. >> There have been discussions prior to this series in which some patches >> have gotten rb and can be found in the below link >> https://patchwork.freedesktop.org/series/113729 > > I think it would be useful to get [1] from Dmitry merged to > drm-misc-next first, have that in drm-next, and again backmerged to > drm-intel-next before this. At least patches 1-5. > > There's not much point in all drivers duplicating the parameters, and we > need to move towards common code. Dmitry has been helpful in > contributing this to us. Note, while I slightly reworked the calculate_rc_params() function, I did not touch the intel_qp_tables (mostly since we do not need them for drm/msm (at least for now). Our current plan is to use fixed params (at least in the short notice). We might have to reconsider it at some point. However it might be wise to merge them with amdgpu's qp tables. amdgpu driver also contains code to calculate RC params. It might be worth moving RC calculation to the common helper. > > BR, > Jani. > > > [1] https://patchwork.freedesktop.org/series/114473/ > >> >> Ankit Nautiyal (2): >> drm/dp_helper: Add helper to check DSC support with given o/p format >> drm/i915/dp: Check if DSC supports the given output_format >> >> Suraj Kandpal (4): >> drm/i915: Adding the new registers for DSC >> drm/i915: Enable YCbCr420 for VDSC >> drm/i915/display: Fill in native_420 field >> drm/i915/vdsc: Check slice design requirement >> >> Swati Sharma (1): >> drm/i915/dsc: Add debugfs entry to validate DSC output formats >> >> drivers/gpu/drm/i915/display/icl_dsi.c | 2 - >> .../drm/i915/display/intel_crtc_state_dump.c | 4 +- >> .../drm/i915/display/intel_crtc_state_dump.h | 2 + >> .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ >> .../drm/i915/display/intel_display_types.h | 1 + >> drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- >> .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- >> .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- >> drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- >> drivers/gpu/drm/i915/i915_reg.h | 28 +++ >> include/drm/display/drm_dp_helper.h | 13 ++ >> 11 files changed, 442 insertions(+), 24 deletions(-) >
On Wed, 08 Mar 2023, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > On 08/03/2023 13:30, Jani Nikula wrote: >> On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: >>> This patch series aims to enable the YCbCr420 format >>> for DSC. Changes are mostly compute params related for >>> hdmi,dp and dsi along with the addition of new rc_tables >>> for native_420 and corresponding changes to macros used to >>> fetch them. >>> There have been discussions prior to this series in which some patches >>> have gotten rb and can be found in the below link >>> https://patchwork.freedesktop.org/series/113729 >> >> I think it would be useful to get [1] from Dmitry merged to >> drm-misc-next first, have that in drm-next, and again backmerged to >> drm-intel-next before this. At least patches 1-5. >> >> There's not much point in all drivers duplicating the parameters, and we >> need to move towards common code. Dmitry has been helpful in >> contributing this to us. > > Note, while I slightly reworked the calculate_rc_params() function, I > did not touch the intel_qp_tables (mostly since we do not need them for > drm/msm (at least for now). Our current plan is to use fixed params (at > least in the short notice). We might have to reconsider it at some point. Yeah, this isn't a big conflict, but AFAICT it'll conflict in intel_vdsc.c. > However it might be wise to merge them with amdgpu's qp tables. amdgpu > driver also contains code to calculate RC params. It might be worth > moving RC calculation to the common helper. Agreed. BR, Jani. > >> >> BR, >> Jani. >> >> >> [1] https://patchwork.freedesktop.org/series/114473/ >> >>> >>> Ankit Nautiyal (2): >>> drm/dp_helper: Add helper to check DSC support with given o/p format >>> drm/i915/dp: Check if DSC supports the given output_format >>> >>> Suraj Kandpal (4): >>> drm/i915: Adding the new registers for DSC >>> drm/i915: Enable YCbCr420 for VDSC >>> drm/i915/display: Fill in native_420 field >>> drm/i915/vdsc: Check slice design requirement >>> >>> Swati Sharma (1): >>> drm/i915/dsc: Add debugfs entry to validate DSC output formats >>> >>> drivers/gpu/drm/i915/display/icl_dsi.c | 2 - >>> .../drm/i915/display/intel_crtc_state_dump.c | 4 +- >>> .../drm/i915/display/intel_crtc_state_dump.h | 2 + >>> .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ >>> .../drm/i915/display/intel_display_types.h | 1 + >>> drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- >>> .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- >>> .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- >>> drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- >>> drivers/gpu/drm/i915/i915_reg.h | 28 +++ >>> include/drm/display/drm_dp_helper.h | 13 ++ >>> 11 files changed, 442 insertions(+), 24 deletions(-) >>
> -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Jani > Nikula > Sent: Wednesday, March 8, 2023 5:00 PM > To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- > devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, Ankit K > <ankit.k.nautiyal@intel.com>; Shankar, Uma <uma.shankar@intel.com>; > Kandpal, Suraj <suraj.kandpal@intel.com> > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > > This patch series aims to enable the YCbCr420 format for DSC. Changes > > are mostly compute params related for hdmi,dp and dsi along with the > > addition of new rc_tables for native_420 and corresponding changes to > > macros used to fetch them. > > There have been discussions prior to this series in which some patches > > have gotten rb and can be found in the below link > > https://patchwork.freedesktop.org/series/113729 > > I think it would be useful to get [1] from Dmitry merged to drm-misc-next > first, have that in drm-next, and again backmerged to drm-intel-next before > this. At least patches 1-5. > > There's not much point in all drivers duplicating the parameters, and we > need to move towards common code. Dmitry has been helpful in > contributing this to us. > > BR, > Jani. > > Hi Jani, Maarten has acked the patch series to be merged through drm-intel and in the meantime I will work with Dmitry to pull the common code to avoid duplication Regards, Suraj Kandpal > [1] https://patchwork.freedesktop.org/series/114473/ > > > > > Ankit Nautiyal (2): > > drm/dp_helper: Add helper to check DSC support with given o/p format > > drm/i915/dp: Check if DSC supports the given output_format > > > > Suraj Kandpal (4): > > drm/i915: Adding the new registers for DSC > > drm/i915: Enable YCbCr420 for VDSC > > drm/i915/display: Fill in native_420 field > > drm/i915/vdsc: Check slice design requirement > > > > Swati Sharma (1): > > drm/i915/dsc: Add debugfs entry to validate DSC output formats > > > > drivers/gpu/drm/i915/display/icl_dsi.c | 2 - > > .../drm/i915/display/intel_crtc_state_dump.c | 4 +- > > .../drm/i915/display/intel_crtc_state_dump.h | 2 + > > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ > > .../drm/i915/display/intel_display_types.h | 1 + > > drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- > > .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- > > .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- > > drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- > > drivers/gpu/drm/i915/i915_reg.h | 28 +++ > > include/drm/display/drm_dp_helper.h | 13 ++ > > 11 files changed, 442 insertions(+), 24 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center
On Tue, 28 Mar 2023 at 16:20, Kandpal, Suraj <suraj.kandpal@intel.com> wrote: > > -----Original Message----- > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Jani > > Nikula > > Sent: Wednesday, March 8, 2023 5:00 PM > > To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- > > devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, Ankit K > > <ankit.k.nautiyal@intel.com>; Shankar, Uma <uma.shankar@intel.com>; > > Kandpal, Suraj <suraj.kandpal@intel.com> > > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > > > On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > > > This patch series aims to enable the YCbCr420 format for DSC. Changes > > > are mostly compute params related for hdmi,dp and dsi along with the > > > addition of new rc_tables for native_420 and corresponding changes to > > > macros used to fetch them. > > > There have been discussions prior to this series in which some patches > > > have gotten rb and can be found in the below link > > > https://patchwork.freedesktop.org/series/113729 > > > > I think it would be useful to get [1] from Dmitry merged to drm-misc-next > > first, have that in drm-next, and again backmerged to drm-intel-next before > > this. At least patches 1-5. > > > > There's not much point in all drivers duplicating the parameters, and we > > need to move towards common code. Dmitry has been helpful in > > contributing this to us. > > > > BR, > > Jani. > > > > > > Hi Jani, > Maarten has acked the patch series to be merged through drm-intel and in the meantime > I will work with Dmitry to pull the common code to avoid duplication Thank you! If necessary feel free to ping me on IRC ('lumag'). > > Regards, > Suraj Kandpal > > > [1] https://patchwork.freedesktop.org/series/114473/ > > > > > > > > Ankit Nautiyal (2): > > > drm/dp_helper: Add helper to check DSC support with given o/p format > > > drm/i915/dp: Check if DSC supports the given output_format > > > > > > Suraj Kandpal (4): > > > drm/i915: Adding the new registers for DSC > > > drm/i915: Enable YCbCr420 for VDSC > > > drm/i915/display: Fill in native_420 field > > > drm/i915/vdsc: Check slice design requirement > > > > > > Swati Sharma (1): > > > drm/i915/dsc: Add debugfs entry to validate DSC output formats > > > > > > drivers/gpu/drm/i915/display/icl_dsi.c | 2 - > > > .../drm/i915/display/intel_crtc_state_dump.c | 4 +- > > > .../drm/i915/display/intel_crtc_state_dump.h | 2 + > > > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ > > > .../drm/i915/display/intel_display_types.h | 1 + > > > drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- > > > .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- > > > .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- > > > drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- > > > drivers/gpu/drm/i915/i915_reg.h | 28 +++ > > > include/drm/display/drm_dp_helper.h | 13 ++ > > > 11 files changed, 442 insertions(+), 24 deletions(-) > > > > -- > > Jani Nikula, Intel Open Source Graphics Center
> -----Original Message----- > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Sent: Tuesday, March 28, 2023 6:58 PM > To: Kandpal, Suraj <suraj.kandpal@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com>; dri-devel@lists.freedesktop.org; > intel-gfx@lists.freedesktop.org; Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; > Shankar, Uma <uma.shankar@intel.com>; Maarten Lankhorst > <maarten.lankhorst@linux.intel.com> > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > On Tue, 28 Mar 2023 at 16:20, Kandpal, Suraj <suraj.kandpal@intel.com> wrote: > > > -----Original Message----- > > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf > > > Of Jani Nikula > > > Sent: Wednesday, March 8, 2023 5:00 PM > > > To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- > > > devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, Ankit > > > K <ankit.k.nautiyal@intel.com>; Shankar, Uma > > > <uma.shankar@intel.com>; Kandpal, Suraj <suraj.kandpal@intel.com> > > > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > > > > > On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > > > > This patch series aims to enable the YCbCr420 format for DSC. > > > > Changes are mostly compute params related for hdmi,dp and dsi > > > > along with the addition of new rc_tables for native_420 and > > > > corresponding changes to macros used to fetch them. > > > > There have been discussions prior to this series in which some > > > > patches have gotten rb and can be found in the below link > > > > https://patchwork.freedesktop.org/series/113729 > > > > > > I think it would be useful to get [1] from Dmitry merged to > > > drm-misc-next first, have that in drm-next, and again backmerged to > > > drm-intel-next before this. At least patches 1-5. > > > > > > There's not much point in all drivers duplicating the parameters, > > > and we need to move towards common code. Dmitry has been helpful in > > > contributing this to us. > > > > > > BR, > > > Jani. > > > > > > > > > > Hi Jani, > > Maarten has acked the patch series to be merged through drm-intel and > > in the meantime I will work with Dmitry to pull the common code to > > avoid duplication > > Thank you! If necessary feel free to ping me on IRC ('lumag'). Thanks guys, will help merge the change. Regards, Uma Shankar > > > > Regards, > > Suraj Kandpal > > > > > [1] https://patchwork.freedesktop.org/series/114473/ > > > > > > > > > > > Ankit Nautiyal (2): > > > > drm/dp_helper: Add helper to check DSC support with given o/p format > > > > drm/i915/dp: Check if DSC supports the given output_format > > > > > > > > Suraj Kandpal (4): > > > > drm/i915: Adding the new registers for DSC > > > > drm/i915: Enable YCbCr420 for VDSC > > > > drm/i915/display: Fill in native_420 field > > > > drm/i915/vdsc: Check slice design requirement > > > > > > > > Swati Sharma (1): > > > > drm/i915/dsc: Add debugfs entry to validate DSC output formats > > > > > > > > drivers/gpu/drm/i915/display/icl_dsi.c | 2 - > > > > .../drm/i915/display/intel_crtc_state_dump.c | 4 +- > > > > .../drm/i915/display/intel_crtc_state_dump.h | 2 + > > > > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ > > > > .../drm/i915/display/intel_display_types.h | 1 + > > > > drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- > > > > .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- > > > > .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- > > > > drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- > > > > drivers/gpu/drm/i915/i915_reg.h | 28 +++ > > > > include/drm/display/drm_dp_helper.h | 13 ++ > > > > 11 files changed, 442 insertions(+), 24 deletions(-) > > > > > > -- > > > Jani Nikula, Intel Open Source Graphics Center > > > > -- > With best wishes > Dmitry
> > -----Original Message----- > > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Sent: Tuesday, March 28, 2023 6:58 PM > > To: Kandpal, Suraj <suraj.kandpal@intel.com> > > Cc: Jani Nikula <jani.nikula@linux.intel.com>; > > dri-devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > > Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Shankar, Uma > > <uma.shankar@intel.com>; Maarten Lankhorst > > <maarten.lankhorst@linux.intel.com> > > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > > > On Tue, 28 Mar 2023 at 16:20, Kandpal, Suraj <suraj.kandpal@intel.com> wrote: > > > > -----Original Message----- > > > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On > > > > Behalf Of Jani Nikula > > > > Sent: Wednesday, March 8, 2023 5:00 PM > > > > To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- > > > > devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > > > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, > > > > Ankit K <ankit.k.nautiyal@intel.com>; Shankar, Uma > > > > <uma.shankar@intel.com>; Kandpal, Suraj <suraj.kandpal@intel.com> > > > > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > > > > > > > On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > > > > > This patch series aims to enable the YCbCr420 format for DSC. > > > > > Changes are mostly compute params related for hdmi,dp and dsi > > > > > along with the addition of new rc_tables for native_420 and > > > > > corresponding changes to macros used to fetch them. > > > > > There have been discussions prior to this series in which some > > > > > patches have gotten rb and can be found in the below link > > > > > https://patchwork.freedesktop.org/series/113729 > > > > > > > > I think it would be useful to get [1] from Dmitry merged to > > > > drm-misc-next first, have that in drm-next, and again backmerged > > > > to drm-intel-next before this. At least patches 1-5. > > > > > > > > There's not much point in all drivers duplicating the parameters, > > > > and we need to move towards common code. Dmitry has been helpful > > > > in contributing this to us. > > > > > > > > BR, > > > > Jani. > > > > > > > > > > > > > > Hi Jani, > > > Maarten has acked the patch series to be merged through drm-intel > > > and in the meantime I will work with Dmitry to pull the common code > > > to avoid duplication > > > > Thank you! If necessary feel free to ping me on IRC ('lumag'). > > Thanks guys, will help merge the change. Pushed the changes to drm-intel-next. Thanks for the patches and reviews. Regards, Uma Shankar > > > > > > > Regards, > > > Suraj Kandpal > > > > > > > [1] https://patchwork.freedesktop.org/series/114473/ > > > > > > > > > > > > > > Ankit Nautiyal (2): > > > > > drm/dp_helper: Add helper to check DSC support with given o/p format > > > > > drm/i915/dp: Check if DSC supports the given output_format > > > > > > > > > > Suraj Kandpal (4): > > > > > drm/i915: Adding the new registers for DSC > > > > > drm/i915: Enable YCbCr420 for VDSC > > > > > drm/i915/display: Fill in native_420 field > > > > > drm/i915/vdsc: Check slice design requirement > > > > > > > > > > Swati Sharma (1): > > > > > drm/i915/dsc: Add debugfs entry to validate DSC output formats > > > > > > > > > > drivers/gpu/drm/i915/display/icl_dsi.c | 2 - > > > > > .../drm/i915/display/intel_crtc_state_dump.c | 4 +- > > > > > .../drm/i915/display/intel_crtc_state_dump.h | 2 + > > > > > .../drm/i915/display/intel_display_debugfs.c | 78 ++++++++ > > > > > .../drm/i915/display/intel_display_types.h | 1 + > > > > > drivers/gpu/drm/i915/display/intel_dp.c | 39 +++- > > > > > .../gpu/drm/i915/display/intel_qp_tables.c | 187 ++++++++++++++++-- > > > > > .../gpu/drm/i915/display/intel_qp_tables.h | 4 +- > > > > > drivers/gpu/drm/i915/display/intel_vdsc.c | 108 +++++++++- > > > > > drivers/gpu/drm/i915/i915_reg.h | 28 +++ > > > > > include/drm/display/drm_dp_helper.h | 13 ++ > > > > > 11 files changed, 442 insertions(+), 24 deletions(-) > > > > > > > > -- > > > > Jani Nikula, Intel Open Source Graphics Center > > > > > > > > -- > > With best wishes > > Dmitry
Hi Suraj On 28/03/2023 16:20, Kandpal, Suraj wrote: > > >> -----Original Message----- >> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Jani >> Nikula >> Sent: Wednesday, March 8, 2023 5:00 PM >> To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- >> devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, Ankit K >> <ankit.k.nautiyal@intel.com>; Shankar, Uma <uma.shankar@intel.com>; >> Kandpal, Suraj <suraj.kandpal@intel.com> >> Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC >> >> On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: >>> This patch series aims to enable the YCbCr420 format for DSC. Changes >>> are mostly compute params related for hdmi,dp and dsi along with the >>> addition of new rc_tables for native_420 and corresponding changes to >>> macros used to fetch them. >>> There have been discussions prior to this series in which some patches >>> have gotten rb and can be found in the below link >>> https://patchwork.freedesktop.org/series/113729 >> >> I think it would be useful to get [1] from Dmitry merged to drm-misc-next >> first, have that in drm-next, and again backmerged to drm-intel-next before >> this. At least patches 1-5. >> >> There's not much point in all drivers duplicating the parameters, and we >> need to move towards common code. Dmitry has been helpful in >> contributing this to us. >> >> BR, >> Jani. >> >> > > Hi Jani, > Maarten has acked the patch series to be merged through drm-intel and in the meantime > I will work with Dmitry to pull the common code to avoid duplication I wanted to check, are there any updates from your side regarding the series at [1] ? > > Regards, > Suraj Kandpal > >> [1] https://patchwork.freedesktop.org/series/114473/
Hi Dmitry > -----Original Message----- > From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Sent: Friday, April 7, 2023 8:28 AM > To: Kandpal, Suraj <suraj.kandpal@intel.com>; Jani Nikula > <jani.nikula@linux.intel.com>; dri-devel@lists.freedesktop.org; intel- > gfx@lists.freedesktop.org > Cc: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Shankar, Uma > <uma.shankar@intel.com>; Maarten Lankhorst > <maarten.lankhorst@linux.intel.com> > Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > > Hi Suraj > > On 28/03/2023 16:20, Kandpal, Suraj wrote: > > > > > >> -----Original Message----- > >> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf > >> Of Jani Nikula > >> Sent: Wednesday, March 8, 2023 5:00 PM > >> To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- > >> devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, Ankit K > >> <ankit.k.nautiyal@intel.com>; Shankar, Uma <uma.shankar@intel.com>; > >> Kandpal, Suraj <suraj.kandpal@intel.com> > >> Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC > >> > >> On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: > >>> This patch series aims to enable the YCbCr420 format for DSC. > >>> Changes are mostly compute params related for hdmi,dp and dsi along > >>> with the addition of new rc_tables for native_420 and corresponding > >>> changes to macros used to fetch them. > >>> There have been discussions prior to this series in which some > >>> patches have gotten rb and can be found in the below link > >>> https://patchwork.freedesktop.org/series/113729 > >> > >> I think it would be useful to get [1] from Dmitry merged to > >> drm-misc-next first, have that in drm-next, and again backmerged to > >> drm-intel-next before this. At least patches 1-5. > >> > >> There's not much point in all drivers duplicating the parameters, and > >> we need to move towards common code. Dmitry has been helpful in > >> contributing this to us. > >> > >> BR, > >> Jani. > >> > >> > > > > Hi Jani, > > Maarten has acked the patch series to be merged through drm-intel and > > in the meantime I will work with Dmitry to pull the common code to > > avoid duplication > > I wanted to check, are there any updates from your side regarding the series > at [1] ? > Will have a look and float comments if any by Monday > > > > Regards, > > Suraj Kandpal > > > >> [1] https://patchwork.freedesktop.org/series/114473/ > > > > -- > With best wishes > Dmitry Regards, Suraj Kandpal
Hi Suraj, On 07/04/2023 06:11, Kandpal, Suraj wrote: > Hi Dmitry > > >> -----Original Message----- >> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Sent: Friday, April 7, 2023 8:28 AM >> To: Kandpal, Suraj <suraj.kandpal@intel.com>; Jani Nikula >> <jani.nikula@linux.intel.com>; dri-devel@lists.freedesktop.org; intel- >> gfx@lists.freedesktop.org >> Cc: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>; Shankar, Uma >> <uma.shankar@intel.com>; Maarten Lankhorst >> <maarten.lankhorst@linux.intel.com> >> Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC >> >> Hi Suraj >> >> On 28/03/2023 16:20, Kandpal, Suraj wrote: >>> >>> >>>> -----Original Message----- >>>> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf >>>> Of Jani Nikula >>>> Sent: Wednesday, March 8, 2023 5:00 PM >>>> To: Kandpal, Suraj <suraj.kandpal@intel.com>; dri- >>>> devel@lists.freedesktop.org; intel-gfx@lists.freedesktop.org >>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>; Nautiyal, Ankit K >>>> <ankit.k.nautiyal@intel.com>; Shankar, Uma <uma.shankar@intel.com>; >>>> Kandpal, Suraj <suraj.kandpal@intel.com> >>>> Subject: Re: [PATCH 0/7] Enable YCbCr420 format for VDSC >>>> >>>> On Wed, 22 Feb 2023, Suraj Kandpal <suraj.kandpal@intel.com> wrote: >>>>> This patch series aims to enable the YCbCr420 format for DSC. >>>>> Changes are mostly compute params related for hdmi,dp and dsi along >>>>> with the addition of new rc_tables for native_420 and corresponding >>>>> changes to macros used to fetch them. >>>>> There have been discussions prior to this series in which some >>>>> patches have gotten rb and can be found in the below link >>>>> https://patchwork.freedesktop.org/series/113729 >>>> >>>> I think it would be useful to get [1] from Dmitry merged to >>>> drm-misc-next first, have that in drm-next, and again backmerged to >>>> drm-intel-next before this. At least patches 1-5. >>>> >>>> There's not much point in all drivers duplicating the parameters, and >>>> we need to move towards common code. Dmitry has been helpful in >>>> contributing this to us. >>>> >>>> BR, >>>> Jani. >>>> >>>> >>> >>> Hi Jani, >>> Maarten has acked the patch series to be merged through drm-intel and >>> in the meantime I will work with Dmitry to pull the common code to >>> avoid duplication >> >> I wanted to check, are there any updates from your side regarding the series >> at [1] ? >> > > Will have a look and float comments if any by Monday Please excuse me for being slightly stubborn here. We are slowly getting other patches piled up with dependency on this series. It is fine that it doesn't get into 6.4 (which it probably definitely missed by now), but we would like to know if we have to redo/update anything or if it is fine as is and it is going to be merged by i915 in 6.5 cycle. Thank you for the understanding. > >>> >>> Regards, >>> Suraj Kandpal >>> >>>> [1] https://patchwork.freedesktop.org/series/114473/ >> >> >> >> -- >> With best wishes >> Dmitry > > Regards, > Suraj Kandpal