mbox series

[v4,0/4] Do not access i915_gem_object members from frontbuffer tracking

Message ID 20230727064142.751976-1-jouni.hogander@intel.com (mailing list archive)
Headers show
Series Do not access i915_gem_object members from frontbuffer tracking | expand

Message

Jouni Högander July 27, 2023, 6:41 a.m. UTC
We are preparing for Xe driver. Binary objects will have differing
implementation in Xe driver. Due this we want to remove direct
accesses to i915_gem_object members and leave details to binary object
implementation.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>

v4:
  - Fix intel_frontbuffer_get return value
  - s/front_ret/cur/
v3:
  - Move gem object frontbuffer getter/setter into header file
  - operate on and return pointer in defined macros
v2: desribe i915_ggtt_clear_scanout function parameter

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Jouni Högander (4):
  drm/i915: Add macros to get i915 device from i915_gem_object
  drm/i915: Add getter/setter for i915_gem_object->frontbuffer
  drm/i915/display: Remove i915_gem_object_types.h from
    intel_frontbuffer.h
  drm/i915: Add function to clear scanout flag for vmas

 .../gpu/drm/i915/display/intel_frontbuffer.c  | 46 +++++--------
 .../gpu/drm/i915/display/intel_frontbuffer.h  | 28 --------
 drivers/gpu/drm/i915/gem/i915_gem_object.c    |  4 +-
 drivers/gpu/drm/i915/gem/i915_gem_object.h    | 67 +++++++++++++++++++
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |  3 +
 drivers/gpu/drm/i915/i915_vma.c               | 22 +++++-
 drivers/gpu/drm/i915/i915_vma.h               |  2 +
 7 files changed, 112 insertions(+), 60 deletions(-)

Comments

Jouni Högander Aug. 1, 2023, 7:04 a.m. UTC | #1
On Thu, 2023-07-27 at 09:41 +0300, Jouni Högander wrote:
> We are preparing for Xe driver. Binary objects will have differing
> implementation in Xe driver. Due this we want to remove direct
> accesses to i915_gem_object members and leave details to binary
> object
> implementation.

Thank you Nirmoy, Jani and Jeevan for reviews. This is now merged.

BR,

Jouni Högander
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>
> 
> v4:
>   - Fix intel_frontbuffer_get return value
>   - s/front_ret/cur/
> v3:
>   - Move gem object frontbuffer getter/setter into header file
>   - operate on and return pointer in defined macros
> v2: desribe i915_ggtt_clear_scanout function parameter
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> Jouni Högander (4):
>   drm/i915: Add macros to get i915 device from i915_gem_object
>   drm/i915: Add getter/setter for i915_gem_object->frontbuffer
>   drm/i915/display: Remove i915_gem_object_types.h from
>     intel_frontbuffer.h
>   drm/i915: Add function to clear scanout flag for vmas
> 
>  .../gpu/drm/i915/display/intel_frontbuffer.c  | 46 +++++--------
>  .../gpu/drm/i915/display/intel_frontbuffer.h  | 28 --------
>  drivers/gpu/drm/i915/gem/i915_gem_object.c    |  4 +-
>  drivers/gpu/drm/i915/gem/i915_gem_object.h    | 67
> +++++++++++++++++++
>  .../gpu/drm/i915/gem/i915_gem_object_types.h  |  3 +
>  drivers/gpu/drm/i915/i915_vma.c               | 22 +++++-
>  drivers/gpu/drm/i915/i915_vma.h               |  2 +
>  7 files changed, 112 insertions(+), 60 deletions(-)
>