mbox series

[v7,0/3] drm/i915/pxp/mtl: Update gsc-heci cmd submission to align with fw/hw spec

Message ID 20230917211933.1407559-1-alan.previn.teres.alexis@intel.com (mailing list archive)
Headers show
Series drm/i915/pxp/mtl: Update gsc-heci cmd submission to align with fw/hw spec | expand

Message

Teres Alexis, Alan Previn Sept. 17, 2023, 9:19 p.m. UTC
For MTL, update the GSC-HECI packet size and the max firmware
response timeout to match internal fw specs. Enforce setting
run-alone bit in LRC for protected contexts.

Changes from prio revs:
   v6: - fix build error with PXP config (Alan)
   v5: - PAGE_ALIGN typo fix (Alan).
       - Use macro for runalone bit (Vivaik)
       - Spec alignment with system overhead,
         increase fw timeout to 500ms (Alan)
   v4: - PAGE_ALIGN the max heci packet size (Alan).
   v3: - Patch #1. Only start counting the request completion
         timeout from after the request has started (Daniele).
   v2: - Patch #3: fix sparse warning reported by kernel test robot.
   v1: - N/A (Re-test)

Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>

Alan Previn (3):
  drm/i915/pxp/mtl: Update pxp-firmware response timeout
  drm/i915/pxp/mtl: Update pxp-firmware packet size
  drm/i915/lrc: User PXP contexts requires runalone bit in lrc

 drivers/gpu/drm/i915/gt/intel_engine_regs.h   |  1 +
 drivers/gpu/drm/i915/gt/intel_lrc.c           | 23 +++++++++++++++++++
 .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 20 ++++++++++++++--
 .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h |  6 +++++
 .../drm/i915/pxp/intel_pxp_cmd_interface_43.h |  4 ++--
 drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c    |  2 +-
 drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h    | 10 ++++----
 7 files changed, 55 insertions(+), 11 deletions(-)


base-commit: dc4cd6e4e53d46211952fe7c0e408fce3e212993

Comments

Teres Alexis, Alan Previn Sept. 18, 2023, 5:24 p.m. UTC | #1
On Sun, 2023-09-17 at 22:04 +0000, Patchwork wrote:
> Patch Details
> Series: drm/i915/pxp/mtl: Update gsc-heci cmd submission to align with fw/hw spec
> URL:    https://patchwork.freedesktop.org/series/123830/
> 

alan:snip
Below issue it unrelated since this series only changes code paths in MTL-PXP only and in pxp-specific lrc code. (double checked). will retrigger test since it was a BAT failure.

> Possible new issues
> 
> Here are the unknown changes that may have been introduced in Patchwork_123830v1:
> 
> IGT changes
> Possible regressions
> 
>   *   igt@gem_exec_suspend@basic-s3@lmem0:
>      *   bat-dg2-8: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123830v1/bat-dg2-8/igt@gem_exec_suspend@basic-s3@lmem0.html>
>