mbox series

[v2,0/2] drm/i915: fix rb-tree/llist/list confusion

Message ID 20230928182019.10256-1-minipli@grsecurity.net (mailing list archive)
Headers show
Series drm/i915: fix rb-tree/llist/list confusion | expand

Message

Mathias Krause Sept. 28, 2023, 6:20 p.m. UTC 
Commit 1ec23ed7126e ("drm/i915: Use uabi engines for the default engine
map") introduced a bug regarding engine iteration in default_engines()
as the rb tree isn't set up this early during driver initialization.
This triggered a sanity check we have in our grsecurity kernels, fixed
by doing the engine registration earlier (as suggested by Tvrtko) and
giving the type-multiplexed members some more visibility to avoid making
a similar mistake again in the future (patch 2).

Changelog:
v1 -> v2:
- instead of reverting commit 1ec23ed7126e, register engines earlier
  (Tvrtko)

v1: https://lore.kernel.org/intel-gfx/20230905113921.14071-1-minipli@grsecurity.net/

Please apply!

Thanks,
Mathias

Mathias Krause (2):
  drm/i915: Register engines early to avoid type confusion
  drm/i915: Clarify type evolution of uabi_node/uabi_engines

 drivers/gpu/drm/i915/gt/intel_engine_types.h | 10 +++++++++-
 drivers/gpu/drm/i915/gt/intel_engine_user.c  | 17 +++++++----------
 drivers/gpu/drm/i915/i915_drv.h              | 17 ++++++++++++++++-
 drivers/gpu/drm/i915/i915_gem.c              |  9 +++++++--
 4 files changed, 39 insertions(+), 14 deletions(-)