mbox series

[00/12] drm/i915: Display state checker cleanup

Message ID 20231004155607.7719-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Display state checker cleanup | expand

Message

Ville Syrjälä Oct. 4, 2023, 3:55 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

The biggest thing here is changing the state checker to use
a dedicated crtc state (instead of clobbering the old state),
the rest is all polish.

Ville Syrjälä (12):
  drm/i915/psr: Unify PSR pre/post plane update hooks
  drm/i915: Stop clobbering old crtc state during state check
  drm/i915: Constify the crtc states in the DPLL checker
  drm/i915: Simplify DPLL state checker calling convention
  drm/i915: Constify watermark state checker
  drm/i915: Simplify watermark state checker calling convention
  drm/i915: Constify the snps/c10x PLL state checkers
  drm/i915: Simplify snps/c10x DPLL state checker calling convetion
  drm/i915: Constify remainder of the state checker
  drm/i915: Simplify the state checker calling convetions
  drm/i915: s/pipe_config/crtc_state/ in the state checker
  drm/i915: s/dev_priv/i915/ in the state checker

 drivers/gpu/drm/i915/display/intel_cx0_phy.c  |   7 +-
 drivers/gpu/drm/i915/display/intel_cx0_phy.h  |   3 +-
 drivers/gpu/drm/i915/display/intel_display.c  |   7 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  16 ++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.h |   7 +-
 .../drm/i915/display/intel_modeset_verify.c   | 129 +++++++++---------
 .../drm/i915/display/intel_modeset_verify.h   |  11 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |  20 +--
 drivers/gpu/drm/i915/display/intel_psr.h      |   3 +-
 drivers/gpu/drm/i915/display/intel_snps_phy.c |   7 +-
 drivers/gpu/drm/i915/display/intel_snps_phy.h |   3 +-
 drivers/gpu/drm/i915/display/skl_watermark.c  |   4 +-
 drivers/gpu/drm/i915/display/skl_watermark.h  |   3 +-
 13 files changed, 106 insertions(+), 114 deletions(-)

Comments

Jani Nikula Oct. 4, 2023, 4:58 p.m. UTC | #1
On Wed, 04 Oct 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The biggest thing here is changing the state checker to use
> a dedicated crtc state (instead of clobbering the old state),
> the rest is all polish.

A bikeshed on one commit, can be ignored, the series is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>



>
> Ville Syrjälä (12):
>   drm/i915/psr: Unify PSR pre/post plane update hooks
>   drm/i915: Stop clobbering old crtc state during state check
>   drm/i915: Constify the crtc states in the DPLL checker
>   drm/i915: Simplify DPLL state checker calling convention
>   drm/i915: Constify watermark state checker
>   drm/i915: Simplify watermark state checker calling convention
>   drm/i915: Constify the snps/c10x PLL state checkers
>   drm/i915: Simplify snps/c10x DPLL state checker calling convetion
>   drm/i915: Constify remainder of the state checker
>   drm/i915: Simplify the state checker calling convetions
>   drm/i915: s/pipe_config/crtc_state/ in the state checker
>   drm/i915: s/dev_priv/i915/ in the state checker
>
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c  |   7 +-
>  drivers/gpu/drm/i915/display/intel_cx0_phy.h  |   3 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |   7 +-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  16 ++-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.h |   7 +-
>  .../drm/i915/display/intel_modeset_verify.c   | 129 +++++++++---------
>  .../drm/i915/display/intel_modeset_verify.h   |  11 +-
>  drivers/gpu/drm/i915/display/intel_psr.c      |  20 +--
>  drivers/gpu/drm/i915/display/intel_psr.h      |   3 +-
>  drivers/gpu/drm/i915/display/intel_snps_phy.c |   7 +-
>  drivers/gpu/drm/i915/display/intel_snps_phy.h |   3 +-
>  drivers/gpu/drm/i915/display/skl_watermark.c  |   4 +-
>  drivers/gpu/drm/i915/display/skl_watermark.h  |   3 +-
>  13 files changed, 106 insertions(+), 114 deletions(-)