[RESEND,v2,0/2] Add drm_dbg_ratelimited()

Message

Andi Shyti Oct. 10, 2023, 12:15 p.m. UTC

Hi,

I might have picked up the wrong series and missed some reviews
and the extra patch from Nirmoy with a real use of the
drm_dbg_ratelimited() that John was looking for.

Thanks,
Andi

v2:
pick the right patch with the following changes:
 - add more r-b's
 - add a patch 2 where the drm_dbg_ratelimited is actually used.

Nirmoy Das (2):
  drm/print: Add drm_dbg_ratelimited
  drm/i915: Ratelimit debug log in vm_fault_ttm

 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
 include/drm/drm_print.h                 | 3 +++
 2 files changed, 6 insertions(+), 2 deletions(-)

Comments

John Harrison Oct. 10, 2023, 6:25 p.m. UTC | #1

On 10/10/2023 05:15, Andi Shyti wrote:
> Hi,
>
> I might have picked up the wrong series and missed some reviews
> and the extra patch from Nirmoy with a real use of the
> drm_dbg_ratelimited() that John was looking for.
>
> Thanks,
> Andi
I just found the original post of this from back in January 
(https://patchwork.freedesktop.org/series/112925/). Is there a reason 
why it was never merged? As noted, it appears to have a whole bunch of 
r-b's on it.

John.

> v2:
> pick the right patch with the following changes:
>   - add more r-b's
>   - add a patch 2 where the drm_dbg_ratelimited is actually used.
>
> Nirmoy Das (2):
>    drm/print: Add drm_dbg_ratelimited
>    drm/i915: Ratelimit debug log in vm_fault_ttm
>
>   drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
>   include/drm/drm_print.h                 | 3 +++
>   2 files changed, 6 insertions(+), 2 deletions(-)
>

Andi Shyti Oct. 10, 2023, 8:31 p.m. UTC | #2

Hi John,

On Tue, Oct 10, 2023 at 11:25:03AM -0700, John Harrison wrote:
> On 10/10/2023 05:15, Andi Shyti wrote:
> > Hi,
> > 
> > I might have picked up the wrong series and missed some reviews
> > and the extra patch from Nirmoy with a real use of the
> > drm_dbg_ratelimited() that John was looking for.
> > 
> > Thanks,
> > Andi
> I just found the original post of this from back in January
> (https://patchwork.freedesktop.org/series/112925/). Is there a reason why it
> was never merged? As noted, it appears to have a whole bunch of r-b's on it.

yes, the patch was widely appreciated by reviewers... but I think
somehow it was forgotten... that's why I am resending it :-)

Andi

Andi Shyti Oct. 24, 2023, 5:20 p.m. UTC | #3

Hi,

> I might have picked up the wrong series and missed some reviews
> and the extra patch from Nirmoy with a real use of the
> drm_dbg_ratelimited() that John was looking for.

just a kind reminder.

Andi