| Message ID | 20231023-wabb-v3-0-1a4fbc632440@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Apply Wa_16018031267 / Wa_16018063123 | expand |
Hi Andrzej On 10/23/2023 9:41 AM, Andrzej Hajda wrote: > Hi all, > > This the series from Jonathan: > [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 > > taken over by me. > > Changes in this version are described in the patches, in short: > v2: > - use real memory as WABB destination, Do we still need the NULL PTE patch now ? Regards, Nirmoy > - address CI compains - do not decrease vm.total, > - minor reordering. > v3: > - fixed typos, > - removed spare defs, > - added tags > > Regards > Andrzej > > Andrzej Hajda (1): > drm/i915: Reserve some kernel space per vm > > Jonathan Cavitt (3): > drm/i915: Enable NULL PTE support for vm scratch > drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 > drm/i915: Set copy engine arbitration for Wa_16018031267 / > Wa_16018063123 > > .../drm/i915/gem/selftests/i915_gem_context.c | 6 ++ > drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++ > drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ > drivers/gpu/drm/i915/gt/intel_gt.h | 4 + > drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 + > drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + > drivers/gpu/drm/i915/gt/intel_lrc.c | 100 +++++++++++++++++- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + > drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++---- > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/i915/i915_pci.c | 2 + > drivers/gpu/drm/i915/intel_device_info.h | 1 + > 12 files changed, 215 insertions(+), 21 deletions(-) > > --- > Andrzej Hajda (1): > drm/i915: Reserve some kernel space per vm > > Jonathan Cavitt (3): > drm/i915: Enable NULL PTE support for vm scratch > drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 > drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 > > .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 ++ > drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++++ > drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ > drivers/gpu/drm/i915/gt/intel_gt.h | 4 + > drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + > drivers/gpu/drm/i915/gt/intel_lrc.c | 100 ++++++++++++++++++++- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++ > drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++++---- > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/i915/i915_pci.c | 2 + > drivers/gpu/drm/i915/intel_device_info.h | 1 + > 11 files changed, 213 insertions(+), 21 deletions(-) > --- > base-commit: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe > change-id: 20231020-wabb-bbe9324a69a8 > > Best regards,
On 23.10.2023 10:38, Nirmoy Das wrote: > Hi Andrzej > > On 10/23/2023 9:41 AM, Andrzej Hajda wrote: >> Hi all, >> >> This the series from Jonathan: >> [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 >> >> taken over by me. >> >> Changes in this version are described in the patches, in short: >> v2: >> - use real memory as WABB destination, > > Do we still need the NULL PTE patch now ? In fact no, since we are using real address. On the other side it is still valuable, IMO, but probably better is to drop it from this patchset. Regards Andrzej > > > Regards, > > Nirmoy > >> - address CI compains - do not decrease vm.total, >> - minor reordering. >> v3: >> - fixed typos, >> - removed spare defs, >> - added tags >> >> Regards >> Andrzej >> >> Andrzej Hajda (1): >> drm/i915: Reserve some kernel space per vm >> >> Jonathan Cavitt (3): >> drm/i915: Enable NULL PTE support for vm scratch >> drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 >> drm/i915: Set copy engine arbitration for Wa_16018031267 / >> Wa_16018063123 >> >> .../drm/i915/gem/selftests/i915_gem_context.c | 6 ++ >> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++ >> drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ >> drivers/gpu/drm/i915/gt/intel_gt.h | 4 + >> drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 + >> drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + >> drivers/gpu/drm/i915/gt/intel_lrc.c | 100 +++++++++++++++++- >> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + >> drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++---- >> drivers/gpu/drm/i915/i915_drv.h | 2 + >> drivers/gpu/drm/i915/i915_pci.c | 2 + >> drivers/gpu/drm/i915/intel_device_info.h | 1 + >> 12 files changed, 215 insertions(+), 21 deletions(-) >> >> --- >> Andrzej Hajda (1): >> drm/i915: Reserve some kernel space per vm >> >> Jonathan Cavitt (3): >> drm/i915: Enable NULL PTE support for vm scratch >> drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 >> drm/i915: Set copy engine arbitration for Wa_16018031267 / >> Wa_16018063123 >> >> .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 ++ >> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++++ >> drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ >> drivers/gpu/drm/i915/gt/intel_gt.h | 4 + >> drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + >> drivers/gpu/drm/i915/gt/intel_lrc.c | 100 >> ++++++++++++++++++++- >> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++ >> drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 >> ++++++++++---- >> drivers/gpu/drm/i915/i915_drv.h | 2 + >> drivers/gpu/drm/i915/i915_pci.c | 2 + >> drivers/gpu/drm/i915/intel_device_info.h | 1 + >> 11 files changed, 213 insertions(+), 21 deletions(-) >> --- >> base-commit: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe >> change-id: 20231020-wabb-bbe9324a69a8 >> >> Best regards,
On 10/23/2023 1:35 PM, Andrzej Hajda wrote: > > > On 23.10.2023 10:38, Nirmoy Das wrote: >> Hi Andrzej >> >> On 10/23/2023 9:41 AM, Andrzej Hajda wrote: >>> Hi all, >>> >>> This the series from Jonathan: >>> [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 >>> >>> taken over by me. >>> >>> Changes in this version are described in the patches, in short: >>> v2: >>> - use real memory as WABB destination, >> >> Do we still need the NULL PTE patch now ? > > In fact no, since we are using real address. > On the other side it is still valuable, IMO, but probably better is to > drop it from this patchset. Yes, sounds good. Thanks, Nirmoy > > > Regards > Andrzej > >> >> >> Regards, >> >> Nirmoy >> >>> - address CI compains - do not decrease vm.total, >>> - minor reordering. >>> v3: >>> - fixed typos, >>> - removed spare defs, >>> - added tags >>> >>> Regards >>> Andrzej >>> >>> Andrzej Hajda (1): >>> drm/i915: Reserve some kernel space per vm >>> >>> Jonathan Cavitt (3): >>> drm/i915: Enable NULL PTE support for vm scratch >>> drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 >>> drm/i915: Set copy engine arbitration for Wa_16018031267 / >>> Wa_16018063123 >>> >>> .../drm/i915/gem/selftests/i915_gem_context.c | 6 ++ >>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++ >>> drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ >>> drivers/gpu/drm/i915/gt/intel_gt.h | 4 + >>> drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 + >>> drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + >>> drivers/gpu/drm/i915/gt/intel_lrc.c | 100 >>> +++++++++++++++++- >>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + >>> drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++---- >>> drivers/gpu/drm/i915/i915_drv.h | 2 + >>> drivers/gpu/drm/i915/i915_pci.c | 2 + >>> drivers/gpu/drm/i915/intel_device_info.h | 1 + >>> 12 files changed, 215 insertions(+), 21 deletions(-) >>> >>> --- >>> Andrzej Hajda (1): >>> drm/i915: Reserve some kernel space per vm >>> >>> Jonathan Cavitt (3): >>> drm/i915: Enable NULL PTE support for vm scratch >>> drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 >>> drm/i915: Set copy engine arbitration for Wa_16018031267 / >>> Wa_16018063123 >>> >>> .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 ++ >>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++++ >>> drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ >>> drivers/gpu/drm/i915/gt/intel_gt.h | 4 + >>> drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + >>> drivers/gpu/drm/i915/gt/intel_lrc.c | 100 >>> ++++++++++++++++++++- >>> drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++ >>> drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 >>> ++++++++++---- >>> drivers/gpu/drm/i915/i915_drv.h | 2 + >>> drivers/gpu/drm/i915/i915_pci.c | 2 + >>> drivers/gpu/drm/i915/intel_device_info.h | 1 + >>> 11 files changed, 213 insertions(+), 21 deletions(-) >>> --- >>> base-commit: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe >>> change-id: 20231020-wabb-bbe9324a69a8 >>> >>> Best regards, >
Hi all, This the series from Jonathan: [PATCH v12 0/4] Apply Wa_16018031267 / Wa_16018063123 taken over by me. Changes in this version are described in the patches, in short: v2: - use real memory as WABB destination, - address CI compains - do not decrease vm.total, - minor reordering. v3: - fixed typos, - removed spare defs, - added tags Regards Andrzej Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable NULL PTE support for vm scratch drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 .../drm/i915/gem/selftests/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++ drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ drivers/gpu/drm/i915/gt/intel_gt.h | 4 + drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 + drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + drivers/gpu/drm/i915/gt/intel_lrc.c | 100 +++++++++++++++++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++---- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/intel_device_info.h | 1 + 12 files changed, 215 insertions(+), 21 deletions(-) --- Andrzej Hajda (1): drm/i915: Reserve some kernel space per vm Jonathan Cavitt (3): drm/i915: Enable NULL PTE support for vm scratch drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 .../gpu/drm/i915/gem/selftests/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 41 +++++++++ drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ drivers/gpu/drm/i915/gt/intel_gt.h | 4 + drivers/gpu/drm/i915/gt/intel_gtt.h | 2 + drivers/gpu/drm/i915/gt/intel_lrc.c | 100 ++++++++++++++++++++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 ++++++++++---- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/intel_device_info.h | 1 + 11 files changed, 213 insertions(+), 21 deletions(-) --- base-commit: 201c8a7bd1f3f415920a2df4b8a8817e973f42fe change-id: 20231020-wabb-bbe9324a69a8 Best regards,