mbox series

[v8,0/4] Prepare intel_fb for Xe

Message ID 20231130144338.3083821-1-jouni.hogander@intel.com (mailing list archive)
Headers show
Series Prepare intel_fb for Xe | expand

Message

Hogander, Jouni Nov. 30, 2023, 2:43 p.m. UTC 
Intel fb creation is differing between Xe and i915 due to different
implementations of backing object. This patch set is splitting i915
specific code into it's own source file. Similar source files will be
introduced for Xe as well.

Also use intel_bo_to_drm_bo instead of directly referring
i915_gem_object->base. One i915_gem_object_put is changed to
drm_gem_object_put.

v8:
  - return original error code from intel_fb_bo_lookup_valid_bo on failure
v7:
  - drop #include <drm/drm_plane.h>
  - s/user_mode_cmd/mode_cmd/
  - Use passed i915 pointer instead of to_i915(obj->base.dev)
v6: Add missing intel_fb_bo.[ch]
v5:
  - Keep drm_any_plane_has_format check in intel_fb.c
  - Use mode_cmd instead of user_mode_cmd for intel_fb_bo_lookup_valid_bo
  - Use lookup_modifier_or_null in intel_fb_modifier_to_tiling and
    handle null value
v4: Move drm_any_plane_has_format check into intel_fb_bo.c
v3: Fix failure handling in intel_framebuffer_init
v2: Couple of fixes to error value handling

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>

Jouni Högander (4):
  drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c
  drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static
  drm/i915/display: Handle invalid fb_modifier in
    intel_fb_modifier_to_tiling
  drm/i915/display: Split i915 specific code away from intel_fb.c

 drivers/gpu/drm/i915/Makefile              |   1 +
 drivers/gpu/drm/i915/display/intel_fb.c    | 133 +++++++--------------
 drivers/gpu/drm/i915/display/intel_fb.h    |   2 +
 drivers/gpu/drm/i915/display/intel_fb_bo.c |  92 ++++++++++++++
 drivers/gpu/drm/i915/display/intel_fb_bo.h |  24 ++++
 5 files changed, 164 insertions(+), 88 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.h

Comments

Hogander, Jouni Dec. 1, 2023, 11 a.m. UTC | #1 
Hello,

Regression suspected here have nothing to do with my patch. Same failure is already hit earlier:

http://gfx-ci.igk.intel.com/cibuglog-ng/results/all?query_key=fa6201fe80daa725cd0a1c7f21dfb248db8b5a96

Please re-report so  we will get results from shards as well.

Thank you in advance,

Jouni Högander


On Thu, 2023-11-30 at 21:47 +0000, Patchwork wrote:
Patch Details
Series: Prepare intel_fb for Xe (rev9)
URL:    https://patchwork.freedesktop.org/series/126507/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/index.html
CI Bug Log - changes from CI_DRM_13955 -> Patchwork_126507v9
Summary

FAILURE

Serious unknown changes coming with Patchwork_126507v9 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_126507v9, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/index.html

Participating hosts (36 -> 38)

Additional (3): bat-rpls-1 bat-mtlp-8 fi-pnv-d510
Missing (1): fi-snb-2520m

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_126507v9:

IGT changes
Possible regressions

  *   igt@kms_force_connector_basic@force-connector-state:
     *   bat-dg1-7: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13955/bat-dg1-7/igt@kms_force_connector_basic@force-connector-state.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-dg1-7/igt@kms_force_connector_basic@force-connector-state.html>

Known issues

Here are the changes found in Patchwork_126507v9 that come from known issues:

CI changes
Issues hit

  *   boot:
     *   fi-bsw-n3050: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13955/fi-bsw-n3050/boot.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/fi-bsw-n3050/boot.html> (i915#8293<https://gitlab.freedesktop.org/drm/intel/issues/8293>)

IGT changes
Issues hit

  *   igt@debugfs_test@basic-hwmon:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html> (i915#9318<https://gitlab.freedesktop.org/drm/intel/issues/9318>)

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@debugfs_test@basic-hwmon.html> (i915#9318<https://gitlab.freedesktop.org/drm/intel/issues/9318>)

  *   igt@fbdev@info:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@fbdev@info.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>)
  *   igt@fbdev@write:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@fbdev@write.html> (i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>) +3 other tests skip
  *   igt@gem_lmem_swapping@basic:

     *   fi-pnv-d510: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/fi-pnv-d510/igt@gem_lmem_swapping@basic.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +25 other tests skip
  *   igt@gem_lmem_swapping@random-engines:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@gem_lmem_swapping@random-engines.html> (i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 other tests skip
  *   igt@gem_lmem_swapping@verify-random:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@gem_lmem_swapping@verify-random.html> (i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 other tests skip
  *   igt@gem_mmap@basic:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@gem_mmap@basic.html> (i915#4083<https://gitlab.freedesktop.org/drm/intel/issues/4083>)
  *   igt@gem_mmap_gtt@basic:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@gem_mmap_gtt@basic.html> (i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +2 other tests skip
  *   igt@gem_render_tiled_blits@basic:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html> (i915#4079<https://gitlab.freedesktop.org/drm/intel/issues/4079>) +1 other test skip
  *   igt@gem_tiled_pread_basic:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@gem_tiled_pread_basic.html> (i915#3282<https://gitlab.freedesktop.org/drm/intel/issues/3282>)
  *   igt@i915_pm_rps@basic-api:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@i915_pm_rps@basic-api.html> (i915#6621<https://gitlab.freedesktop.org/drm/intel/issues/6621>)

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@i915_pm_rps@basic-api.html> (i915#6621<https://gitlab.freedesktop.org/drm/intel/issues/6621>)

  *   igt@i915_suspend@basic-s3-without-i915:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html> (i915#6645<https://gitlab.freedesktop.org/drm/intel/issues/6645>)
  *   igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html> (i915#5190<https://gitlab.freedesktop.org/drm/intel/issues/5190>)
  *   igt@kms_addfb_basic@basic-y-tiled-legacy:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html> (i915#4212<https://gitlab.freedesktop.org/drm/intel/issues/4212>) +8 other tests skip
  *   igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> (i915#4213<https://gitlab.freedesktop.org/drm/intel/issues/4213>) +1 other test skip
  *   igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845>) +17 other tests skip
  *   igt@kms_dsc@dsc-basic:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_dsc@dsc-basic.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#3840<https://gitlab.freedesktop.org/drm/intel/issues/3840> / i915#4098<https://gitlab.freedesktop.org/drm/intel/issues/4098> / i915#9159<https://gitlab.freedesktop.org/drm/intel/issues/9159>)
  *   igt@kms_flip@basic-flip-vs-modeset:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@kms_flip@basic-flip-vs-modeset.html> (i915#3637<https://gitlab.freedesktop.org/drm/intel/issues/3637>) +3 other tests skip
  *   igt@kms_force_connector_basic@force-load-detect:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>)

  *   igt@kms_force_connector_basic@prune-stale-modes:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html> (i915#5274<https://gitlab.freedesktop.org/drm/intel/issues/5274>)
  *   igt@kms_frontbuffer_tracking@basic:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@kms_frontbuffer_tracking@basic.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>)
  *   igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:

     *   bat-adlp-9: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-adlp-9/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html> (i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845> / i915#3546<https://gitlab.freedesktop.org/drm/intel/issues/3546>) +3 other tests skip
  *   igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:

     *   bat-rplp-1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13955/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html> (i915#8668<https://gitlab.freedesktop.org/drm/intel/issues/8668>)
  *   igt@kms_setmode@basic-clone-single-crtc:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#8809<https://gitlab.freedesktop.org/drm/intel/issues/8809>)

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555>)

  *   igt@prime_vgem@basic-fence-flip:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@prime_vgem@basic-fence-flip.html> (fdo#109295<https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#1845<https://gitlab.freedesktop.org/drm/intel/issues/1845> / i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>)
  *   igt@prime_vgem@basic-fence-mmap:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@prime_vgem@basic-fence-mmap.html> (i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708> / i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1 other test skip
  *   igt@prime_vgem@basic-fence-read:

     *   bat-mtlp-8: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html> (i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>) +2 other tests skip
  *   igt@prime_vgem@basic-write:

     *   bat-rpls-1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-rpls-1/igt@prime_vgem@basic-write.html> (fdo#109295<https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>) +2 other tests skip

Possible fixes

  *   igt@kms_flip@basic-flip-vs-modeset@b-dp6:

     *   bat-adlp-11: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13955/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@b-dp6.html> (i915#6121<https://gitlab.freedesktop.org/drm/intel/issues/6121>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@b-dp6.html> +3 other tests pass
  *   igt@kms_hdmi_inject@inject-audio:

     *   fi-kbl-guc: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13955/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html> (IGT#3<https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126507v9/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html>

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

  *   Linux: CI_DRM_13955 -> Patchwork_126507v9

CI-20190529: 20190529
CI_DRM_13955: d835c627d25ba8775624ff3e854d034708044ac3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7612: b5c47966901ee1060bcb9d4bccdd3ccec9651ef4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_126507v9: d835c627d25ba8775624ff3e854d034708044ac3 @ git://anongit.freedesktop.org/gfx-ci/linux

Linux commits

1acab8260ffb drm/i915/display: Split i915 specific code away from intel_fb.c
393c1524b8ef drm/i915/display: Handle invalid fb_modifier in intel_fb_modifier_to_tiling
bc5c1304a0dd drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static
f4cfb3d02d53 drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c