mbox series

[0/8] drm/i915: Drop pointless null checks and fix a scaler bug

Message ID 20231207193441.20206-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Drop pointless null checks and fix a scaler bug | expand

Message

Ville Syrjala Dec. 7, 2023, 7:34 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Mostly just dropping a bunch of redundant null checks that I ran
into while playing around with __attribute__((nonnull)).

And I also ended up discovering an actual bug in the scaler code.

Ville Syrjälä (8):
  drm/i915: Fix intel_atomic_setup_scalers() plane_state handling
  drm/i915: Streamline intel_dsc_pps_read()
  drm/i915: Drop redundant NULL check
  drm/i915: Drop crtc NULL check from intel_crtc_active()
  drm/i915: Drop NULL fb check from intel_fb_uses_dpt()
  drm/i915: Clean up intel_get_frame_time_us()
  drm/i915: s/cstate/crtc_state/ in intel_get_frame_time_us()
  drm/i915/tv: Drop redundant null checks

 drivers/gpu/drm/i915/display/i9xx_wm.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_bios.c |  3 +--
 drivers/gpu/drm/i915/display/intel_fb.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_psr.c  |  6 +++---
 drivers/gpu/drm/i915/display/intel_tv.c   |  6 ------
 drivers/gpu/drm/i915/display/intel_vdsc.c | 21 +++++++--------------
 drivers/gpu/drm/i915/display/skl_scaler.c |  2 +-
 7 files changed, 14 insertions(+), 28 deletions(-)

Comments

Jani Nikula Dec. 8, 2023, 9:55 a.m. UTC | #1
On Thu, 07 Dec 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Mostly just dropping a bunch of redundant null checks that I ran
> into while playing around with __attribute__((nonnull)).
>
> And I also ended up discovering an actual bug in the scaler code.

Series is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Ville Syrjälä (8):
>   drm/i915: Fix intel_atomic_setup_scalers() plane_state handling
>   drm/i915: Streamline intel_dsc_pps_read()
>   drm/i915: Drop redundant NULL check
>   drm/i915: Drop crtc NULL check from intel_crtc_active()
>   drm/i915: Drop NULL fb check from intel_fb_uses_dpt()
>   drm/i915: Clean up intel_get_frame_time_us()
>   drm/i915: s/cstate/crtc_state/ in intel_get_frame_time_us()
>   drm/i915/tv: Drop redundant null checks
>
>  drivers/gpu/drm/i915/display/i9xx_wm.c    |  2 +-
>  drivers/gpu/drm/i915/display/intel_bios.c |  3 +--
>  drivers/gpu/drm/i915/display/intel_fb.c   |  2 +-
>  drivers/gpu/drm/i915/display/intel_psr.c  |  6 +++---
>  drivers/gpu/drm/i915/display/intel_tv.c   |  6 ------
>  drivers/gpu/drm/i915/display/intel_vdsc.c | 21 +++++++--------------
>  drivers/gpu/drm/i915/display/skl_scaler.c |  2 +-
>  7 files changed, 14 insertions(+), 28 deletions(-)