mbox series

[v2,0/7] VSC SDP rework

Message ID 20231220103609.1384523-1-jouni.hogander@intel.com (mailing list archive)
Headers show
Series VSC SDP rework | expand

Message

Jouni Högander Dec. 20, 2023, 10:36 a.m. UTC
Current VSC SDP configuration code is broken:

1. Driver configured header and data is not used at all
2. Colorimetry data is not added into VSC SDP if PSR1 is used

This patch set fixes these problems and makes VSC SDP configuration a
bit more simpler by unifying PSR and non-PSR cases.

v2: s/-colorimetry/without colorimetry/

Jouni Högander (7):
  drm/i915/display: Remove intel_crtc_state->psr_vsc
  drm/i915/display: Move colorimetry_support from intel_psr to intel_dp
  drm/i915/display: Unify VSC SPD preparation
  drm/i915/display: Fix vsc_sdp computation
  drm/i915/display: Ignore only psr specific part of vsc sdp
  drm/i915/display: Read PSR configuration before VSC SDP
  drm/i915/display: Take care of VSC select field in video dip ctl
    register

 drivers/gpu/drm/i915/display/intel_ddi.c      |  4 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  9 +-
 .../drm/i915/display/intel_display_types.h    |  4 +-
 drivers/gpu/drm/i915/display/intel_dp.c       | 97 ++++++-------------
 drivers/gpu/drm/i915/display/intel_dp.h       |  7 --
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  8 +-
 drivers/gpu/drm/i915/display/intel_psr.c      | 11 +--
 7 files changed, 44 insertions(+), 96 deletions(-)

Comments

Jouni Högander Dec. 22, 2023, 6:34 a.m. UTC | #1
Hello,

These are now pushed to drm-intel-next. There are BAT and IGT results
available in patchwork:

https://patchwork.freedesktop.org/series/127803/

Due to problems with our CI result mails were not sent and not all
checks were run on version 2. I checked IGT failures and they are not
related to my patches. Also IGT was passing on version 1. Rest of the
checks were run on version 2. Changes I made in version 2. were minor
so I decided trust on results over version 1. and merge this set.

Thank you Rodrigo, Mika and Shawn for your help with reviewing and
testing my patches.

BR,

Jouni Högander

On Wed, 2023-12-20 at 12:36 +0200, Jouni Högander wrote:
> Current VSC SDP configuration code is broken:
> 
> 1. Driver configured header and data is not used at all
> 2. Colorimetry data is not added into VSC SDP if PSR1 is used
> 
> This patch set fixes these problems and makes VSC SDP configuration a
> bit more simpler by unifying PSR and non-PSR cases.
> 
> v2: s/-colorimetry/without colorimetry/
> 
> Jouni Högander (7):
>   drm/i915/display: Remove intel_crtc_state->psr_vsc
>   drm/i915/display: Move colorimetry_support from intel_psr to
> intel_dp
>   drm/i915/display: Unify VSC SPD preparation
>   drm/i915/display: Fix vsc_sdp computation
>   drm/i915/display: Ignore only psr specific part of vsc sdp
>   drm/i915/display: Read PSR configuration before VSC SDP
>   drm/i915/display: Take care of VSC select field in video dip ctl
>     register
> 
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  4 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |  9 +-
>  .../drm/i915/display/intel_display_types.h    |  4 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       | 97 ++++++-----------
> --
>  drivers/gpu/drm/i915/display/intel_dp.h       |  7 --
>  drivers/gpu/drm/i915/display/intel_hdmi.c     |  8 +-
>  drivers/gpu/drm/i915/display/intel_psr.c      | 11 +--
>  7 files changed, 44 insertions(+), 96 deletions(-)
>