mbox series

[v7,0/6] drm/i915: Convert fbdev to DRM client

Message ID 20240301134448.31289-1-tzimmermann@suse.de (mailing list archive)
Headers show
Series drm/i915: Convert fbdev to DRM client | expand

Message

Thomas Zimmermann March 1, 2024, 1:42 p.m. UTC 
Convert i915's fbdev code to struct drm_client. Replaces the current
ad-hoc integration. The conversion includes a number of cleanups. The
patchset also enables unloading of driver modules with in-kernel DRM
clients; a feature required by i915. Also update the xe driver where
necessary.

As with the other drivers' fbdev emulation, fbdev in i915 is now
an in-kernel DRM client that runs after the DRM device has been
registered. This allows to remove the asynchronous initialization.

i915 is the last driver with an fbdev emulation that is not build
upon struct drm_client. Once reviewed, the patches would ideally go
into drm-misc-next, so that the old fbdev helper code can be removed.
We can also attempt to add additional in-kernel clients. A DRM-based
dmesg log or a bootsplash are commonly mentioned. DRM can then switch
easily among the existing clients if/when required.

v7:
	* update xe driver
v6:
	* reorder patches to fix build (Jouni)
	* remove unnecessary handling of non-atomic commits (Jouni, Ville)
	* return errors from callbacks (Jouni)
	* various minor fixes
v5:
	* style fixes (checkpatch)
v4:
	<no changes>
v3:
	* support module unloading (Jani, CI bot)
	* as before, silently ignore devices without displays (CI  bot)
v2:
	* fix error handling (Jani)
	* fix non-fbdev builds
	* various minor fixes and cleanups

Thomas Zimmermann (6):
  drm/client: Export drm_client_dev_unregister()
  drm/i915: Unregister in-kernel clients
  drm/i915: Move fbdev functions
  drm/i915: Initialize fbdev DRM client with callback functions
  drm/i915: Implement fbdev client callbacks
  drm/i915: Implement fbdev emulation as in-kernel client

 drivers/gpu/drm/drm_client.c                  |  13 +
 drivers/gpu/drm/i915/display/intel_display.c  |   1 -
 .../drm/i915/display/intel_display_driver.c   |  19 --
 drivers/gpu/drm/i915/display/intel_fbdev.c    | 265 ++++++++++--------
 drivers/gpu/drm/i915/display/intel_fbdev.h    |  29 +-
 drivers/gpu/drm/i915/i915_driver.c            |  27 +-
 drivers/gpu/drm/xe/display/xe_display.c       |  11 -
 drivers/gpu/drm/xe/xe_device.c                |   3 +
 8 files changed, 169 insertions(+), 199 deletions(-)

Comments

Thomas Zimmermann March 6, 2024, 4:42 p.m. UTC | #1 
FYI, there's a possible regression reported here. I was not able to 
reproduce this bug locally with neither i915 nor xe.

Am 01.03.24 um 18:42 schrieb Patchwork:
> Project List - Patchwork *Patch Details*
> *Series:* 	drm/i915: Convert fbdev to DRM client (rev7)
> *URL:* 	https://patchwork.freedesktop.org/series/115714/
> *State:* 	failure
> *Details:* 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/index.html
>
>
>   CI Bug Log - changes from CI_DRM_14378 -> Patchwork_115714v7
>
>
>     Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_115714v7 absolutely need 
> to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_115714v7, please notify your bug team 
> (I915-ci-infra@lists.freedesktop.org) to allow them
> to document this new failure mode, which will reduce false positives 
> in CI.
>
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/index.html
>
>
>     Participating hosts (41 -> 40)
>
> Missing (1): fi-snb-2520m
>
>
>     Possible new issues
>
> Here are the unknown changes that may have been introduced in 
> Patchwork_115714v7:
>
>
>       IGT changes
>
>
>         Possible regressions
>
>   * igt@i915_selftest@live@gt_timelines:
>       o bat-arls-2: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14378/bat-arls-2/igt@i915_selftest@live@gt_timelines.html>
>         -> ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-arls-2/igt@i915_selftest@live@gt_timelines.html>
>
>
>     Known issues
>
> Here are the changes found in Patchwork_115714v7 that come from known 
> issues:
>
>
>       CI changes
>
>
>         Issues hit
>
>   * boot:
>       o fi-cfl-8109u: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14378/fi-cfl-8109u/boot.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/fi-cfl-8109u/boot.html>
>         (i915#8293 <https://gitlab.freedesktop.org/drm/intel/issues/8293>)
>
>
>       IGT changes
>
>
>         Issues hit
>
>  *
>
>     igt@i915_pm_rps@basic-api:
>
>       o bat-dg2-9: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@i915_pm_rps@basic-api.html>
>         (i915#6621 <https://gitlab.freedesktop.org/drm/intel/issues/6621>)
>  *
>
>     igt@kms_psr@psr-sprite-plane-onoff:
>
>       o bat-dg2-9: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@kms_psr@psr-sprite-plane-onoff.html>
>         (i915#9673
>         <https://gitlab.freedesktop.org/drm/intel/issues/9673> /
>         i915#9732
>         <https://gitlab.freedesktop.org/drm/intel/issues/9732>) +3
>         other tests skip
>  *
>
>     igt@kms_setmode@basic-clone-single-crtc:
>
>       o bat-dg2-9: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html>
>         (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>)
>  *
>
>     igt@prime_vgem@basic-fence-flip:
>
>       o bat-dg2-9: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html>
>         (i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708>)
>  *
>
>     igt@prime_vgem@basic-fence-mmap:
>
>       o bat-dg2-9: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html>
>         (i915#3708
>         <https://gitlab.freedesktop.org/drm/intel/issues/3708> /
>         i915#4077
>         <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1
>         other test skip
>  *
>
>     igt@prime_vgem@basic-write:
>
>       o bat-dg2-9: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@prime_vgem@basic-write.html>
>         (i915#3291
>         <https://gitlab.freedesktop.org/drm/intel/issues/3291> /
>         i915#3708
>         <https://gitlab.freedesktop.org/drm/intel/issues/3708>) +2
>         other tests skip
>
>
>         Possible fixes
>
>  *
>
>     igt@i915_selftest@live@gt_lrc:
>
>       o bat-adln-1: INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14378/bat-adln-1/igt@i915_selftest@live@gt_lrc.html>
>         (i915#10241
>         <https://gitlab.freedesktop.org/drm/intel/issues/10241> /
>         i915#9413
>         <https://gitlab.freedesktop.org/drm/intel/issues/9413>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-adln-1/igt@i915_selftest@live@gt_lrc.html>
>  *
>
>     igt@i915_selftest@live@hangcheck:
>
>       o {bat-adls-6}: DMESG-WARN
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14378/bat-adls-6/igt@i915_selftest@live@hangcheck.html>
>         (i915#5591
>         <https://gitlab.freedesktop.org/drm/intel/issues/5591>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-adls-6/igt@i915_selftest@live@hangcheck.html>
>  *
>
>     igt@i915_selftest@live@perf:
>
>       o bat-dg2-14: ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14378/bat-dg2-14/igt@i915_selftest@live@perf.html>
>         -> PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-14/igt@i915_selftest@live@perf.html>
>  *
>
>     igt@kms_pm_rpm@basic-pci-d3-state:
>
>       o bat-dg2-9: ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14378/bat-dg2-9/igt@kms_pm_rpm@basic-pci-d3-state.html>
>         -> PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_115714v7/bat-dg2-9/igt@kms_pm_rpm@basic-pci-d3-state.html>
>
> {name}: This element is suppressed. This means it is ignored when 
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
>     Build changes
>
>   * Linux: CI_DRM_14378 -> Patchwork_115714v7
>
> CI-20190529: 20190529
> CI_DRM_14378: 5f60548dd58e2ad93005c933fd2633d98db60de4 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7742: 7742
> Patchwork_115714v7: 5f60548dd58e2ad93005c933fd2633d98db60de4 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
>       Linux commits
>
> 2a2bc7f22f82 drm/i915: Implement fbdev emulation as in-kernel client
> 3aa489abc35d drm/i915: Implement fbdev client callbacks
> 56032934e1c0 drm/i915: Initialize fbdev DRM client with callback functions
> 325f2c9f3e4b drm/i915: Move fbdev functions
> 9b9c75375fd5 drm/i915: Unregister in-kernel clients
> 8a5735e7de8a drm/client: Export drm_client_dev_unregister()
>