mbox series

[v3,0/8] drm/i915: PREEMPT_RT related fixups.

Message ID 20240628130601.1772849-1-bigeasy@linutronix.de (mailing list archive)
Headers show
Series drm/i915: PREEMPT_RT related fixups. | expand

Message

Sebastian Andrzej Siewior June 28, 2024, 12:57 p.m. UTC
Hi,

The following patches are from the PREEMPT_RT queue.  It is mostly about
disabling interrupts/preemption which leads to problems. Unfortunately
DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks
from within trace points. Making the lock a raw_spinlock_t led to higher
latencies during video playback
  https://lore.kernel.org/all/20211006164628.s2mtsdd2jdbfyf7g@linutronix.de/

and I'm not sure if I hit the worse case here.
I tested it on a SandyBridge with built-in i915 by using X, OpenGL and
playing videos without noticing any warnings. However, some code paths
were not entered.
I carry them for some time now and most issues were reported by other
people and they reported that things work for them since.

v2…v3 https://lore.kernel.org/all/20240613102818.4056866-1-bigeasy@linutronix.de/
  - Collected tags.
  - Added comment to 3/8 explaining why RT is excluded from the test.
  
v1…v2:
  - The tracing disable bits (4/8) have been reworked after Steven pointed out
    that something isn't right.
  - The irq_work() bits have been dropped because they are no longer
    needed.


Sebastian

Comments

Saarinen, Jani June 28, 2024, 2:03 p.m. UTC | #1
Hi, 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Patchwork
> Sent: Friday, 28 June 2024 16.43
> To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: ✗ Fi.CI.BAT: failure for drm/i915: PREEMPT_RT related fixups. (rev12)
> 
> Patch Details
> Series:	drm/i915: PREEMPT_RT related fixups. (rev12)
> URL:	https://patchwork.freedesktop.org/series/95463/
> State:	failure
> Details:	https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/index.html
> 
> CI Bug Log - changes from CI_DRM_15013 -> Patchwork_95463v12
> 
> Summary
> 
> 
> FAILURE
> 
> Serious unknown changes coming with Patchwork_95463v12 absolutely need
> to be verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_95463v12, please notify your bug team (I915-ci-
> infra@lists.freedesktop.org) to allow them to document this new failure
> mode, which will reduce false positives in CI.
> 
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/index.html
> 
> 
> Participating hosts (42 -> 33)
> 
> 
> Missing (9): bat-adlp-9 bat-adlp-6 fi-snb-2520m bat-adln-1 fi-elk-e7500 bat-
> dg2-14 bat-dg2-13 bat-dg2-11 bat-arlh-2
^^^this would be good to understand why this many systems down or was this CI system issues? 

> 
> 
> Possible new issues
> 
> 
> Here are the unknown changes that may have been introduced in
> Patchwork_95463v12:
> 
> 
> IGT changes
> 
> 
> Possible regressions
> 
> 
> *	igt@debugfs_test@read_all_entries:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_15013/fi-kbl-7567u/igt@debugfs_test@read_all_entries.html>
> -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/fi-kbl-
> 7567u/igt@debugfs_test@read_all_entries.html>  +5 other tests dmesg-warn
This is known issue https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11328 

> 
> 
> Known issues
> 
> 
> Here are the changes found in Patchwork_95463v12 that come from known
> issues:
> 
> 
> IGT changes
> 
> 
> Issues hit
> 
> 
> *	igt@i915_pm_rpm@module-reload:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_15013/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html>  -
> > DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/fi-kbl-7567u/igt@i915_pm_rpm@module-
> reload.html>  (i915#10062 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/10062>  / i915#180 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/180>  / i915#1982 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/1982>  / i915#9925 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/9925> )
> 
> *	igt@i915_selftest@live@sanitycheck:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_15013/fi-kbl-7567u/igt@i915_selftest@live@sanitycheck.html>
> -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/fi-kbl-
> 7567u/igt@i915_selftest@live@sanitycheck.html>  (i915#11328
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11328> ) +40 other
> tests dmesg-warn
> 
> *	igt@kms_busy@basic@flip:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_busy@basic@flip.html>  ->
> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/fi-kbl-7567u/igt@kms_busy@basic@flip.html>
> (i915#180 <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/180> )
> 
> *	igt@kms_frontbuffer_tracking@basic:
> 
> 	*	bat-arls-2: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_15013/bat-arls-2/igt@kms_frontbuffer_tracking@basic.html>  -
> > DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/bat-arls-
> 2/igt@kms_frontbuffer_tracking@basic.html>  (i915#7507
> <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7507> )
> 
> *	igt@kms_pm_rpm@basic-pci-d3-state:
> 
> 	*	fi-kbl-7567u: PASS <https://intel-gfx-ci.01.org/tree/drm-
> tip/CI_DRM_15013/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-
> state.html>  -> DMESG-WARN <https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_95463v12/fi-kbl-7567u/igt@kms_pm_rpm@basic-pci-d3-
> state.html>  (i915#10062 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/10062>  / i915#180 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/180>  / i915#9925 <https://gitlab.freedesktop.org/drm/i915/kernel/-
> /issues/9925> ) +39 other tests dmesg-warn
> 
> 
> Build changes
> 
> 
> *	Linux: CI_DRM_15013 -> Patchwork_95463v12
> 
> CI-20190529: 20190529
> CI_DRM_15013: 0318a12ff6fb8c321458aa2b373e9322896ee951 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7906: ae91ba26f657bf11264f64bd2dc21f471a5d18f5 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_95463v12: 0318a12ff6fb8c321458aa2b373e9322896ee951 @
> git://anongit.freedesktop.org/gfx-ci/linux