From patchwork Mon Jul 15 18:27:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 13733806 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20F89C3DA5E for ; Mon, 15 Jul 2024 18:30:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7CA8310E4B8; Mon, 15 Jul 2024 18:30:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gqOYFHQ2"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50FC910E4B4; Mon, 15 Jul 2024 18:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721068216; x=1752604216; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=SHqV0cXpGkV90efBGER3GY+L/xFkcfbqdlj5CzoyKIo=; b=gqOYFHQ2WBqVSArDW3IJA+KdZw9hOsz8HegcJHt4w9xWDkUsjI6TSkSS qi5ANiJJHwHGy8pPUiOK0WdMy1c2iAM0AMTsoAGP6RL+ORsmBXOo1WmEf d2TIv03+6+B/Zm5UY7ln9rz5DvLg96FeVi0G7K3RjIdq4s6CvcNgLDe52 aJHVsko+ulstXSZj4uPqFpLW+yUh4GVqsbbCFVhAsl+ofs8qatTlUh3jD sIBrJgUwx5VgJhrlTjqTEuCVxN3g7mY2snNT4M71bXm+Fs/Fi/g9yF8Fr M2BPhDNCrXZ5LBdNztbcgwoD0LVzBvFz1+xgx+Ek30RsJsX5JbfjPAXdi Q==; X-CSE-ConnectionGUID: Eti54qGYQIG8/V8eqktnBQ== X-CSE-MsgGUID: TLO8znpFQFO5+xOq+jhpqw== X-IronPort-AV: E=McAfee;i="6700,10204,11134"; a="18618846" X-IronPort-AV: E=Sophos;i="6.09,210,1716274800"; d="scan'208";a="18618846" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2024 11:30:16 -0700 X-CSE-ConnectionGUID: mhofzC1xRuWc3nFeQaIg4w== X-CSE-MsgGUID: oJuh1rh0SNychHTEdLzUbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,210,1716274800"; d="scan'208";a="54886878" Received: from jkrzyszt-mobl2.ger.corp.intel.com (HELO jkrzyszt-mobl2.intranet) ([10.213.26.74]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2024 11:30:14 -0700 From: Janusz Krzysztofik To: igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Kamil Konieczny , Chris Wilson , Janusz Krzysztofik Subject: [PATCH i-g-t v2 0/5] tests/gem_ctx_exec: Fix failing preempt timeout updates Date: Mon, 15 Jul 2024 20:27:28 +0200 Message-ID: <20240715183000.2828719-7-janusz.krzysztofik@linux.intel.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" CI reports the following failures from basic-nohangcheck subtest: (gem_ctx_exec:1115) CRITICAL: Test assertion failure function nohangcheck_hostile, file ../../../usr/src/igt-gpu-tools/tests/intel/gem_ctx_exec.c:374: (gem_ctx_exec:1115) CRITICAL: Failed assertion: err == 0 (gem_ctx_exec:1115) CRITICAL: Last errno: 2, No such file or directory (gem_ctx_exec:1115) CRITICAL: Hostile unpreemptable context was not cancelled immediately upon closure The subtest sets 50 ms preempt timeout on each engine before proceding with submission of spins, then it waits up to 1 second for those spins to be terminated. However, dump of engines' debugfs data performed by the subtest after the failure shows preempt timeouts still at their default values: 7500 ms on rcs0 and 640 ms on other class engines. Dmesg records confirm preemption timeouts triggered on other engines after 640 ms and not on rcs0 within the 1 second limit. Fix the issue. Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6268 v2: Fix missing closing parenthesis. Janusz Krzysztofik (5): tests/gem_ctx_exec: Fail on unsuccessful preempt timeout update lib: Add more debug messages to error paths lib/gem_engine_topology: Fix premature break from primary find loop lib/gem_engine_topology: Simplify the method of opening a primary lib/gem_engine_topology: Fix broken compare of device links lib/i915/gem_engine_topology.c | 24 ++++++++++-------------- lib/igt_sysfs.c | 4 ++-- tests/intel/gem_ctx_exec.c | 5 +++-- 3 files changed, 15 insertions(+), 18 deletions(-)