mbox series

[v2,0/5] Miscelaneous fixes for display tracepoints

Message ID 20240923190324.83013-1-gustavo.sousa@intel.com (mailing list archive)
Headers show
Series Miscelaneous fixes for display tracepoints | expand

Message

Gustavo Sousa Sept. 23, 2024, 7:02 p.m. UTC
I recently bumped into some issues while using trace-cmd to inspect i915
display trace events. This series of patches provides fixes for them.

v2:
  - Add another patch to zero-initialize frame/scanline counts.
  - Add static_assert(PIPE_A == _TRACE_PIPE_A) in "Do not use ids from enum pipe
    in TP_printk()".

Gustavo Sousa (5):
  drm/i915/display: Fix out-of-bounds access in pipe-related tracepoints
  drm/i915/display: Zero-initialize frame/scanline counts in tracepoints
  drm/i915/display: Store pipe name in trace events
  drm/i915/display: Do not use ids from enum pipe in TP_printk()
  drm/i915/display: Cover all possible pipes in TP_printk()

 .../drm/i915/display/intel_display_trace.h    | 206 +++++++++++-------
 1 file changed, 125 insertions(+), 81 deletions(-)

Comments

Gustavo Sousa Oct. 4, 2024, 11:12 a.m. UTC | #1
Quoting Patchwork (2024-09-26 16:28:07-03:00)
>== Series Details ==
>
>Series: Miscelaneous fixes for display tracepoints (rev2)
>URL   : https://patchwork.freedesktop.org/series/137978/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_15449 -> Patchwork_137978v2
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_137978v2 absolutely need to be
>  verified manually.
>  
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_137978v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/index.html
>
>Participating hosts (37 -> 37)
>------------------------------
>
>  Additional (2): bat-dg2-14 bat-arls-1 
>  Missing    (2): bat-twl-1 fi-snb-2520m 
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_137978v2:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@i915_selftest@live:
>    - bat-mtlp-6:         [PASS][1] -> [ABORT][2] +1 other test abort
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-mtlp-6/igt@i915_selftest@live.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-mtlp-6/igt@i915_selftest@live.html

This does not seem related to this series, which is only about
tracepoints.

Jani or Rodrigo, ack to merge this series without triggering a new CI
cycle? I don't believe CI exercises tests that enable tracepoints. Or
does it?

--
Gustavo Sousa

>
>  
>Known issues
>------------
>
>  Here are the changes found in Patchwork_137978v2 that come from known issues:
>
>### IGT changes ###
>
>#### Issues hit ####
>
>  * igt@debugfs_test@basic-hwmon:
>    - bat-arls-1:         NOTRUN -> [SKIP][3] ([i915#9318])
>   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@debugfs_test@basic-hwmon.html
>
>  * igt@gem_lmem_swapping@random-engines:
>    - bat-arls-1:         NOTRUN -> [SKIP][4] ([i915#11671]) +3 other tests skip
>   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@gem_lmem_swapping@random-engines.html
>
>  * igt@gem_mmap@basic:
>    - bat-arls-1:         NOTRUN -> [SKIP][5] ([i915#11343] / [i915#4083])
>   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@gem_mmap@basic.html
>    - bat-dg2-14:         NOTRUN -> [SKIP][6] ([i915#4083])
>   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@gem_mmap@basic.html
>
>  * igt@gem_render_tiled_blits@basic:
>    - bat-dg2-14:         NOTRUN -> [SKIP][7] ([i915#4079]) +1 other test skip
>   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@gem_render_tiled_blits@basic.html
>    - bat-arls-1:         NOTRUN -> [SKIP][8] ([i915#10211] / [i915#4079])
>   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@gem_render_tiled_blits@basic.html
>
>  * igt@gem_tiled_blits@basic:
>    - bat-arls-1:         NOTRUN -> [SKIP][9] ([i915#10196] / [i915#4077]) +2 other tests skip
>   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@gem_tiled_blits@basic.html
>
>  * igt@gem_tiled_fence_blits@basic:
>    - bat-dg2-14:         NOTRUN -> [SKIP][10] ([i915#4077]) +2 other tests skip
>   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@gem_tiled_fence_blits@basic.html
>
>  * igt@gem_tiled_pread_basic:
>    - bat-arls-1:         NOTRUN -> [SKIP][11] ([i915#4079])
>   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@gem_tiled_pread_basic.html
>
>  * igt@i915_pm_rps@basic-api:
>    - bat-dg2-14:         NOTRUN -> [SKIP][12] ([i915#6621])
>   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@i915_pm_rps@basic-api.html
>    - bat-arls-1:         NOTRUN -> [SKIP][13] ([i915#11681])
>   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@i915_pm_rps@basic-api.html
>
>  * igt@i915_selftest@live:
>    - bat-arls-1:         NOTRUN -> [DMESG-WARN][14] ([i915#10341] / [i915#12133])
>   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@i915_selftest@live.html
>
>  * igt@i915_selftest@live@hangcheck:
>    - bat-arls-1:         NOTRUN -> [DMESG-WARN][15] ([i915#11349])
>   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@i915_selftest@live@hangcheck.html
>
>  * igt@kms_addfb_basic@addfb25-x-tiled-legacy:
>    - bat-arls-1:         NOTRUN -> [SKIP][16] ([i915#10200]) +8 other tests skip
>   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
>
>  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>    - bat-arls-1:         NOTRUN -> [SKIP][17] ([i915#10200] / [i915#12203])
>   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>    - bat-dg2-14:         NOTRUN -> [SKIP][18] ([i915#5190])
>   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>
>  * igt@kms_addfb_basic@basic-x-tiled-legacy:
>    - bat-dg2-14:         NOTRUN -> [SKIP][19] ([i915#4212]) +7 other tests skip
>   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_addfb_basic@basic-x-tiled-legacy.html
>
>  * igt@kms_addfb_basic@basic-y-tiled-legacy:
>    - bat-dg2-14:         NOTRUN -> [SKIP][20] ([i915#4215] / [i915#5190])
>   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>
>  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>    - bat-dg2-14:         NOTRUN -> [SKIP][21] ([i915#4103] / [i915#4213]) +1 other test skip
>   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>    - bat-arls-1:         NOTRUN -> [SKIP][22] ([i915#11346]) +1 other test skip
>   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>
>  * igt@kms_dsc@dsc-basic:
>    - bat-dg2-14:         NOTRUN -> [SKIP][23] ([i915#3555] / [i915#3840])
>   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_dsc@dsc-basic.html
>    - bat-arls-1:         NOTRUN -> [SKIP][24] ([i915#11346] / [i915#9886])
>   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_dsc@dsc-basic.html
>
>  * igt@kms_force_connector_basic@force-load-detect:
>    - bat-dg2-14:         NOTRUN -> [SKIP][25]
>   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_force_connector_basic@force-load-detect.html
>    - bat-arls-1:         NOTRUN -> [SKIP][26] ([i915#10207] / [i915#11346])
>   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_force_connector_basic@force-load-detect.html
>
>  * igt@kms_force_connector_basic@prune-stale-modes:
>    - bat-dg2-14:         NOTRUN -> [SKIP][27] ([i915#5274])
>   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_force_connector_basic@prune-stale-modes.html
>
>  * igt@kms_pm_backlight@basic-brightness:
>    - bat-dg2-14:         NOTRUN -> [SKIP][28] ([i915#5354])
>   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_pm_backlight@basic-brightness.html
>    - bat-arls-1:         NOTRUN -> [SKIP][29] ([i915#11346] / [i915#9812])
>   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_pm_backlight@basic-brightness.html
>
>  * igt@kms_psr@psr-primary-mmap-gtt:
>    - bat-arls-1:         NOTRUN -> [SKIP][30] ([i915#11346] / [i915#9732]) +3 other tests skip
>   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_psr@psr-primary-mmap-gtt.html
>
>  * igt@kms_psr@psr-sprite-plane-onoff:
>    - bat-dg2-14:         NOTRUN -> [SKIP][31] ([i915#1072] / [i915#9732]) +3 other tests skip
>   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_psr@psr-sprite-plane-onoff.html
>
>  * igt@kms_setmode@basic-clone-single-crtc:
>    - bat-dg2-14:         NOTRUN -> [SKIP][32] ([i915#3555])
>   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@kms_setmode@basic-clone-single-crtc.html
>    - bat-arls-1:         NOTRUN -> [SKIP][33] ([i915#10208] / [i915#8809])
>   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@kms_setmode@basic-clone-single-crtc.html
>
>  * igt@prime_vgem@basic-fence-flip:
>    - bat-dg2-14:         NOTRUN -> [SKIP][34] ([i915#3708])
>   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@prime_vgem@basic-fence-flip.html
>
>  * igt@prime_vgem@basic-fence-mmap:
>    - bat-dg2-14:         NOTRUN -> [SKIP][35] ([i915#3708] / [i915#4077]) +1 other test skip
>   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@prime_vgem@basic-fence-mmap.html
>
>  * igt@prime_vgem@basic-fence-read:
>    - bat-arls-1:         NOTRUN -> [SKIP][36] ([i915#10212] / [i915#3708])
>   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@prime_vgem@basic-fence-read.html
>
>  * igt@prime_vgem@basic-gtt:
>    - bat-arls-1:         NOTRUN -> [SKIP][37] ([i915#10196] / [i915#3708] / [i915#4077]) +1 other test skip
>   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@prime_vgem@basic-gtt.html
>
>  * igt@prime_vgem@basic-read:
>    - bat-dg2-14:         NOTRUN -> [SKIP][38] ([i915#3291] / [i915#3708]) +2 other tests skip
>   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-dg2-14/igt@prime_vgem@basic-read.html
>    - bat-arls-1:         NOTRUN -> [SKIP][39] ([i915#10214] / [i915#3708])
>   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@prime_vgem@basic-read.html
>
>  * igt@prime_vgem@basic-write:
>    - bat-arls-1:         NOTRUN -> [SKIP][40] ([i915#10216] / [i915#3708])
>   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-1/igt@prime_vgem@basic-write.html
>
>  
>#### Possible fixes ####
>
>  * igt@i915_selftest@live:
>    - fi-glk-j4005:       [ABORT][41] -> [PASS][42]
>   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/fi-glk-j4005/igt@i915_selftest@live.html
>   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/fi-glk-j4005/igt@i915_selftest@live.html
>
>  * igt@i915_selftest@live@execlists:
>    - fi-glk-j4005:       [ABORT][43] ([i915#11022]) -> [PASS][44]
>   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/fi-glk-j4005/igt@i915_selftest@live@execlists.html
>   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/fi-glk-j4005/igt@i915_selftest@live@execlists.html
>
>  
>#### Warnings ####
>
>  * igt@i915_module_load@reload:
>    - bat-arls-5:         [DMESG-WARN][45] ([i915#11637]) -> [DMESG-WARN][46] ([i915#11637] / [i915#1982])
>   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-arls-5/igt@i915_module_load@reload.html
>   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-5/igt@i915_module_load@reload.html
>
>  * igt@i915_selftest@live:
>    - bat-arls-5:         [DMESG-WARN][47] ([i915#10341] / [i915#12133]) -> [ABORT][48] ([i915#12061] / [i915#12133])
>   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-arls-5/igt@i915_selftest@live.html
>   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-5/igt@i915_selftest@live.html
>
>  * igt@i915_selftest@live@workarounds:
>    - bat-arls-5:         [DMESG-WARN][49] ([i915#10341] / [i915#11637]) -> [ABORT][50] ([i915#12061])
>   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-arls-5/igt@i915_selftest@live@workarounds.html
>   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-arls-5/igt@i915_selftest@live@workarounds.html
>
>  
>  [i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
>  [i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
>  [i915#10207]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10207
>  [i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
>  [i915#10211]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10211
>  [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
>  [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
>  [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
>  [i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
>  [i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
>  [i915#11022]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11022
>  [i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
>  [i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
>  [i915#11349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11349
>  [i915#11637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11637
>  [i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
>  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
>  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>  [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
>  [i915#12203]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12203
>  [i915#1982]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1982
>  [i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
>  [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
>  [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
>  [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
>  [i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
>  [i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
>  [i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
>  [i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
>  [i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
>  [i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
>  [i915#4215]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4215
>  [i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
>  [i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
>  [i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
>  [i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
>  [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
>  [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318
>  [i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
>  [i915#9812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9812
>  [i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886
>
>
>Build changes
>-------------
>
>  * Linux: CI_DRM_15449 -> Patchwork_137978v2
>
>  CI-20190529: 20190529
>  CI_DRM_15449: f82c02cc01798312082cc41feaa473538e517c7b @ git://anongit.freedesktop.org/gfx-ci/linux
>  IGT_8034: 73eed10d50c7d1f07df07214ae62924d4e377e12 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>  Patchwork_137978v2: f82c02cc01798312082cc41feaa473538e517c7b @ git://anongit.freedesktop.org/gfx-ci/linux
>
>== Logs ==
>
>For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/index.html
Jani Nikula Oct. 4, 2024, 11:33 a.m. UTC | #2
On Fri, 04 Oct 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Quoting Patchwork (2024-09-26 16:28:07-03:00)
>>#### Possible regressions ####
>>
>>  * igt@i915_selftest@live:
>>    - bat-mtlp-6:         [PASS][1] -> [ABORT][2] +1 other test abort
>>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-mtlp-6/igt@i915_selftest@live.html
>>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-mtlp-6/igt@i915_selftest@live.html
>
> This does not seem related to this series, which is only about
> tracepoints.
>
> Jani or Rodrigo, ack to merge this series without triggering a new CI
> cycle? I don't believe CI exercises tests that enable tracepoints. Or
> does it?

BAT *must* pass before merging, no exceptions.

Full shard run failures can be looked over when it's clear the series
didn't cause the failures.


BR,
Jani.
Gustavo Sousa Oct. 4, 2024, 11:43 a.m. UTC | #3
Quoting Jani Nikula (2024-10-04 08:33:20-03:00)
>On Fri, 04 Oct 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
>> Quoting Patchwork (2024-09-26 16:28:07-03:00)
>>>#### Possible regressions ####
>>>
>>>  * igt@i915_selftest@live:
>>>    - bat-mtlp-6:         [PASS][1] -> [ABORT][2] +1 other test abort
>>>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-mtlp-6/igt@i915_selftest@live.html
>>>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-mtlp-6/igt@i915_selftest@live.html
>>
>> This does not seem related to this series, which is only about
>> tracepoints.
>>
>> Jani or Rodrigo, ack to merge this series without triggering a new CI
>> cycle? I don't believe CI exercises tests that enable tracepoints. Or
>> does it?
>
>BAT *must* pass before merging, no exceptions.

Okay. Thanks.

--
Gustavo Sousa

>
>Full shard run failures can be looked over when it's clear the series
>didn't cause the failures.
>
>
>BR,
>Jani.
>
>
>-- 
>Jani Nikula, Intel
Saarinen, Jani Oct. 4, 2024, 12:03 p.m. UTC | #4
Hi. 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Gustavo Sousa
> Sent: Friday, 4 October 2024 14.43
> To: Nikula, Jani <jani.nikula@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>; i915-ci-infra@lists.freedesktop.org
> Subject: Re: ✗ Fi.CI.BAT: failure for Miscelaneous fixes for display tracepoints
> (rev2)
> 
> Quoting Jani Nikula (2024-10-04 08:33:20-03:00)
> >On Fri, 04 Oct 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> >> Quoting Patchwork (2024-09-26 16:28:07-03:00)
> >>>#### Possible regressions ####
> >>>
> >>>  * igt@i915_selftest@live:
> >>>    - bat-mtlp-6:         [PASS][1] -> [ABORT][2] +1 other test abort
> >>>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-mtlp-
> 6/igt@i915_selftest@live.html
> >>>   [2]:
> >>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-mtlp
> >>> -6/igt@i915_selftest@live.html
> >>
> >> This does not seem related to this series, which is only about
> >> tracepoints.
> >>
> >> Jani or Rodrigo, ack to merge this series without triggering a new CI
> >> cycle? I don't believe CI exercises tests that enable tracepoints. Or
> >> does it?
> >
> >BAT *must* pass before merging, no exceptions.
> 
> Okay. Thanks.
See original BAT results mail it says " If you think the reported changes have nothing to do with the changes  
> introduced in Patchwork_137978v2, please notify your bug team > (I915-ci-infra@lists.freedesktop.org) 
to allow them  to document this new failure mode, which will reduce false positives in CI." 
> 
> --
> Gustavo Sousa
> 
> >
> >Full shard run failures can be looked over when it's clear the series
> >didn't cause the failures.
> >
> >
> >BR,
> >Jani.
> >
> >
> >--
> >Jani Nikula, Intel
Saarinen, Jani Oct. 4, 2024, 12:09 p.m. UTC | #5
HI. 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Saarinen, Jani
> Sent: Friday, 4 October 2024 15.03
> To: Sousa, Gustavo <gustavo.sousa@intel.com>; Nikula, Jani
> <jani.nikula@intel.com>; intel-gfx@lists.freedesktop.org
> Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>; i915-ci-infra@lists.freedesktop.org
> Subject: RE: ✗ Fi.CI.BAT: failure for Miscelaneous fixes for display tracepoints
> (rev2)
> 
> Hi.
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> > Gustavo Sousa
> > Sent: Friday, 4 October 2024 14.43
> > To: Nikula, Jani <jani.nikula@intel.com>;
> > intel-gfx@lists.freedesktop.org
> > Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>;
> > i915-ci-infra@lists.freedesktop.org
> > Subject: Re: ✗ Fi.CI.BAT: failure for Miscelaneous fixes for display
> > tracepoints
> > (rev2)
> >
> > Quoting Jani Nikula (2024-10-04 08:33:20-03:00)
> > >On Fri, 04 Oct 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> > >> Quoting Patchwork (2024-09-26 16:28:07-03:00)
> > >>>#### Possible regressions ####
> > >>>
> > >>>  * igt@i915_selftest@live:
> > >>>    - bat-mtlp-6:         [PASS][1] -> [ABORT][2] +1 other test abort
> > >>>   [1]:
> > >>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15449/bat-mtlp-
> > 6/igt@i915_selftest@live.html
> > >>>   [2]:
> > >>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137978v2/bat-mt
> > >>> lp
> > >>> -6/igt@i915_selftest@live.html
> > >>
> > >> This does not seem related to this series, which is only about
> > >> tracepoints.
> > >>
> > >> Jani or Rodrigo, ack to merge this series without triggering a new
> > >> CI cycle? I don't believe CI exercises tests that enable
> > >> tracepoints. Or does it?
> > >
> > >BAT *must* pass before merging, no exceptions.
> >
> > Okay. Thanks.
> See original BAT results mail it says " If you think the reported changes have
> nothing to do with the changes
> > introduced in Patchwork_137978v2, please notify your bug team >
> > (I915-ci-infra@lists.freedesktop.org)
> to allow them  to document this new failure mode, which will reduce false
> positives in CI."

And ignore, I see you already added ci folks. 

> >
> > --
> > Gustavo Sousa
> >
> > >
> > >Full shard run failures can be looked over when it's clear the series
> > >didn't cause the failures.
> > >
> > >
> > >BR,
> > >Jani.
> > >
> > >
> > >--
> > >Jani Nikula, Intel