mbox series

[v2,0/5] drm/dp_mst: Fix DDI function/DP2 config programming

Message ID 20241030192313.4030617-1-imre.deak@intel.com (mailing list archive)
Headers show
Series drm/dp_mst: Fix DDI function/DP2 config programming | expand

Message

Imre Deak Oct. 30, 2024, 7:23 p.m. UTC 
This is v2 of [1] addressing the review comments as follows:

- Move the DP2 configuration enabling for both master and slave
  transcoders to intel_ddi_config_transcoder_func() and the disabling
  for slave transcoders to intel_ddi_disable_transcoder_func().
  (Patch 4, Jani)
- Disable the DP2 configuration for master transcoders as well.
  (Patch 5)

Cc: Jani Nikula <jani.nikula@intel.com>

[1] https://lore.kernel.org/all/20241029191215.3889861-1-imre.deak@intel.com

Imre Deak (5):
  drm/i915/ptl/dp_mst: Fix slave transcoder enabling wrt. DDI function
  drm/i915/adlp+/dp_mst: Align slave transcoder enabling with spec wrt.
    DDI function
  drm/i915/dp_mst: Add a way to disable the DP2 config
  drm/i915/adlp+/dp_mst: Align slave transcoder sequences with spec wrt.
    DP2 config
  drm/i915/adlp+/dp_mst: Align master transcoder disabling with spec
    wrt. DP2 config

 drivers/gpu/drm/i915/display/intel_ddi.c    | 37 +++++++++++++--------
 drivers/gpu/drm/i915/display/intel_ddi.h    |  2 ++
 drivers/gpu/drm/i915/display/intel_dp_mst.c |  3 ++
 3 files changed, 29 insertions(+), 13 deletions(-)

Comments

Imre Deak Oct. 30, 2024, 9:47 p.m. UTC | #1 
Hi CI team,

On Wed, Oct 30, 2024 at 09:24:59PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/dp_mst: Fix DDI function/DP2 config programming
> URL   : https://patchwork.freedesktop.org/series/140732/
> State : failure

the failure is unrelated, see below, could you please re-report this
result?

> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_15614 -> Patchwork_140732v1
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_140732v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_140732v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140732v1/index.html
> 
> Participating hosts (47 -> 46)
> ------------------------------
> 
>   Missing    (1): fi-snb-2520m 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_140732v1:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_pm_rpm@module-reload:
>     - bat-rpls-4:         [PASS][1] -> [DMESG-WARN][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15614/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140732v1/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

There is only an HDMI output on the above machine, so the DP only
changes in this patchset shouldn't have an effect on it.

The failure is:
<3> [200.000799] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun

and has already an open ticket:
https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12379

Earlier several CI runs failed on the same RPL_S machine (in different
tests), always on HDMI/pipe B:

./drmtip_1689/bat-rpls-4/10/dmesg.log:<3>[  552.684695] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./IGTPW_11973/bat-rpls-4/0/dmesg.log:<3>[  127.786110] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./IGTPW_12000/bat-rpls-4/0/dmesg.log:<3>[   78.002946] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./Patchwork_140196v3/bat-rpls-4/0/dmesg.log:<3>[   48.100895] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./IGTPW_11990/bat-rpls-4/0/dmesg.log:<3>[  145.511345] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./CI_DRM_15585/bat-rpls-4/0/dmesg.log:<3>[  139.892231] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./drmtip_1690/bat-rpls-4/23/dmesg.log:<3>[  335.533354] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./Patchwork_139978v3/bat-rpls-4/0/dmesg.log:<3>[  156.221305] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./IGTPW_11983/bat-rpls-4/0/dmesg.log:<3>[   30.789101] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./CI_DIN_1567/bat-rpls-4/0/dmesg.log:<3>[   53.293774] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./drmtip_1688/bat-rpls-4/12/dmesg.log:<3>[  147.044076] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./CI_DRM_15594/bat-rpls-4/0/dmesg.log:<3>[  136.706515] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./CI_DRM_15607/bat-rpls-4/0/dmesg.log:<3>[   74.942610] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./next-20241029/bat-rpls-4/0/dmesg.log:<3>[   42.161660] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./Patchwork_140379v2/bat-rpls-4/0/dmesg.log:<3>[   29.275714] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./next-20241023/bat-rpls-4/0/dmesg.log:<3>[   77.160192] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./drmtip_1687/bat-rpls-4/15/4/dmesg.txt:3,4918,42029436,-;i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun
./drmtip_1686/bat-rpls-4/23/dmesg.log:<3>[  274.243727] i915 0000:00:02.0: [drm] *ERROR* CPU pipe B FIFO underrun

> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_140732v1 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@i915_selftest@live:
>     - bat-arls-1:         [PASS][3] -> [ABORT][4] ([i915#12133])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15614/bat-arls-1/igt@i915_selftest@live.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140732v1/bat-arls-1/igt@i915_selftest@live.html
> 
>   * igt@i915_selftest@live@workarounds:
>     - bat-arls-1:         [PASS][5] -> [ABORT][6] ([i915#12061])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15614/bat-arls-1/igt@i915_selftest@live@workarounds.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140732v1/bat-arls-1/igt@i915_selftest@live@workarounds.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@i915_selftest@live@gt_heartbeat:
>     - bat-dg2-11:         [ABORT][7] ([i915#12133]) -> [PASS][8] +1 other test pass
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15614/bat-dg2-11/igt@i915_selftest@live@gt_heartbeat.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140732v1/bat-dg2-11/igt@i915_selftest@live@gt_heartbeat.html
> 
>   
>   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>   [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_15614 -> Patchwork_140732v1
> 
>   CI-20190529: 20190529
>   CI_DRM_15614: afdb5631acb317eca18b171006efb3930fef7eb4 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8088: 0030d5bc92b8e4ac991db1c88af1f0ad7593812a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_140732v1: afdb5631acb317eca18b171006efb3930fef7eb4 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140732v1/index.html