From patchwork Fri Nov 29 16:20:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jocelyn Falempe X-Patchwork-Id: 13888834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AFDFD729E7 for ; Fri, 29 Nov 2024 16:22:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E622210E4FD; Fri, 29 Nov 2024 16:22:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="MXkxjPPl"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF03410E517 for ; Fri, 29 Nov 2024 16:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732897375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T2NzOJNybc+OxZcBXIBIIDO3D2n3JMJ6jTFDWviJdRA=; b=MXkxjPPlzbLKlrs8w75EUJ/X6WR2h32bly15HL11sCMmgOsiskf7UC0SYVWPsH6kH0YVeo FjLd3pF6qDawry9G6oyJMjGEN6jDkcAT0RHc9mKIWIKUKhT4iwflQKXNm+vYQDpuDWi6ZM uAGDgc4qShPDlNpHT+uwZZlquTVSUMU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-451-3NM6bngZNY2P5h0oY6nDgQ-1; Fri, 29 Nov 2024 11:22:52 -0500 X-MC-Unique: 3NM6bngZNY2P5h0oY6nDgQ-1 X-Mimecast-MFC-AGG-ID: 3NM6bngZNY2P5h0oY6nDgQ Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 59423195394F; Fri, 29 Nov 2024 16:22:50 +0000 (UTC) Received: from hydra.redhat.com (unknown [10.39.192.13]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DD63F1955F2D; Fri, 29 Nov 2024 16:22:46 +0000 (UTC) From: Jocelyn Falempe To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jocelyn Falempe Subject: [RFC PATCH 0/5] drm/i915: Add drm_panic support Date: Fri, 29 Nov 2024 17:20:25 +0100 Message-ID: <20241129162232.7594-1-jfalempe@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" This is a first draft of drm_panic support for i915. I've tested it on the 3 intel laptops I have at my disposal. one Haswell with 128MB of eDRAM, one Cometlake and one Alderlake. I tested panic in both fbdev console and gnome desktop. I still have an issue with Alderlake, and it doesn't work when in gnome desktop. If I disable tiling on a framebuffer using DPT, then it displays some other memory location. As DPT is enabled only for tiled framebuffer, there might be some hardware limitations? I think it can be worked around by drawing the image tiled, (like what I've done on nouveau https://patchwork.freedesktop.org/series/133963/), but maybe there is another way? Best regards, Jocelyn Falempe (5): drm/i915/fbdev: Add intel_fbdev_getvaddr() drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes drm/i915/display: Add a disable_tiling() for skl planes drm/i915/gem: export i915_gem_object_map_page/pfn drm/i915: Add drm_panic support drivers/gpu/drm/i915/display/i9xx_plane.c | 24 +++++ .../gpu/drm/i915/display/intel_atomic_plane.c | 98 ++++++++++++++++++- .../drm/i915/display/intel_display_types.h | 2 + drivers/gpu/drm/i915/display/intel_fbdev.c | 5 + drivers/gpu/drm/i915/display/intel_fbdev.h | 5 + .../drm/i915/display/skl_universal_plane.c | 20 ++++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 5 + drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 +- 8 files changed, 160 insertions(+), 3 deletions(-) base-commit: 44cff6c5b0b17a78bc0b30372bcd816cf6dd282a