mbox series

[v2,0/3] Flush DMC wakelock release work at the end of runtime suspend

Message ID 20241129164010.29887-1-gustavo.sousa@intel.com (mailing list archive)
Headers show
Series Flush DMC wakelock release work at the end of runtime suspend | expand

Message

Gustavo Sousa Nov. 29, 2024, 4:37 p.m. UTC
We currently are not calling display runtime suspend functions when
D3cold is not allowed. That end up causing DMC wakelock to be enabled
because of dynamic DC states. Because of that, we need to make sure we
flush the release worker at the end of display runtime suspend.

v2:
  - Fixes for "drm/xe/display: Extract xe_display_pm_runtime_suspend_late()",
    see the patch changelog for details.

Gustavo Sousa (3):
  drm/i915/dmc_wl: Extract intel_dmc_wl_flush_release_work()
  drm/xe/display: Extract xe_display_pm_runtime_suspend_late()
  drm/xe/display: Flush DMC wakelock release work on runtime suspend

 drivers/gpu/drm/i915/display/intel_dmc_wl.c | 12 +++++++++++-
 drivers/gpu/drm/i915/display/intel_dmc_wl.h |  1 +
 drivers/gpu/drm/xe/display/xe_display.c     | 19 +++++++++++++++++++
 drivers/gpu/drm/xe/display/xe_display.h     |  2 ++
 drivers/gpu/drm/xe/xe_pm.c                  |  4 ++--
 5 files changed, 35 insertions(+), 3 deletions(-)

Comments

Gustavo Sousa Nov. 29, 2024, 5:36 p.m. UTC | #1
Quoting Patchwork (2024-11-29 14:17:41-03:00)
>== Series Details ==
>
>Series: Flush DMC wakelock release work at the end of runtime suspend (rev2)
>URL   : https://patchwork.freedesktop.org/series/141932/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_15763 -> Patchwork_141932v2
>====================================================
>
>Summary
>-------
>
>  **FAILURE**
>
>  Serious unknown changes coming with Patchwork_141932v2 absolutely need to be
>  verified manually.
>  
>  If you think the reported changes have nothing to do with the changes
>  introduced in Patchwork_141932v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>  to document this new failure mode, which will reduce false positives in CI.
>
>  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141932v2/index.html
>
>Participating hosts (46 -> 45)
>------------------------------
>
>  Missing    (1): fi-snb-2520m 
>
>Possible new issues
>-------------------
>
>  Here are the unknown changes that may have been introduced in Patchwork_141932v2:
>
>### IGT changes ###
>
>#### Possible regressions ####
>
>  * igt@i915_module_load@reload:
>    - bat-arlh-3:         [PASS][1] -> [INCOMPLETE][2]
>   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15763/bat-arlh-3/igt@i915_module_load@reload.html
>   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141932v2/bat-arlh-3/igt@i915_module_load@reload.html

This seems unrelated to this series. On the i915-side, the applied
changes are non-functional refactors and nothing on the log indicates an
issue on the DMC wakelock paths (all of which should be functionally a
no-op for ARL).

Please re-report.

--
Gustavo Sousa