| Message ID | 20241204100328.3738778-1-animesh.manna@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | LOBF enablement fix | expand |
Generic comments on these patches. These are enabling LOBF if it's possible. Possible errors are not taken into account. I think DP_ALPM_LOCK_TIMEOUT_ERROR should be taken into account in LOBF as well: See drivers/gpu/drm/i915/display/intel_psr.c:psr_alpm_check. You might also want to add some debug interface to disable lobf. I can imagine this being feature not working on all setups where possible on first try. Debugging/bisecting would be much easier if you have such interface. BR, Jouni Högander On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > Animesh Manna (2): > drm/i915/lobf: Add lobf enablement in post plane update > drm/i915/lobf: Add debug print for LOBF > > drivers/gpu/drm/i915/display/intel_alpm.c | 29 > +++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ > drivers/gpu/drm/i915/display/intel_display.c | 3 ++ > 3 files changed, 35 insertions(+), 1 deletion(-) >
> -----Original Message----- > From: Hogander, Jouni <jouni.hogander@intel.com> > Sent: Monday, December 9, 2024 2:14 PM > To: Manna, Animesh <animesh.manna@intel.com>; intel- > gfx@lists.freedesktop.org > Cc: Nikula, Jani <jani.nikula@intel.com>; B, Jeevan <jeevan.b@intel.com> > Subject: Re: [PATCH v2 0/2] LOBF enablement fix > > Generic comments on these patches. > > These are enabling LOBF if it's possible. Possible errors are not taken into > account. I think DP_ALPM_LOCK_TIMEOUT_ERROR should be taken into > account in LOBF as well: See > drivers/gpu/drm/i915/display/intel_psr.c:psr_alpm_check. Sure, will add checks for LOBF as well. > > You might also want to add some debug interface to disable lobf. I can > imagine this being feature not working on all setups where possible on first > try. Debugging/bisecting would be much easier if you have such interface. Got it, will try to add. Regards, Animesh > > BR, > > Jouni Högander > > On Wed, 2024-12-04 at 15:33 +0530, Animesh Manna wrote: > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > > > Animesh Manna (2): > > drm/i915/lobf: Add lobf enablement in post plane update > > drm/i915/lobf: Add debug print for LOBF > > > > drivers/gpu/drm/i915/display/intel_alpm.c | 29 > > +++++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ > > drivers/gpu/drm/i915/display/intel_display.c | 3 ++ > > 3 files changed, 35 insertions(+), 1 deletion(-) > >
Signed-off-by: Animesh Manna <animesh.manna@intel.com> Animesh Manna (2): drm/i915/lobf: Add lobf enablement in post plane update drm/i915/lobf: Add debug print for LOBF drivers/gpu/drm/i915/display/intel_alpm.c | 29 +++++++++++++++++++- drivers/gpu/drm/i915/display/intel_alpm.h | 4 +++ drivers/gpu/drm/i915/display/intel_display.c | 3 ++ 3 files changed, 35 insertions(+), 1 deletion(-)