mbox series

[v4,0/2] drm/i915/cmtg: Disable the CMTG

Message ID 20250104172937.64015-1-gustavo.sousa@intel.com (mailing list archive)
Headers show
Series drm/i915/cmtg: Disable the CMTG | expand

Message

Gustavo Sousa Jan. 4, 2025, 5:29 p.m. UTC
Next version of [1], with review comments addressed.

Note that I have added one extra "squash patch", because I was not sure that was
the correct way of handling sanitization and thought that having it separate
would make it easier for reviewers to check the change.

[1] https://lore.kernel.org/all/20241224165408.43778-1-gustavo.sousa@intel.com/

Gustavo Sousa (2):
  drm/i915/cmtg: Disable the CMTG
  squash! drm/i915/cmtg: Disable the CMTG

 drivers/gpu/drm/i915/Makefile                 |   1 +
 drivers/gpu/drm/i915/display/intel_cmtg.c     | 251 ++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_cmtg.h     |  18 ++
 .../gpu/drm/i915/display/intel_cmtg_regs.h    |  21 ++
 .../gpu/drm/i915/display/intel_display_core.h |   4 +
 .../drm/i915/display/intel_display_device.h   |   1 +
 .../drm/i915/display/intel_display_driver.c   |   5 +
 .../drm/i915/display/intel_modeset_setup.c    |  20 +-
 drivers/gpu/drm/i915/i915_reg.h               |   1 +
 drivers/gpu/drm/xe/Makefile                   |   1 +
 10 files changed, 318 insertions(+), 5 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg_regs.h

Comments

Jani Nikula Jan. 8, 2025, 2:19 p.m. UTC | #1
On Sat, 04 Jan 2025, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
> Next version of [1], with review comments addressed.
>
> Note that I have added one extra "squash patch", because I was not sure that was
> the correct way of handling sanitization and thought that having it separate
> would make it easier for reviewers to check the change.

I'm sorry, this is really hard for me to follow. Please just send the
actual patch you're suggesting. You can easily preserve the alternatives
in local branches in case you need to backtrack.

I did try to apply and squash this myself, but it's also conflicting
now.

BR,
Jani.



>
> [1] https://lore.kernel.org/all/20241224165408.43778-1-gustavo.sousa@intel.com/
>
> Gustavo Sousa (2):
>   drm/i915/cmtg: Disable the CMTG
>   squash! drm/i915/cmtg: Disable the CMTG
>
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  drivers/gpu/drm/i915/display/intel_cmtg.c     | 251 ++++++++++++++++++
>  drivers/gpu/drm/i915/display/intel_cmtg.h     |  18 ++
>  .../gpu/drm/i915/display/intel_cmtg_regs.h    |  21 ++
>  .../gpu/drm/i915/display/intel_display_core.h |   4 +
>  .../drm/i915/display/intel_display_device.h   |   1 +
>  .../drm/i915/display/intel_display_driver.c   |   5 +
>  .../drm/i915/display/intel_modeset_setup.c    |  20 +-
>  drivers/gpu/drm/i915/i915_reg.h               |   1 +
>  drivers/gpu/drm/xe/Makefile                   |   1 +
>  10 files changed, 318 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg.c
>  create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg.h
>  create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg_regs.h
Gustavo Sousa Jan. 13, 2025, 8:58 p.m. UTC | #2
Quoting Jani Nikula (2025-01-08 11:19:14-03:00)
>On Sat, 04 Jan 2025, Gustavo Sousa <gustavo.sousa@intel.com> wrote:
>> Next version of [1], with review comments addressed.
>>
>> Note that I have added one extra "squash patch", because I was not sure that was
>> the correct way of handling sanitization and thought that having it separate
>> would make it easier for reviewers to check the change.
>
>I'm sorry, this is really hard for me to follow. Please just send the
>actual patch you're suggesting. You can easily preserve the alternatives
>in local branches in case you need to backtrack.
>
>I did try to apply and squash this myself, but it's also conflicting
>now.

Rebased, fixed the conflicts and re-posted as v5:

  https://lore.kernel.org/all/20250113204815.114019-1-gustavo.sousa@intel.com/

--
Gustavo Sousa

>
>BR,
>Jani.
>
>
>
>>
>> [1] https://lore.kernel.org/all/20241224165408.43778-1-gustavo.sousa@intel.com/
>>
>> Gustavo Sousa (2):
>>   drm/i915/cmtg: Disable the CMTG
>>   squash! drm/i915/cmtg: Disable the CMTG
>>
>>  drivers/gpu/drm/i915/Makefile                 |   1 +
>>  drivers/gpu/drm/i915/display/intel_cmtg.c     | 251 ++++++++++++++++++
>>  drivers/gpu/drm/i915/display/intel_cmtg.h     |  18 ++
>>  .../gpu/drm/i915/display/intel_cmtg_regs.h    |  21 ++
>>  .../gpu/drm/i915/display/intel_display_core.h |   4 +
>>  .../drm/i915/display/intel_display_device.h   |   1 +
>>  .../drm/i915/display/intel_display_driver.c   |   5 +
>>  .../drm/i915/display/intel_modeset_setup.c    |  20 +-
>>  drivers/gpu/drm/i915/i915_reg.h               |   1 +
>>  drivers/gpu/drm/xe/Makefile                   |   1 +
>>  10 files changed, 318 insertions(+), 5 deletions(-)
>>  create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg.c
>>  create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg.h
>>  create mode 100644 drivers/gpu/drm/i915/display/intel_cmtg_regs.h
>
>-- 
>Jani Nikula, Intel